all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Phil Sainty <psainty@orcon.net.nz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 38575@debbugs.gnu.org
Subject: bug#38575: 27.0.50; Document that `diff' arguments OLD and NEW can be buffers
Date: Thu, 12 Dec 2019 23:15:37 +1300	[thread overview]
Message-ID: <e5d0977c-3b52-89a2-f8ea-3fb434ba9eb7@orcon.net.nz> (raw)
In-Reply-To: <835zilaogo.fsf@gnu.org>

On 12/12/19 10:21 PM, Eli Zaretskii wrote:
>> I suggest the following additional paragraph:
>>
>>      Non-interactively, OLD and NEW may each be buffers, in which
>>      case a temporary file will be used.
> 
> Why is it important to mention the fact that we use temporary files
> in this case?  It sounds like an implementation detail.

It is, but I think it's a helpful detail to include, to eliminate
potential confusion regarding how a buffer can be a valid input, when
the rest of the description is about files.

The user might otherwise wonder whether Emacs is actually using the
external diff program in this case (vs using some internal functions
to process the buffer text directly to produce a diff).

I'm ok with omitting it if you're not convinced.


-Phil





  reply	other threads:[~2019-12-12 10:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12  6:46 bug#38575: 27.0.50; Document that `diff' arguments OLD and NEW can be buffers Phil Sainty
2019-12-12  7:44 ` Phil Sainty
2019-12-12  9:23   ` Eli Zaretskii
2019-12-12  9:21 ` Eli Zaretskii
2019-12-12 10:15   ` Phil Sainty [this message]
2019-12-12 11:35     ` Eli Zaretskii
2019-12-14  8:22       ` Phil Sainty
2019-12-14  9:03         ` Eli Zaretskii
2020-08-21 15:01           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5d0977c-3b52-89a2-f8ea-3fb434ba9eb7@orcon.net.nz \
    --to=psainty@orcon.net.nz \
    --cc=38575@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.