From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73232: [PATCH] Allow vc-diff to suggest a default revision in vc-dir Date: Sat, 14 Sep 2024 19:13:40 +0300 Message-ID: References: <864j6jjzzn.fsf@gnu.org> <304daaee-52d8-46ec-98f6-fda27908451e@gutov.dev> <86seu2iumc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11913"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: sbaugh@janestreet.com, 73232@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 14 18:15:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spVQV-0002px-Dq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Sep 2024 18:15:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spVQD-0000Lz-8n; Sat, 14 Sep 2024 12:14:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spVQB-0000Lg-Fe for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 12:14:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1spVQB-0007wt-5w for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 12:14:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=64w0rR7FCyUEZvJe42SIQcHYNYyra7HLlbPaYShY9yw=; b=h2ivkI6ED4UqbW+oWYB2KnRyQw4zKj51eQlfbfR9CnxKjuN4hkxIURtH5qZ90ytMIpZjrLRH3BFuwn61B9NjIM6cmXXp+mFy8C3JM1JnwJTtJ84aOItaLqOo/pLIrl2M9UniMdXInLHzK8zlnbUN9nHTKoJJKvdvRiq/IXM85tWmdIq+YKSgtpL+J60qzAkTZdHrzei8Xj30O5lvBuaYPBvvOmtOTVT1xZR/fYL7Xm4HmhYIa8EiWfv/qgAUdDzp03KThEUG+ACCfDD/QP0HjfikobM3gvM8rK+BmvM3PVAhy13X3NVGI+/0QizEn7eLP8wZiqH2vY6/FFsN8QwOiw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1spVQL-00087T-Qd for bug-gnu-emacs@gnu.org; Sat, 14 Sep 2024 12:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Sep 2024 16:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73232-submit@debbugs.gnu.org id=B73232.172633044231094 (code B ref 73232); Sat, 14 Sep 2024 16:15:01 +0000 Original-Received: (at 73232) by debbugs.gnu.org; 14 Sep 2024 16:14:02 +0000 Original-Received: from localhost ([127.0.0.1]:47705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spVPO-00085Q-0v for submit@debbugs.gnu.org; Sat, 14 Sep 2024 12:14:02 -0400 Original-Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:38033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1spVPL-00084h-7U for 73232@debbugs.gnu.org; Sat, 14 Sep 2024 12:13:59 -0400 Original-Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 5F9DA13801EF; Sat, 14 Sep 2024 12:13:43 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Sat, 14 Sep 2024 12:13:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1726330423; x=1726416823; bh=64w0rR7FCyUEZvJe42SIQcHYNYyra7HLlbPaYShY9yw=; b= igsV0mL3txNju2qqRvP5OY478sFt8Vx70aGDDEV0YC5sG3E1uqEcD0SK/0FFy01k EPETPz7T5uQNfxw5BW4HzlZcZqbCRZ7zdj3uZAhjQ6wB61iQcDq40Gcn4bGtFrF4 vgJPZI0Y7UZfnvF3n24kjH5rhiYjxQJhBQ/BLlCkdKQGXoxzo64hqhFE60QjkKUA LUqzwi5HnqUZStFBDETip0Dz8aOfY3PiPV70fkyib0/Af+22ipvWD5Lr3fHc4M/h ZlFrk7+iwY3gtTVo5e4EUr+7gGPiyqLA5pTJQLULOKm9Ua4R+NAUeKbF3MxwTOHP T5IUclFdMmYXbidRIbz8Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726330423; x= 1726416823; bh=64w0rR7FCyUEZvJe42SIQcHYNYyra7HLlbPaYShY9yw=; b=p 0ZNW9oAxMa7lI6YouV+ueR1lzT0YsgqMArRy451kM+7ZGRi6CBcUj3NtxJ7z9jfl Djb6K62fja2K4F+wE55IU0smsnyDSyPgSH92Zrf0v+vpsUqSwKtiO+lAZTkcLDQz WNe53mibMrbfbx6WB2WIkO7IL1r2UlxSrhP9G0z9av2h5XjMipOpNeYh8UPtjNxS 4aPYjm5Q8gyPdl3a4sjEHRo4yWyK8GROuxZg6eq93Jyd++r8BLYGZvpFe30pWxKW 9ZumxkbKCCCjKfwrKghHiGKhHz//GNtB+dmr0m3b7JBp4vizqfRNEmHwVuU2ypSr rrg50u4R3Bb8xoMPRHXTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudektddgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh dprhgtphhtthhopehssggruhhghhesjhgrnhgvshhtrhgvvghtrdgtohhmpdhrtghpthht ohepjeefvdefvdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehjuhhrih eslhhinhhkohhvrdhnvght X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 14 Sep 2024 12:13:41 -0400 (EDT) Content-Language: en-US In-Reply-To: <86seu2iumc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291787 Archived-At: On 14/09/2024 10:04, Eli Zaretskii wrote: >> Also I wonder if it's okay to have a multi-paragraph description in the >> commit message. CONTRIBUTE seems to suggest one paragraph (if any) >> between the summary and the ChangeLog-style contents, but it doesn't >> suggest moving any parts of the description to the bug tracker. But IDK, >> for those who still read the changelog files (instead of using >> vc-print-root-log) this might be too much for a short change. The >> detailed description is great, though, so thanks. > > I've modified CONTRIBUTE to not insist on "a paragraph". (This is > exactly why I hate to codify stuff that is usually a no-brainer: > people tend to interpret each word and letter literally, as if they > were in a legally-binding document, and there's no end to complaints > and discussions about these unimportant details.) > > My POV is that the description should be as clear and concise as > possible. In most cases, there should be a bug report for the issue, > or some on-list discussion of it, and the gory details should be > described there, with only a reference left in the log message. And, > of course, the important stuff that explains how the code works and > why it does something non-trivial should be in comments in the code. > > IOW, I consider a long and very detailed description in the log > message a clear sign that something went wrong in the process: either > we didn't have the issue discussed in a place that can be referenced, > or the code needs to be cleaned-up or commented, or something else. > Git log is NOT the best place to document code changes. Thanks. So if I understand this right, we're allowed to have multiple paragraphs in the commit message's description, but we'd rather not. Perhaps we'd opt for this approach more often when there is no existing bug report. >> Eli and others, what do you think? > > If you are asking about this bug report, then frankly I don't > understand the use case: when would a user want to invoke this command > with point on a directory? I was asking primarily about the documentation standard, so it's okay if you don't have a strong position on this. Thanks anyway. > Directories are never important items in > VC-related activities; files are. IME it's pretty common to invoke vc-root-diff from the vc-dir buffer. And we also added the capability to call vc-diff from Dired recently. I don't do this myself often, TBH, but if someone is working in large repo, and the project is split into directories along subsystem lines, then one might want to make commits limited to subdirectories. Then it should be useful to call vc-diff on such a directory first.