From: Florian Rommel <mail@florommel.de>
To: Stefan Kangas <stefankangas@gmail.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ELPA] New package: bufferlo
Date: Sat, 04 Nov 2023 23:13:29 +0100 [thread overview]
Message-ID: <e518b4334be373e42cc5cc829bcaab5bed8df92a.camel@florommel.de> (raw)
In-Reply-To: <CADwFkmmWa7b9eKnA7Vy1xjGsoiyi31LtwOLAueGB2SN+RexnOg@mail.gmail.com>
On Sat, 2023-10-28 at 08:21 -0700, Stefan Kangas wrote:
> Thanks, do you mean to add it to GNU ELPA? If so, I see no reason why
> we can't add it. Please find some comments on your code below.
Yes, I would like to have it added to GNU ELPA.
> 1. Here are some warnings from `package-lint':
>
> 6 issues found:
>
> 146:22: error: You should depend on (emacs "28.1") if you need `clone-frame'.
> 147:22: error: You should depend on (emacs "29.1") if you need `undelete-frame'.
> 166:21: error: You should depend on (emacs "28.1") if you need `clone-frame'.
> 167:21: error: You should depend on (emacs "29.1") if you need `undelete-frame'.
The package works with 27.1.
The advices for `clone-frame' and `undelete-frame' are just
supplementary and not necessary for the functioning of bufferlo.
`add-advice' does not fail for undefined functions but seems to define
nonexistent functions as empty functions. To avoid this, I now check
`emacs-major-version' before adding the advice for `clone-frame' and
`undelete-frame'. Of course, this does not fix the warnings.
> 517:1: warning: `with-eval-after-load' is for use in configurations,
> and should rarely be used in packages.
> 523:1: warning: `with-eval-after-load' is for use in configurations,
> and should rarely be used in packages.
>
> 2. Here are some byte-compiler warnings:
>
> Compiling file /Users/skangas/wip/bufferlo/bufferlo.el at Sat Oct 28
> 17:12:56 2023
> bufferlo.el:518:26: Warning: reference to free variable
> ‘ibuffer-filtering-alist’
> bufferlo.el:517:24: Warning: assignment to free variable
> ‘ibuffer-filtering-alist’
> bufferlo.el:526:17: Warning: reference to free variable ‘ibuffer--filter-map’
>
> In end of data:
> bufferlo.el:527:19: Warning: the function
> ‘ibuffer-filter-by-bufferlo-local-buffers’ is not known to be defined.
> bufferlo.el: Warning: the function ‘ibuffer-pop-filter’ is not known to be
> defined.
> bufferlo.el: Warning: the function ‘ibuffer-update’ is not known to be
> defined.
> bufferlo.el: Warning: the function ‘ibuffer-push-filter’ is not known to be
> defined.
>
Bufferlo has ibuffer support but does not need ibuffer to be useful.
Therefore, I use `with-eval-after-load' blocks for the ibuffer-related
code. The free-variable warnings arise from the usage of ibuffer
variables in these blocks.
As an alternative, I could require ibuffer, which, however, would load
ibuffer for all users of bufferlo, even if they don't use it.
What is the preferred solution?
> 3. You might want to consider running `M-x checkdoc' as well.
I resolved all the remaining checkdoc warnings.
> 4. See the below diff with some stylistic improvements that I found
> while skimming the code:
Thanks, I applied your improvements.
For now, minus 'Package-Requires: ((emacs "29.1"))'
Regards,
Flo
next prev parent reply other threads:[~2023-11-04 22:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 19:50 [ELPA] New package: bufferlo Florian Rommel
2023-10-28 15:21 ` Stefan Kangas
2023-11-04 22:13 ` Florian Rommel [this message]
2023-11-05 14:32 ` Stefan Kangas
2023-11-05 14:47 ` Florian Rommel
2023-11-05 15:00 ` Stefan Kangas
2023-11-05 15:02 ` Florian Rommel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e518b4334be373e42cc5cc829bcaab5bed8df92a.camel@florommel.de \
--to=mail@florommel.de \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.