From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43383: 26.3; `toggle-menu-bar-mode-from-frame' Date: Wed, 16 Sep 2020 17:09:06 +0000 (UTC) Message-ID: References: <<7f20fd70-b8f0-490d-a3f8-36a7554c6ccd@default> <87tuw1dzlw.fsf@gnus.org>> <<834ko0beet.fsf@gnu.org>> <<877dsw8l81.fsf@gnus.org>> <<83ft7h7kym.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8713"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43383@debbugs.gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 16 19:10:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIawf-00027X-5j for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Sep 2020 19:10:13 +0200 Original-Received: from localhost ([::1]:36156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIawe-0005SZ-6l for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Sep 2020 13:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIawU-0005Ro-Uj for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 13:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIawU-00079D-Im for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 13:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIawU-0004MA-CB for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Sep 2020 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43383 X-GNU-PR-Package: emacs Original-Received: via spool by 43383-submit@debbugs.gnu.org id=B43383.160027617216702 (code B ref 43383); Wed, 16 Sep 2020 17:10:02 +0000 Original-Received: (at 43383) by debbugs.gnu.org; 16 Sep 2020 17:09:32 +0000 Original-Received: from localhost ([127.0.0.1]:35811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIavz-0004LK-Rx for submit@debbugs.gnu.org; Wed, 16 Sep 2020 13:09:32 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:60066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIavj-0004Ks-0A for 43383@debbugs.gnu.org; Wed, 16 Sep 2020 13:09:30 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08GH4pFt077787; Wed, 16 Sep 2020 17:09:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=uBRelEoUJibxFXIx8ak1YmkqX47Ydm27R38a854ko9E=; b=c7UV1lUr1HWqDqkdZX4G0hhF++LuaVllWQtmIQK4hoOlqdjrbbrixqnRt4c0SEa3RNI3 Z/IZrL8QYLzpfHf2k1So5uBN1hbbqtM6u4U0pss/tMnists5KgP9uFVPVV93Jqb0nqJG SNbi394NjoLwjESIb8+Mvomtq9dZNaX9AFm4/42tMw0ajWkySM0/gzSdDzzrXYY584Nl A4QGAKLzDvPo3iWdrRt1zIJdzYcsfUVIYe7I/OS6i5WLxumdTz/pD29hOSH68bjMShn6 UwxFdN/Ons9OLoFh6hqzzS3+GqkXYqa0t464s7hH4ATBRBQwice88Fy99UkFahrxXBr5 +Q== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 33gp9mcc50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 Sep 2020 17:09:09 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08GH4leE106257; Wed, 16 Sep 2020 17:09:08 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 33h8921rm8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Sep 2020 17:09:08 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08GH97Ew027592; Wed, 16 Sep 2020 17:09:07 GMT In-Reply-To: <<83ft7h7kym.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9746 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009160120 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9746 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009160120 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188175 Archived-At: > > > I think this command indeed has a bug, in that it cannot disable the > > > menu bar only on the frame from which it is invoked. It _can_ enable > > > the menu bar on a single frame, see my response to Drew. So I think > > > this command needs to be improved. But that's another issue; the doc > > > string definitely needs to be improved. Will you do that, or should > > > I? > > > > Please go ahead. >=20 > Done. >=20 > I'm not closing the bug, because I think we should make the command > work according to documentation: toggle the menu bar only on the frame > from which the command is invoked. I think it should manipulate the > menu-bar-lines frame parameter instead of invoking menu-bar mode. >=20 > Patches welcome. Isn't that what the code I sent does? Here it is again: (defun toggle-menu-bar-for-frame (&optional frame) "Toggle showing the menu-bar for selected frame. When called from Lisp, optional arg FRAME is used instead of the selected frame." (interactive) (let ((now (or (frame-parameter frame 'menu-bar-lines) 0))) (set-frame-parameter frame 'menu-bar-lines (if (zerop now) 1 0))))