From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@janestreet.com, 71179@debbugs.gnu.org
Subject: bug#71179: [PATCH] In rgrep, check matching files before excluding files
Date: Sat, 25 May 2024 16:03:00 +0300 [thread overview]
Message-ID: <e40c5d54-5292-480a-ba28-3211942b1e3b@gutov.dev> (raw)
In-Reply-To: <864jamyrzy.fsf@gnu.org>
On 25/05/2024 15:51, Eli Zaretskii wrote:
>>>>> In my benchmarking, this takes (rgrep "foo" "*.el" "~/src/emacs/trunk/")
>>>>> from ~410ms to ~130ms.
>>>>
>>>> I can confirm improvement here (though not exactly 3x).
>>>>
>>>> 1.9s to 1.3s in a Linux checkout, for example. Nice.
>>>
>>> Which is still quite minor.
>>
>> A 30% improvement is nothing to sneeze at, especially for a code change
>> as simple as this one.
>
> They are 30%, but they are only 600 milliseconds.
On my top-of-the-line laptop, even if it's a few years old. Take an
older or slower machine - and you might as well see a multi-second
difference. Just like in my example with the bigger project anyway.
One of my personal aims is to make Emacs more viable even for those who
work on large projects. That's why I routinely test certain operations
with Mozilla's codebase. And AFAIK Spencer's codebase is even larger.
>>>> Moving the files exclude instructions to the <F> placeholder is a slight
>>>> incompatibility
>>>
>>> Right, and for that reason, we cannot install this change as-is. We
>>> need either a different command or a user option controlling the order
>>> (with a good explanation of the effect of the difference).
>>
>> A user option might work, but before we add one it would be great to
>> understand who are the users that it is for.
>
> The ones for whom the proposed change will affect the results.
>
>>> Sorry, such incompatible changes are not acceptable, definitely when
>>> the gain is so small. Correctness trumps speed.
>>
>> Can you think of a specific problematic usage?
>
> Why is that needed? Isn't it clear that it can happen?
Provided we do add an option, knowing the actual audience could help
name it better and document it better.
But so far the audience I can think of is the very rare people who
misused the template's customization. And those can use an existing option.
next prev parent reply other threads:[~2024-05-25 13:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 20:14 bug#71179: [PATCH] In rgrep, check matching files before excluding files Spencer Baugh
2024-05-24 20:45 ` Dmitry Gutov
2024-05-24 20:54 ` Spencer Baugh
2024-05-25 12:31 ` Dmitry Gutov
2024-05-26 6:50 ` Juri Linkov
2024-05-26 12:48 ` Spencer Baugh
2024-05-26 12:56 ` Dmitry Gutov
2024-05-25 6:36 ` Eli Zaretskii
2024-05-25 12:26 ` Dmitry Gutov
2024-05-25 12:51 ` Eli Zaretskii
2024-05-25 13:03 ` Dmitry Gutov [this message]
2024-05-25 13:45 ` Eli Zaretskii
2024-05-25 13:58 ` Dmitry Gutov
2024-05-25 13:36 ` Spencer Baugh
2024-05-25 13:56 ` Eli Zaretskii
2024-05-25 14:02 ` Spencer Baugh
2024-05-25 14:13 ` Eli Zaretskii
2024-05-25 14:47 ` Dmitry Gutov
2024-05-25 15:07 ` Eli Zaretskii
2024-05-26 13:42 ` Spencer Baugh
2024-06-01 14:15 ` Eli Zaretskii
2024-06-02 10:46 ` Stefan Kangas
2024-05-25 14:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e40c5d54-5292-480a-ba28-3211942b1e3b@gutov.dev \
--to=dmitry@gutov.dev \
--cc=71179@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.