From: dhruva <dhruvakm@gmail.com>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: emacsclient on WXP does not work (as it used to)
Date: Fri, 31 Oct 2008 18:22:19 +0530 [thread overview]
Message-ID: <e3f230850810310552j34770b9bs9975672cad418d62@mail.gmail.com> (raw)
In-Reply-To: <e3f230850810310546v4c9581c0m10b891788c6af37a@mail.gmail.com>
That was premature, it does not work.. I apologise for that.
On Fri, Oct 31, 2008 at 6:16 PM, dhruva <dhruvakm@gmail.com> wrote:
> The following patch fixes this issue since tty and TERM does not make
> sense on windows (a wild guess though) ...
>
> diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
> index 0bbc385..0452cb3 100644
> --- a/lib-src/emacsclient.c
> +++ b/lib-src/emacsclient.c
> @@ -1446,7 +1446,6 @@ main (argc, argv)
> char *tty_name = NULL;
> #ifndef WINDOWSNT
> tty_name = ttyname (fileno (stdout));
> -#endif
>
> if (! tty_name)
> {
> @@ -1468,15 +1467,19 @@ main (argc, argv)
> " is not supported\n", progname);
> fail ();
> }
> +#endif
> +
> #if !defined (NO_SOCKETS_IN_FILE_SYSTEM)
> init_signals ();
> #endif
>
> +#ifndef WINDOWSNT
> send_to_emacs (emacs_socket, "-tty ");
> quote_argument (emacs_socket, tty_name);
> send_to_emacs (emacs_socket, " ");
> quote_argument (emacs_socket, type);
> send_to_emacs (emacs_socket, " ");
> +#endif
> }
>
> if (window_system)
>
> On Fri, Oct 31, 2008 at 5:57 PM, Juanma Barranquero <lekktu@gmail.com> wrote:
>> On Fri, Oct 31, 2008 at 12:15, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>> Can you please explain why is this a problem on Windows? I understand
>>> that the addition of current_frame to the `if' clause causes it to be
>>> entered on Windows, whereas it wasn't before, but how does that, and
>>> the fact that tty_name is NULL, cause emacsclient failure reported by
>>> dhruva?
>>
>> I don't know why dhruva got the "connect" error message. My guess is
>> that they are two different problems:
>>
>> 1.- emacsclient opened the socket (so no INVALID_SOCKET), but couldn't connect
>> 2.- emacsclient couldn't get the terminal name, and it didn't have
>> alternate-editor
>>
>> though I don't know how or why 2) would happen, unless there were two
>> different emacsclients involved, called through alternate-editor (and
>> even so, it doesn't make much sense).
>>
>> But anyway, my point was just that the very next code after the if() is
>>
>> char *type = egetenv ("TERM");
>> char *tty_name = NULL;
>> #ifndef WINDOWSNT
>> tty_name = ttyname (fileno (stdout));
>> #endif
>>
>> if (! tty_name)
>> {
>> message (TRUE, "%s: could not get terminal name\n", progname);
>> fail ();
>> }
>>
>> so entering the if() is *always* going to fail(). I'm unable to see
>> how that be useful on Windows.
>>
>>> Agreed (to the ``ugly'' part).
>>
>> Glad we agree on this :)
>>
>> Have you any comment about the other part? ("Are there legitimate uses
>> of tty == 1 on Windows?")
>>
>>> I'd like to try to find a less ugly fix.
>>
>> It's Chong's patch, perhaps he can shed a bit of light.
>>
>> Juanma
>>
>
>
>
> --
> Contents reflect my personal views only!
>
--
Contents reflect my personal views only!
next prev parent reply other threads:[~2008-10-31 12:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 10:35 emacsclient on WXP does not work (as it used to) dhruva
2008-10-31 11:02 ` Juanma Barranquero
2008-10-31 11:15 ` Eli Zaretskii
2008-10-31 12:27 ` Juanma Barranquero
2008-10-31 12:46 ` dhruva
2008-10-31 12:52 ` dhruva [this message]
2008-10-31 12:53 ` Juanma Barranquero
2008-10-31 12:57 ` dhruva
2008-10-31 12:52 ` Juanma Barranquero
2008-10-31 12:58 ` dhruva
2008-10-31 13:10 ` Juanma Barranquero
2008-10-31 13:38 ` dhruva
2008-10-31 13:40 ` dhruva
2008-10-31 14:22 ` Juanma Barranquero
2008-10-31 14:27 ` Juanma Barranquero
2008-10-31 14:29 ` dhruva
2008-10-31 14:13 ` Chong Yidong
2008-10-31 14:14 ` Juanma Barranquero
2008-10-31 14:44 ` Eli Zaretskii
2008-10-31 15:21 ` dhruva
2008-11-01 13:53 ` Eli Zaretskii
2008-11-01 14:55 ` Juanma Barranquero
2008-11-01 16:41 ` Eli Zaretskii
2008-11-01 17:01 ` Eli Zaretskii
2008-11-02 4:03 ` Juanma Barranquero
2008-11-02 4:19 ` Eli Zaretskii
2008-11-01 17:02 ` Eli Zaretskii
2008-11-02 2:59 ` dhruva
2008-11-02 4:17 ` Eli Zaretskii
2008-10-31 21:58 ` Andreas Schwab
2008-10-31 14:31 ` Newsticker is jealous Paul R
2008-10-31 14:43 ` Paul R
2008-10-31 17:21 ` Ulf Jasper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3f230850810310552j34770b9bs9975672cad418d62@mail.gmail.com \
--to=dhruvakm@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.