all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: dhruva <dhruvakm@gmail.com>
To: "Jason Rumney" <jasonr@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Build failure on M$ (using MSVC): Patch enclosed
Date: Thu, 22 May 2008 14:59:01 +0530	[thread overview]
Message-ID: <e3f230850805220229g2af5b636s4a1ea76a03dcf18@mail.gmail.com> (raw)
In-Reply-To: <e3f230850805220210k1691663ei3a722fe4fae99cf7@mail.gmail.com>

Hi,
 The below patch fixes the string header file issue. Since there is
support to either include the strings.h or string.h based on some
defines, I have added them in the compiler specific files for M$. If
the same is added to other platforms, we will no longer have to
include string/strings header directly, which I guess was the
intention in having it in src/config.h or nt/config.nt.

-dhruva

diff --git a/nt/gmake.defs b/nt/gmake.defs
index 00ae686..5a7b28b 100644
--- a/nt/gmake.defs
+++ b/nt/gmake.defs
@@ -204,7 +204,7 @@ else
 DEBUG_CFLAGS	=
 endif
 CFLAGS          = -I. -DWIN32_LEAN_AND_MEAN -D_WIN32_WINNT=0x0400 \
-		  $(ARCH_CFLAGS) -D$(ARCH) -D_CRTAPI1=_cdecl \
+		  $(ARCH_CFLAGS) -D$(ARCH) -D_CRTAPI1=_cdecl -DHAVE_STRINGS_H \
 		  $(DEBUG_CFLAGS) $(USER_CFLAGS) $(LOCAL_FLAGS)
 EMACS_EXTRA_C_FLAGS = -DUSE_CRT_DLL=1 $(FONT_CFLAGS)

diff --git a/nt/nmake.defs b/nt/nmake.defs
index 7c6a518..8cf9f9e 100644
--- a/nt/nmake.defs
+++ b/nt/nmake.defs
@@ -142,7 +142,7 @@ DEBUG_CFLAGS	= -DEMACSDEBUG
 DEBUG_CFLAGS	=

 !endif

 CFLAGS          = -I. -DWIN32_LEAN_AND_MEAN -D_WIN32_WINNT=0x0400 \

-		  $(ARCH_CFLAGS) -D$(ARCH) -D_CRTAPI1=_cdecl \

+		  $(ARCH_CFLAGS) -D$(ARCH) -D_CRTAPI1=_cdecl -DHAVE_STRING_H \

 		  $(DEBUG_CFLAGS) $(USER_CFLAGS) $(LOCAL_FLAGS)

 EMACS_EXTRA_C_FLAGS = $(FONT_CFLAGS)



diff --git a/src/font.c b/src/font.c
index 84f2a2a..42e62d5 100644
--- a/src/font.c
+++ b/src/font.c
@@ -22,7 +22,6 @@ along with GNU Emacs.  If not, see
<http://www.gnu.org/licenses/>.  */
 #include <config.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <strings.h>
 #include <ctype.h>
 #ifdef HAVE_M17N_FLT
 #include <m17n-flt.h>
diff --git a/src/s/ms-w32.h b/src/s/ms-w32.h
index 3e043c8..b748b3b 100644
--- a/src/s/ms-w32.h
+++ b/src/s/ms-w32.h
@@ -510,6 +510,11 @@ extern void _DebPrint (const char *fmt, ...);
 #define DebPrint(stuff)
 #endif

+#ifndef __GNUC__
+#ifndef strcasecmp
+#define strcasecmp(a,b) stricmp(a,b)
+#endif
+#endif

 /* ============================================================ */


-- 
Contents reflect my personal views only!




  reply	other threads:[~2008-05-22  9:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  4:58 Build failure on M$ (using MSVC): Patch enclosed dhruva
2008-05-20  6:10 ` dhruva
2008-05-20  8:26   ` dhruva
2008-05-20  8:58     ` dhruva
2008-05-20  9:46       ` Jason Rumney
2008-05-20 10:21         ` David Kastrup
2008-05-20 11:57           ` dhruva
2008-05-20 12:01             ` dhruva
2008-05-20 18:26       ` Eli Zaretskii
2008-05-20 12:11     ` Herbert Euler
2008-05-20 18:30       ` Eli Zaretskii
2008-05-20 18:12 ` Eli Zaretskii
2008-05-21  3:13   ` dhruva
2008-05-21 17:28     ` Stefan Monnier
2008-05-22  3:51       ` dhruva
2008-05-22  4:46         ` Stefan Monnier
2008-05-22  5:03           ` dhruva
2008-05-22  6:52             ` David Kastrup
2008-05-22  7:10               ` dhruva
2008-05-22  7:32                 ` David Kastrup
2008-05-22 15:49                 ` Stefan Monnier
2008-05-22 15:45               ` Stefan Monnier
2008-05-22  6:56             ` dhruva
2008-05-23  8:30               ` Eli Zaretskii
2008-05-23  9:15                 ` Jason Rumney
2008-05-22  8:32         ` Jason Rumney
2008-05-22  9:10           ` dhruva
2008-05-22  9:29             ` dhruva [this message]
2008-05-22 12:31               ` Jason Rumney
2008-05-22 13:10                 ` Jason Rumney
2008-05-22 13:33                   ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3f230850805220229g2af5b636s4a1ea76a03dcf18@mail.gmail.com \
    --to=dhruvakm@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jasonr@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.