From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: dhruva Newsgroups: gmane.emacs.devel Subject: Re: Build failure on M$ (using MSVC): Patch enclosed Date: Thu, 22 May 2008 12:26:11 +0530 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1211439412 31139 80.91.229.12 (22 May 2008 06:56:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 May 2008 06:56:52 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 22 08:57:29 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jz4jg-0001e8-6S for ged-emacs-devel@m.gmane.org; Thu, 22 May 2008 08:57:12 +0200 Original-Received: from localhost ([127.0.0.1]:45737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jz4iv-0004kZ-Uy for ged-emacs-devel@m.gmane.org; Thu, 22 May 2008 02:56:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jz4ip-0004gh-3i for emacs-devel@gnu.org; Thu, 22 May 2008 02:56:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jz4im-0004ea-FJ for emacs-devel@gnu.org; Thu, 22 May 2008 02:56:18 -0400 Original-Received: from [199.232.76.173] (port=34484 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jz4im-0004eR-AO for emacs-devel@gnu.org; Thu, 22 May 2008 02:56:16 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:18558) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jz4im-0001zk-19 for emacs-devel@gnu.org; Thu, 22 May 2008 02:56:16 -0400 Original-Received: from ti-out-0910.google.com ([209.85.142.187]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jz4ik-0005oP-Vx for emacs-devel@gnu.org; Thu, 22 May 2008 02:56:15 -0400 Original-Received: by ti-out-0910.google.com with SMTP id u5so2474630tia.10 for ; Wed, 21 May 2008 23:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=d45Estf53xJYzBnJkOr79g1KHRuvDYyfcJjcXLv1uss=; b=Hu+d13f2MD6rZmqtvuZ7C7NLH1WqLSR/gJ+d4FUPjstkaaPZE2qRSIXeO10DcAkZj7M0hJmU9qzoyPukuHRFv9Uv2xC9sTMhkK6m2ZF7CAwO+/zeTBmpo0ai4AixlwcupUy7t67flDrtdQw5jkYGKT53cMc9XZDEchs4kpLatmE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=dr4V7XgOhQAeV1vdVDphBTMnC+34frcudasYwR8J0biDjYfsXNfOLxMd3mXQsb6UYu2Y2U+ZNlLceNTdHSfwyhfN37T7SzbBRxKr+81XzSgcKqXuBur7xlJGGu+1HAP9rJ3+S3TiFeWCItCQyS5jMJsU/aW7Jq8t1zMwBoEAn58= Original-Received: by 10.110.69.5 with SMTP id r5mr1392216tia.17.1211439371042; Wed, 21 May 2008 23:56:11 -0700 (PDT) Original-Received: by 10.110.90.17 with HTTP; Wed, 21 May 2008 23:56:11 -0700 (PDT) In-Reply-To: Content-Disposition: inline X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97504 Archived-At: Hi, For fixing the build failure on M$ in src/font.c, there is a more elegant alternative approach. 1. Remove the "#include " from that file 2. Define HAVE_STRINGS_H if using GCC or define HAVE_STRING_H if using MSVC. src/config.h and nt/config.nt both include string/strings header based on the above define. 3. Retain the strcasecmp to stricmp in src/s/ms-w32.h -dhruva -- Contents reflect my personal views only!