From: dhruva <dhruvakm@gmail.com>
To: "Jason Rumney" <jasonr@gnu.org>
Cc: Glenn Morris <rgm@gnu.org>, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [andrew.maguire@ge.com: Emacs 22.1 hung after delete-process]
Date: Fri, 17 Aug 2007 23:01:33 +0530 [thread overview]
Message-ID: <e3f230850708171031l162b4b3x83e81332c2f70af8@mail.gmail.com> (raw)
In-Reply-To: <46C5A60D.5010108@gnu.org>
Hi,
On 8/17/07, Jason Rumney <jasonr@gnu.org> wrote:
> dhruva wrote:
> > Hi,
> > I have put it a fix that seems to solve this problem
> > ! if (WaitForSingleObject (cp->thrd, 1000) != WAIT_OBJECT_0)
> >
>
> Why would WaitSingleObject act differently depending on which compiler
> was use to compile Emacs? It is a system call. I think the problem lies
> elsewhere, and this is just a workaround (which could itself lead to
> indefinite hanging of Emacs).
I have not modified the the call to WaitForSingleObject in the latest
patch. I doubt the implementation of read which could be different for
different compilers (C-runtime library).
It is the call to read in _sys_read_ahead which continues to block
even after the sub process is killed. If we change that read to use
ReadFile using OVERLAPPED structure, we could handle canceling of IO
when we want to terminate the thread more elegantly. But, that would
be more changes as we need to use the HANDLE and not fd.
-dky
--
Dhruva Krishnamurthy
Contents reflect my personal views only!
next prev parent reply other threads:[~2007-08-17 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 18:21 [andrew.maguire@ge.com: Emacs 22.1 hung after delete-process] Richard Stallman
2007-08-16 3:24 ` Glenn Morris
2007-08-16 4:46 ` dhruva
2007-08-17 0:32 ` Richard Stallman
2007-08-16 8:02 ` Jason Rumney
2007-08-16 12:42 ` dhruva
2007-08-16 14:09 ` dhruva
2007-08-16 17:04 ` dhruva
2007-08-16 19:41 ` Eli Zaretskii
2007-08-17 0:32 ` Richard Stallman
2007-08-17 5:27 ` dhruva
2007-08-27 10:07 ` dhruva
2007-09-02 17:02 ` Jason Rumney
2007-08-17 13:43 ` Jason Rumney
2007-08-17 17:31 ` dhruva [this message]
2007-08-17 20:40 ` Jason Rumney
2007-08-19 7:42 ` dhruva
2007-08-22 6:29 ` dhruva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3f230850708171031l162b4b3x83e81332c2f70af8@mail.gmail.com \
--to=dhruvakm@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
--cc=rgm@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.