From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20637: incompatible, undocumented change to vc-working-revision Date: Thu, 14 Apr 2016 17:20:41 +0300 Message-ID: References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1460646671 25387 80.91.229.3 (14 Apr 2016 15:11:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Apr 2016 15:11:11 +0000 (UTC) Cc: 20637@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 14 17:10:56 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aqiv1-0000um-4W for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Apr 2016 17:10:55 +0200 Original-Received: from localhost ([::1]:41226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqiv0-00052L-JT for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Apr 2016 11:10:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqi8n-0001TA-Mn for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 10:21:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqi8k-0005OB-DZ for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 10:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqi8k-0005O4-9w for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aqi8k-00047F-5z for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Apr 2016 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20637-submit@debbugs.gnu.org id=B20637.146064365215796 (code B ref 20637); Thu, 14 Apr 2016 14:21:02 +0000 Original-Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 14:20:52 +0000 Original-Received: from localhost ([127.0.0.1]:35451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqi8a-00046i-DT for submit@debbugs.gnu.org; Thu, 14 Apr 2016 10:20:52 -0400 Original-Received: from mail-wm0-f65.google.com ([74.125.82.65]:33364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqi8Y-00046U-O1 for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 10:20:51 -0400 Original-Received: by mail-wm0-f65.google.com with SMTP id y144so23276034wmd.0 for <20637@debbugs.gnu.org>; Thu, 14 Apr 2016 07:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=UILCPxipKxWEcFyb95JY/Zs6fGNB/azUw6MTpSEUN6A=; b=rWbT2Jt7nPf3mZrh4WyHhlJa2x4L/caTOP7DNIIiQRDmy1pV/o+AN1GbBLoiWohpez JwzN1/gC5ggHSQc+czYQNxKmi7EJsorwdmVjidY8YJs+QFEVrcx4keIwOUmMfRjMNk3i /StHZNKhTLxBVcpfEaNS433ng0DJrKZw+fV7VYdDf1PrY9vUAf4xv71u3d8HLwDocDKT DFHgk/XOoUxQXx61fpToVQozh1PRXS0S4aItYmHqjZbxz810NAxU7RKgLN+vjxCicrch KYVcQnhtU0LONfbCdDwhjJCcr/ilHxbeVsdfK2GbMRWaAmISE32ntqtRsEUuxD5aeTlY yCww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=UILCPxipKxWEcFyb95JY/Zs6fGNB/azUw6MTpSEUN6A=; b=TWoGvsGcLhDGIw4g9ht8bd2MI1o2N9mYJAx3p4HQTMQs1/BvDJBbvTr/GfStagvkDQ GNFZzevRNGoDYx5E2mS3t+CmvEbOGZ2WB6RItH3L79w8FAkCgjuYPREH4279uMNjSuIV 6JQaz4eDPNICY6jP2WALGsf2h3nc1UK1fJBGroqjayKK23L1qUfLp5d/cIvwO55Wx9ht BZ4q2nHGKtyW8SqGxx9QhMULl7mp4I080lAdgVOMJ9xYIX5hT62Wv+W/9I0X3zNGBCWs KXEBw+hBUasOIrERomJJ4PVEYzcZe9PtaQnMBL5juNED6cbT0iIT14bPWFzszzLW6Onz Dc3Q== X-Gm-Message-State: AOPr4FW7QSO9q55qB8xJprVlOzZCSzFLJpqxba03LHsLS6OH12yGmX5GxbUt0zpXZ9dFHw== X-Received: by 10.28.59.7 with SMTP id i7mr17555925wma.66.1460643644862; Thu, 14 Apr 2016 07:20:44 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id b135sm33813674wmb.10.2016.04.14.07.20.42 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Apr 2016 07:20:43 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <87potshczh.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116456 Archived-At: On 04/14/2016 10:21 AM, Michael Albinus wrote: > I haven't thought too much about performance. But you are right, we > shouldn't add serious performance penalties to the code. And improving > performance for the 25.1 release is much too late. It's hard for me to judge how serious those are, really (I only have a fast laptop with GNU/Linux these days), but being wary of extra process calls seems prudent. Ideally, we'd reduce their number, not increase it. > So we might revert the patch for vc-state and vc-working-revision indeed > for the emacs-25 branch, going back to using vc-backend. Thanks, I agree. > In the master branch we might apply my proposed patch using > vc-registered or something similar, and start to improve performance. Improve how? Would you like to comment on the last paragraph of my previous email in this subthread? I don't really see a point in returning `unregistered' from `vc-state'. When would the caller treat it differently from nil? And returning nil seems like an easier choice, implementation-wise, and well as a more conservative one from the backward compatibility perspective. The `dir-status-files' backend command would continue including the `unregistered' entries (we could make it skip the up-to-date ones, though, in the interest of improving performance). > In > parallel, we shall start to write a VCS section for the elisp manual, > describing vc-* functionality in more detail. We could start with > vc-backend and vc-responsible-backend and their intended use. I'm > missing such documentation for years. I'd rather put the missing information into the docstrings, really. It seems unlikely that we're missing more than a few sentences in these two functions' descriptions, and we could also rephrase the existing ones. But if you'd be more comfortable with having that information in the manual as well, don't let me stop you. > I'll come back later today with the patch for emacs-25, if you agree. In any case, I definitely agree with reverting vc-state and vc-working-revision to use vc-backend in Emacs 25.1.