pdumper test failures: invalid faces

pdumper test failures: invalid faces

[Glenn Morris]

It's fantastic to see a portable dumper for Emacs!

"make check" has a number of failures, which I assume are not specific
to my machine. Many are to do with invalid faces. A minimal example
might be:

./src/emacs -Q --batch --eval "(describe-face 'shadow)"
-> "Invalid face: tooltip"


Unrelated:
pdumper.c has no copyright header
pdumper.h, fingerprint.h, fingerprint-dummy.c have outdated copyright years
make-fingerprint.c has outdated and probably bogus years

Re: pdumper test failures: invalid faces

[Daniel Colascione]

On 02/16/2018 10:23 AM, Glenn Morris wrote:
> 
> It's fantastic to see a portable dumper for Emacs!
> 
> "make check" has a number of failures, which I assume are not specific
> to my machine. Many are to do with invalid faces. A minimal example
> might be:
> 
> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
> -> "Invalid face: tooltip"

Thankfully, the tooltip face does exist when we start Emacs for 
interactive use, so I suspect some kind of face-initialization 
weirdness, not fundamental dump-restoration breakage.

> Unrelated:
> pdumper.c has no copyright header
> pdumper.h, fingerprint.h, fingerprint-dummy.c have outdated copyright years
> make-fingerprint.c has outdated and probably bogus years

Yeah. The pdumper branch will need a bit of cleanup and documentation 
before we merge it into master.

Re: pdumper test failures: invalid faces

[Daniel Colascione]

On 02/16/2018 10:23 AM, Glenn Morris wrote:
> 
> It's fantastic to see a portable dumper for Emacs!
> 
> "make check" has a number of failures, which I assume are not specific
> to my machine. Many are to do with invalid faces. A minimal example
> might be:
> 
> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
> -> "Invalid face: tooltip"

A portably-dumped Emacs can now pass its test suite, and the command you 
gave above now works correctly.

Re: pdumper test failures: invalid faces

[Clément Pit-Claudel]

On 2018-02-26 01:27, Daniel Colascione wrote:
> On 02/16/2018 10:23 AM, Glenn Morris wrote:
>>
>> It's fantastic to see a portable dumper for Emacs!
>>
>> "make check" has a number of failures, which I assume are not specific
>> to my machine. Many are to do with invalid faces. A minimal example
>> might be:
>>
>> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
>> -> "Invalid face: tooltip"
> 
> A portably-dumped Emacs can now pass its test suite, and the command you gave above now works correctly.

Neat! One thing I just noticed: deleting the dump file and running 'make' doesn't seem to recreate it.

Re: pdumper test failures: invalid faces

[Daniel Colascione]

On 02/25/2018 11:22 PM, Clément Pit-Claudel wrote:
> On 2018-02-26 01:27, Daniel Colascione wrote:
>> On 02/16/2018 10:23 AM, Glenn Morris wrote:
>>>
>>> It's fantastic to see a portable dumper for Emacs!
>>>
>>> "make check" has a number of failures, which I assume are not specific
>>> to my machine. Many are to do with invalid faces. A minimal example
>>> might be:
>>>
>>> ./src/emacs -Q --batch --eval "(describe-face 'shadow)"
>>> -> "Invalid face: tooltip"
>>
>> A portably-dumped Emacs can now pass its test suite, and the command you gave above now works correctly.
> 
> Neat! One thing I just noticed: deleting the dump file and running 'make' doesn't seem to recreate it.

Fixed, probably.