bug#9030: `where-is' doesn't play well `with with-output-to-string'

[Glenn Morris <rgm@gnu.org>]

PJ Weisberg wrote:

> (with-output-to-string
>   (where-is 'yank))
>
> returns nil, and prints a message in the echo area.  This one-line
> change fixes it:
[...]
> --- a/lisp/help.el
> +++ b/lisp/help.el
> @@ -527,7 +527,7 @@ If INSERT (the prefix arg) is non-nil, insert the
> message in the buffer."
>    (unless definition (error "No command"))
>    (let ((func (indirect-function definition))
>          (defs nil)
> -        (standard-output (if insert (current-buffer) t)))
> +        (standard-output (if insert (current-buffer) standard-output)))
>      ;; In DEFS, find all symbols that are aliases for DEFINITION.
>      (mapatoms (lambda (symbol)
>  		(and (fboundp symbol)


Tangentially, I wonder why where-is needs an optional INSERT argument
that means "don't print the result, instead insert it (oh, and use a
slightly different format)".