From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Sun, 23 Jul 2023 20:58:24 +0300 Message-ID: References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <87r0p030w0.fsf@yahoo.com> <83sf9f6wm0.fsf@gnu.org> <83sf9eub9d.fsf@gnu.org> <2d844a34-857d-3d59-b897-73372baac480@gutov.dev> <83bkg2tsu6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2072"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: luangruo@yahoo.com, sbaugh@janestreet.com, yantar92@posteo.net, 64735@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 23 19:59:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qNdMc-0000Ib-Kd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jul 2023 19:59:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNdMK-0002Ga-Qx; Sun, 23 Jul 2023 13:59:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNdME-0002C2-E9 for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 13:59:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qNdME-0000G0-5I for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 13:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qNdME-0002kr-1T for bug-gnu-emacs@gnu.org; Sun, 23 Jul 2023 13:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jul 2023 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.169013511710558 (code B ref 64735); Sun, 23 Jul 2023 17:59:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 23 Jul 2023 17:58:37 +0000 Original-Received: from localhost ([127.0.0.1]:41217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNdLo-0002kE-Ki for submit@debbugs.gnu.org; Sun, 23 Jul 2023 13:58:36 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:53169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qNdLm-0002k1-Fx for 64735@debbugs.gnu.org; Sun, 23 Jul 2023 13:58:35 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 90C7732002E8; Sun, 23 Jul 2023 13:58:28 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 23 Jul 2023 13:58:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690135108; x=1690221508; bh=yq5fEfKbuJB8fN1QdIXxmmOWKMAnPKDk3xx 91X4qLt8=; b=buaEjVLROhPLwUFElEehba9yNmMWUo/wtSepVFOEctGBi4OOm4l lxu/0Tmzh6byGD4cZmjCdpmT4wlepWrtuAhjGpRpce3Tv6cdqfIdHcZslAdJvA2l FoF6dDqAwytxLDGyAYz/sJ5FDhgi4HGFto+7lyw7g5DGfeCP2o6IWgthOgvCmUhv tG6VDH4ZpfF2HHdbQiHcm0tYk0uJcBSaducl5JEagtNRAvqYFhQxGtuVFdWiTHsO jWc+5hiu+Q3K35rKLjIxEtrTEQEya3SKci1xJdVXCk8p5k78g/NT6tAveHBrnEQI hXcoczgC+mLVruB3STwDX0N4aLkYeu+FW/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690135108; x=1690221508; bh=yq5fEfKbuJB8fN1QdIXxmmOWKMAnPKDk3xx 91X4qLt8=; b=PwngWDJTsSyuBzU+4mjnAaf7dxP+Epof66BOlUTmRnaShKvPaQd 5bm35qAQNOa4pFJr3YJc9c8cUwQDIuhj5lYWXGFuFU7/rm91BAe9i692rk9pJLzW Ayz1d7/1pdiBvBGdIVrZbv6MYwAKWPPdLOObLpdFG+d8rqgm9mMQXNDtlscO4uYb 4gVZ2U0bO2KASYoMy3SHwj53DGh+Uckkuvp/m79hJP6nl2y1JxfBvb9XKvDFv467 Uf4EbD9plnkdCetz1kuw1qzvgExNVTvJYkKeS5GHX7ClqoegKK3zaGgwrs6JIfa0 uLojRX4IHucoNe2WVxIoO6kkOcbZW5BLM3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrheeigdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Jul 2023 13:58:26 -0400 (EDT) Content-Language: en-US In-Reply-To: <83bkg2tsu6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265920 Archived-At: On 23/07/2023 20:56, Eli Zaretskii wrote: >> Date: Sun, 23 Jul 2023 20:46:19 +0300 >> Cc: luangruo@yahoo.com, sbaugh@janestreet.com, yantar92@posteo.net, >> 64735@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 23/07/2023 14:18, Eli Zaretskii wrote: >>>> Date: Sun, 23 Jul 2023 13:46:30 +0300 >>>> Cc:luangruo@yahoo.com,sbaugh@janestreet.com,yantar92@posteo.net, >>>> 64735@debbugs.gnu.org >>>> From: Dmitry Gutov >>>> >>>> On 23/07/2023 08:11, Eli Zaretskii wrote: >>>>> Even better: compute completion-regexp-list so that IGNOREs are >>>>> filtered by file-name-all-completions in the first place. >>>> We don't have lookahead in Emacs regexps, so I'm not sure it's possible >>>> to construct regexp that says "don't match entries A, B and C". >>> Well, maybe just having a way of telling file-name-all-completions to >>> negate the sense of completion-regexp-list would be enough to make >>> that happen? >> >> Some way to do that is certainly possible (e.g. a new option and >> corresponding code, maybe; maybe not), it's just that the person >> implementing it should consider the performance of the resulting solution. > > I agree. However, if we are going to implement filtering of file > names, I don't think it matters where in the pipeline to perform the > filtering. A possible advantage of doing it earlier, is that if filtering happens in C code you could do it before allocating Lisp strings, thereby lowering the resulting GC pressure at the outset.