From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#42210: Add -other-window variants of project-prefix-map commands Date: Sun, 5 Jul 2020 11:35:39 -0700 (PDT) Message-ID: References: <87blkw5cd3.fsf@iris.silentflame.com> <87tuymh4k9.fsf@iris.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10294"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dgutov@yandex.ru, juri@linkov.net To: Sean Whitton , 42210@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 05 20:52:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1js9ko-0002Xx-83 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jul 2020 20:52:42 +0200 Original-Received: from localhost ([::1]:44564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1js9kn-0006jh-9X for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jul 2020 14:52:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1js9Wd-0002UT-2m for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 14:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1js9Wc-0007zZ-GD for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 14:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1js9Wc-0001zz-Em for bug-gnu-emacs@gnu.org; Sun, 05 Jul 2020 14:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jul 2020 18:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42210 X-GNU-PR-Package: emacs Original-Received: via spool by 42210-submit@debbugs.gnu.org id=B42210.15939742787673 (code B ref 42210); Sun, 05 Jul 2020 18:38:02 +0000 Original-Received: (at 42210) by debbugs.gnu.org; 5 Jul 2020 18:37:58 +0000 Original-Received: from localhost ([127.0.0.1]:33017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1js9WY-0001zg-HM for submit@debbugs.gnu.org; Sun, 05 Jul 2020 14:37:58 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:52730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1js9WV-0001zR-Ub for 42210@debbugs.gnu.org; Sun, 05 Jul 2020 14:37:56 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 065IauuF172253; Sun, 5 Jul 2020 18:37:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=ji8qEqlIWjiUNtmrtexzidAbdX78hghsu4kvXGubIKc=; b=vPNC/0CQMSY3ZkPBiWQUiBek4mjw07Py3ALt9+j3+CC7sYrrPd+zBg4cAS38ipX8xtA5 eOjf2+vTqipkDGXfh4EJ6o0hIAycDW4Ltp1AnKOwY2caZGB/G1/ptMJLDyLoEFTM0eLh TQSRmD1+g2G7BdKkR0bi34LhGVFFfRfnm1KShReYl6wAGlBkPd4FaJCwsYP0l+LX5eQP 2jI62n3Gu8i3iSJHHM2zGA6nhO2bVo2pYDUddIGyL7qMaWQmh1qENhbr9omC6GGyG79y ItMbCpy23osqsS+xhd3iv9+xhx5CKMifWjeZ/Nsprt8hpm9vBuMLrwGPtFSa5eIu0tJu AA== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 322kv633sf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 05 Jul 2020 18:37:48 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 065IJ0NZ141214; Sun, 5 Jul 2020 18:35:48 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 3233nwycv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 05 Jul 2020 18:35:48 +0000 Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 065IZevg012631; Sun, 5 Jul 2020 18:35:41 GMT In-Reply-To: <87tuymh4k9.fsf@iris.silentflame.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5017.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9673 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007050141 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9673 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 phishscore=0 spamscore=0 priorityscore=1501 clxscore=1011 impostorscore=0 mlxscore=0 adultscore=0 cotscore=-2147483648 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2007050142 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182750 Archived-At: 1. I disagree with calling the macro `define-other-window-command'. My disagreement is this: Defining an other-window command should do just that. It should not define a command that only "prefers" to display in another window. It should define a command that actually displays in another window. And your doc string in fact says the latter, though the behavior is, I guess, only the former. Please consider renaming the macro and fixing the doc string, to make clear that it's NOT other-window but only maybe-other-window. 2. Why "resultant buffer". What does the buffer result from? It's about whatever FUNCTION displays, no? 3. Presumably FUNCTION must be a _command_. If so, the arg should be called COMMAND, and the doc adjusted accordingly. #2 and #3 are minor. I'm more concerned about #1. Emacs has many commands that are _really_ other-window. They generally use `pop-to-buffer' or `switch-to-buffer-other-window'. If this macro produces commands that only "prefer" to use another window, then the name and doc string are false advertising. 4. Why not have a macro that _really_ provides an other-window command?