From: Drew Adams <drew.adams@oracle.com>
To: Sean Whitton <spwhitton@spwhitton.name>, 42210@debbugs.gnu.org
Cc: dgutov@yandex.ru, juri@linkov.net
Subject: bug#42210: Add -other-window variants of project-prefix-map commands
Date: Sun, 5 Jul 2020 11:35:39 -0700 (PDT) [thread overview]
Message-ID: <e29d529e-d26b-43a6-99e3-dd8bba15ee3b@default> (raw)
In-Reply-To: <87tuymh4k9.fsf@iris.silentflame.com>
1. I disagree with calling the macro `define-other-window-command'.
My disagreement is this: Defining an other-window command
should do just that. It should not define a command that
only "prefers" to display in another window. It should
define a command that actually displays in another window.
And your doc string in fact says the latter, though the
behavior is, I guess, only the former. Please consider
renaming the macro and fixing the doc string, to make clear
that it's NOT other-window but only maybe-other-window.
2. Why "resultant buffer". What does the buffer result
from? It's about whatever FUNCTION displays, no?
3. Presumably FUNCTION must be a _command_. If so,
the arg should be called COMMAND, and the doc adjusted
accordingly.
#2 and #3 are minor. I'm more concerned about #1.
Emacs has many commands that are _really_ other-window.
They generally use `pop-to-buffer' or
`switch-to-buffer-other-window'.
If this macro produces commands that only "prefer" to
use another window, then the name and doc string are
false advertising.
4. Why not have a macro that _really_ provides an
other-window command?
next prev parent reply other threads:[~2020-07-05 18:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 0:54 Add -other-{window,frame} variants of project-prefix-map commands Sean Whitton
2020-07-04 5:34 ` Add -other-{window, frame} " Stephen Leake
2020-07-04 23:24 ` Sean Whitton
2020-07-06 0:58 ` Stephen Leake
2020-07-06 0:23 ` Juri Linkov
2020-07-06 3:31 ` Stefan Monnier
2020-07-06 22:57 ` Juri Linkov
2020-07-06 23:27 ` Drew Adams
2020-07-06 23:35 ` Stefan Monnier
2020-07-07 23:52 ` Juri Linkov
2020-07-08 4:06 ` Stefan Monnier
2020-07-09 0:24 ` Juri Linkov
2020-07-09 23:58 ` Juri Linkov
2020-07-05 6:13 ` bug#42210: Add -other-window " Sean Whitton
2020-07-05 14:41 ` Eli Zaretskii
2020-07-05 18:35 ` Drew Adams [this message]
2020-07-05 20:25 ` Sean Whitton
2020-07-06 0:00 ` Drew Adams
2020-07-06 0:19 ` Juri Linkov
2020-07-06 1:58 ` Sean Whitton
2020-07-06 22:59 ` Juri Linkov
2020-07-08 6:27 ` Sean Whitton
2020-07-09 0:10 ` Juri Linkov
2020-07-11 17:09 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e29d529e-d26b-43a6-99e3-dd8bba15ee3b@default \
--to=drew.adams@oracle.com \
--cc=42210@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=juri@linkov.net \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.