From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20637: incompatible, undocumented change to vc-working-revision Date: Sat, 9 Apr 2016 23:42:50 +0300 Message-ID: References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1460234596 13453 80.91.229.3 (9 Apr 2016 20:43:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Apr 2016 20:43:16 +0000 (UTC) Cc: 20637@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 09 22:43:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aozis-0003qw-OZ for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 22:43:14 +0200 Original-Received: from localhost ([::1]:33012 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aozis-000856-2V for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 16:43:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aozik-0007z2-L3 for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 16:43:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aozig-0000Tb-K3 for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 16:43:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aozig-0000TX-GN for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 16:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aozig-0007WJ-9P for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 16:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Apr 2016 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20637 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20637-submit@debbugs.gnu.org id=B20637.146023458128900 (code B ref 20637); Sat, 09 Apr 2016 20:43:02 +0000 Original-Received: (at 20637) by debbugs.gnu.org; 9 Apr 2016 20:43:01 +0000 Original-Received: from localhost ([127.0.0.1]:56418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aozie-0007W4-SJ for submit@debbugs.gnu.org; Sat, 09 Apr 2016 16:43:01 -0400 Original-Received: from mail-wm0-f45.google.com ([74.125.82.45]:38294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aozid-0007Vs-VP for 20637@debbugs.gnu.org; Sat, 09 Apr 2016 16:43:00 -0400 Original-Received: by mail-wm0-f45.google.com with SMTP id u206so59241672wme.1 for <20637@debbugs.gnu.org>; Sat, 09 Apr 2016 13:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=6k15NO3kapr1Wb4P3eD7lCHyK46GH8VKQ8vkEdlMgm8=; b=xQiyWdVv2fNQlnZc7ZW6d5yIj6I6Y0jLHTBxlNM4pDLesZSD+ZaqcxUhAAAHz+30Cg /qyLVSacGjPgC6FWhE3D+CCnYGzY2qwAT4Jem/RGpSKAGBXsWpL/UyZI5OI9iWaPE3wc Z6aVxja0M/FvY2OHlhLBjdgnZbNMZnLMzljGPjc8blCfFhCqzfW/T2/ouRKRMen2n+nm FJOZUbJOJkaAusn+BAlyC6Bmj/EWA6yuxl/h/6qngz8NzGz1ZbVpoO5aCPtSIM0XQ37U 5PGGCEQ/28mH9/+ob9W2dKxjbT305xqlt00ZfdPFQwuzSoVH12+Fq5ACUXvQnszlPHhU B43Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=6k15NO3kapr1Wb4P3eD7lCHyK46GH8VKQ8vkEdlMgm8=; b=fmlw4UE+JKhFixPpryBVpE8t21D0xVpqaxMzAfW7A019h4xT6sP12xXY8qTBW1mmt8 Q2d4nFy027W+QNjAaaj/ZsMHQMAemWXVE2zWI3fHYeuph2JIle4WFnWkpnaQQ7iBQs4P hMCQy6otN0H5C5oRr2wK9ni+OQcCO9GdRdKXvr2yCyimg5jaipxJDI6zNd7A5XD9ynNj wb0mY145TZAZ+LIP18fxxWj+crWa3/0BbohLPfJu1ALQFXTxd7EuUL/TnUyPly/ovc8M e9IOBGA4J15qWlO264jehE+wsdRwlWWLNwRvGHYxRVA66+G6zmdA0JksIz8RwuUuCYLA q/vQ== X-Gm-Message-State: AD7BkJIoKYt/rODJELr14ikOo5SzB05QSgaM6F3ytIsOwcUFPp5y+fDaCqDHVH4Gn9ycpw== X-Received: by 10.28.135.204 with SMTP id j195mr9890285wmd.65.1460234574316; Sat, 09 Apr 2016 13:42:54 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id e190sm9251979wma.15.2016.04.09.13.42.52 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 09 Apr 2016 13:42:53 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: <874mbawp84.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116290 Archived-At: Hi Michael, On 04/09/2016 10:34 PM, Michael Albinus wrote: > you have written several things I would like to move for later > discussion. I believe, we shall start again from the basics. OK, but the questions seem tangential to this bug report, which is a blocker for 25.1 (whereas investigating how various commands should work, isn't). > I have extended vc-test-*01-register tests by calls to vc-backend and > vc-responsible-backend. Mainly in order to understand how they work, but > also for covering these functions. One problem I've found is that > vc-file-*prop functions do not work well for relative file names; I've > fixed this. The change looks good, but nevertheless seeing the commit 5e1c32e in master makes me worried about conflicts when merging the necessary future fix for this bug from emacs-25 to master. > Several problems I have marked with FIXME in the working horse of those > tests, vc-test--register: > > - For some backends (CVS, RCS and SVN), vc-backend returns the backend > name for the newly created repo directory, and the directory is > registered already. For the other backends, vc-backend returns nil as > expected. Shouldn't this be consistent for all backends? I'm not quite clear on what you are saying here. If you're calling vc-backend on a directory, I believe the result is undefined. As in, the function is allowed to return any value. Maybe we could check file-directory-p in vc-backend, and signal an error if it is. For directories, one has to call vc-responsible-backend. > - vc-backend accepts also a list of files, vc-responsible-backend > doesn't. Is this right? I suppose. The function signatures say so. But I don't see any callers of vc-backend that actually pass a list to it. > - There is no common function vc-unregister, just some backend specific > vc--unregister. Those are the implementations of the `unregister' backend command. It's only used in vc-transfer-file currently. > Shouldn't vc-unregister exist? Maybe it should. Would you ever use it interactively? > It should call > common code, like vc-file-clearprops. For the time being, I have > emulated this. Are you doing that just to test the `unregister' implementations? Because otherwise, to clean up after a test, you can simply delete the directory with the test repository.