libpng issues

libpng issues

[Werner LEMBERG]

I've just been bitten by

  https://github.com/glennrp/libpng/issues/206

For this reason I suggest two improvements for the configure script of
emacs.

(1) Use `pkg-config' before `libpng-config' to detect libpng.

(2) If `libpng-config' is used, filter out `-L/usr/lib' and
    `-L/usr/lib64' (as suggested in issue #206).


    Werner

Re: libpng issues

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Werner LEMBERG wrote:
> 
> I've just been bitten by
> 
>    https://github.com/glennrp/libpng/issues/206
> 
> For this reason I suggest two improvements for the configure script of
> emacs.
> 
> (1) Use `pkg-config' before `libpng-config' to detect libpng.
> 
> (2) If `libpng-config' is used, filter out `-L/usr/lib' and
>      `-L/usr/lib64' (as suggested in issue #206).

Thanks, I installed the attached into master. It does (1), and as I understand 
it when (1) works then (2) is unnecessary. I'm hoping we don't have to do (2) as 
I worry that it might break things on some platforms.

[-- Attachment #2: 0001-Work-even-if-libpng-is-installed-in-usr-local.patch --]
[-- Type: text/x-patch, Size: 1353 bytes --]

From 43040127a56b529beac1e2958d0751f4c94e01fc Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 11 Feb 2018 18:43:34 -0800
Subject: [PATCH] Work even if libpng is installed in /usr/local

Problem reported by Werner Lemberg in:
https://lists.gnu.org/r/emacs-devel/2018-02/msg00304.html
* configure.ac: Try pkg-config before libpng-config.
---
 configure.ac | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index f2a8332..ec25e9b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3612,7 +3612,11 @@ AC_DEFUN
   if test "$opsys" = mingw32; then
     AC_CHECK_HEADER([png.h], [HAVE_PNG=yes])
   elif test "${HAVE_X11}" = "yes" || test "${HAVE_W32}" = "yes"; then
-    AC_MSG_CHECKING([for png])
+   EMACS_CHECK_MODULES([PNG], [libpng >= 1.0.0])
+   if test $HAVE_PNG = no; then
+    # Test old way in case pkg-config doesn't have it (older machines).
+    AC_MSG_CHECKING([for libpng not configured by pkg-config])
+
     png_cflags=`(libpng-config --cflags) 2>&AS_MESSAGE_LOG_FD` &&
     png_ldflags=`(libpng-config --ldflags) 2>&AS_MESSAGE_LOG_FD` || {
       # libpng-config does not work; configure by hand.
@@ -3645,6 +3649,7 @@ AC_DEFUN
     CFLAGS=$SAVE_CFLAGS
     LIBS=$SAVE_LIBS
     AC_MSG_RESULT([$HAVE_PNG])
+   fi
   fi
 fi
 if test $HAVE_PNG = yes; then
-- 
2.7.4

Re: libpng issues

[Elias Mårtenson]

[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]

Hello Paul,

Your fix for this (e9ca57cfcbaf1a8dfc6bde5a2afd5f3c7b357cb1) causes the
build to fail on Arch Linux.
Rolling back that change makes the build work again.

Here's the error:

make[2]: Leaving directory '/home/emartenson/src/emacs/admin/charsets'
make -C ../admin/unidata charscript.el
make[2]: Entering directory '/home/emartenson/src/emacs/admin/unidata'
make[2]: Nothing to be done for 'charscript.el'.
make[2]: Leaving directory '/home/emartenson/src/emacs/admin/unidata'
  CCLD     temacs
/bin/ld: image.o: undefined reference to symbol 'png_longjmp@@PNG16_0'
/usr/lib/libpng16.so.16: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:606: temacs] Error 1
make[1]: Leaving directory '/home/emartenson/src/emacs/src'
make: *** [Makefile:418: src] Error 2

Regards,
Elias


On 12 February 2018 at 10:45, Paul Eggert <eggert@cs.ucla.edu> wrote:

> Werner LEMBERG wrote:
>
>>
>> I've just been bitten by
>>
>>    https://github.com/glennrp/libpng/issues/206
>>
>> For this reason I suggest two improvements for the configure script of
>> emacs.
>>
>> (1) Use `pkg-config' before `libpng-config' to detect libpng.
>>
>> (2) If `libpng-config' is used, filter out `-L/usr/lib' and
>>      `-L/usr/lib64' (as suggested in issue #206).
>>
>
> Thanks, I installed the attached into master. It does (1), and as I
> understand it when (1) works then (2) is unnecessary. I'm hoping we don't
> have to do (2) as I worry that it might break things on some platforms.
>

[-- Attachment #2: Type: text/html, Size: 2442 bytes --]

Re: libpng issues

[Paul Eggert]

Elias Mårtenson wrote:
>    CCLD     temacs
> /bin/ld: image.o: undefined reference to symbol 'png_longjmp@@PNG16_0'
> /usr/lib/libpng16.so.16: error adding symbols: DSO missing from command line

Thanks for the heads-up. What is the last command to fail when you run 'make V=1'?

Also, in src/Makefile, what are the values of PNG_CFLAGS, and of LIBIMAGE?

Also, what is the output of the following shell commands? (The session below 
shows the output on Fedora 27.) Is the output correct for Arch Linux?

$ pkg-config --cflags libpng
-I/usr/include/libpng16
$ pkg-config --libs libpng
-lpng16 -lz
$ libpng-config --cflags
-I/usr/include/libpng16
$ libpng-config --ldflags
-L/usr/lib64 -lpng16

Re: libpng issues

[Elias Mårtenson]

[-- Attachment #1: Type: text/plain, Size: 10531 bytes --]

Here is the output from the commands you mentioned:

$ pkg-config --cflags libpng
-I/usr/include/libpng16
$ pkg-config --libs libpng
-lpng16 -lz
$ libpng-config --cflags
-I/usr/include/libpng16
$ libpng-config --ldflags
-L/usr/lib -lpng16

Here's the output from "make V=1":

$ make V=1
make -C lib all
make[1]: Entering directory '/home/emartenson/src/emacs/lib'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/emartenson/src/emacs/lib'
make -C lib-src all
make[1]: Entering directory '/home/emartenson/src/emacs/lib-src'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/emartenson/src/emacs/lib-src'
make -C src VCSWITNESS='$(srcdir)/../.git/logs/HEAD' all
make[1]: Entering directory '/home/emartenson/src/emacs/src'
make -C ../admin/charsets all
make[2]: Entering directory '/home/emartenson/src/emacs/admin/charsets'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/emartenson/src/emacs/admin/charsets'
make -C ../admin/unidata charscript.el
make[2]: Entering directory '/home/emartenson/src/emacs/admin/unidata'
make[2]: Nothing to be done for 'charscript.el'.
make[2]: Leaving directory '/home/emartenson/src/emacs/admin/unidata'
gcc -Demacs  -I. -I. -I../lib -I../lib   -pthread -isystem
/usr/include/gtk-3.0 -isystem /usr/include/at-spi2-atk/2.0 -isystem
/usr/include/at-spi-2.0 -isystem /usr/include/dbus-1.0 -isystem
/usr/lib/dbus-1.0/include -isystem /usr/include/gtk-3.0 -isystem
/usr/include/gio-unix-2.0/ -isystem /usr/include/cairo -isystem
/usr/include/pango-1.0 -isystem /usr/include/atk-1.0 -isystem
/usr/include/cairo -isystem /usr/include/pixman-1 -isystem
/usr/include/freetype2 -isystem /usr/include/libpng16 -isystem
/usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -isystem /usr/include/freetype2 -isystem
/usr/include/harfbuzz -isystem /usr/include/libpng16 -isystem
/usr/include/gdk-pixbuf-2.0 -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -isystem /usr/include/freetype2 -isystem
/usr/include/libpng16 -isystem /usr/include/harfbuzz -isystem
/usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem
/usr/include/freetype2 -isystem /usr/include/libpng16 -isystem
/usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include  -isystem /usr/include/alsa -pthread -isystem
/usr/include/librsvg-2.0 -isystem /usr/include/gdk-pixbuf-2.0 -isystem
/usr/include/cairo -isystem /usr/include/pixman-1 -isystem
/usr/include/freetype2 -isystem /usr/include/libpng16 -isystem
/usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -isystem /usr/include/freetype2 -isystem
/usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -isystem /usr/include/libpng16  -isystem
/usr/include/libpng16 -isystem /usr/include/libxml2 -isystem
/usr/include/dbus-1.0 -isystem /usr/lib/dbus-1.0/include     -pthread
-isystem /usr/include/webkitgtk-4.0 -isystem /usr/include/gtk-3.0 -isystem
/usr/include/at-spi2-atk/2.0 -isystem /usr/include/at-spi-2.0 -isystem
/usr/include/dbus-1.0 -isystem /usr/lib/dbus-1.0/include -isystem
/usr/include/gtk-3.0 -isystem /usr/include/gio-unix-2.0/ -isystem
/usr/include/cairo -isystem /usr/include/pango-1.0 -isystem
/usr/include/atk-1.0 -isystem /usr/include/cairo -isystem
/usr/include/pixman-1 -isystem /usr/include/freetype2 -isystem
/usr/include/libpng16 -isystem /usr/include/harfbuzz -isystem
/usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem
/usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem
/usr/include/libpng16 -isystem /usr/include/gdk-pixbuf-2.0 -isystem
/usr/include/libsoup-2.4 -isystem /usr/include/libxml2 -isystem
/usr/include/webkitgtk-4.0 -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -pthread -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -isystem /usr/include/freetype2 -isystem
/usr/include/libpng16 -isystem /usr/include/harfbuzz -isystem
/usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem
/usr/include/freetype2 -isystem /usr/include/libpng16 -isystem
/usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -isystem /usr/include/freetype2 -isystem
/usr/include/libpng16 -isystem /usr/include/harfbuzz -isystem
/usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem
/usr/include/freetype2 -isystem /usr/include/libpng16 -isystem
/usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem
/usr/lib/glib-2.0/include -isystem /usr/include/freetype2 -isystem
/usr/include/libpng16 -isystem /usr/include/harfbuzz -isystem
/usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include  -MMD -MF deps/.d
-MP   -isystem /usr/include/p11-kit-1    -fno-common -W -Wabi -Waddress
-Waggressive-loop-optimizations -Wall -Wattributes -Wbool-compare
-Wbool-operation -Wbuiltin-declaration-mismatch -Wbuiltin-macro-redefined
-Wcast-align -Wchar-subscripts -Wchkp -Wclobbered -Wcomment -Wcomments
-Wcoverage-mismatch -Wcpp -Wdangling-else -Wdate-time -Wdeprecated
-Wdeprecated-declarations -Wdesignated-init -Wdisabled-optimization
-Wdiscarded-array-qualifiers -Wdiscarded-qualifiers -Wdiv-by-zero
-Wdouble-promotion -Wduplicated-cond -Wduplicate-decl-specifier
-Wempty-body -Wendif-labels -Wenum-compare -Wexpansion-to-defined -Wextra
-Wformat-contains-nul -Wformat-extra-args -Wformat-security
-Wformat-signedness -Wformat-y2k -Wformat-zero-length -Wframe-address
-Wfree-nonheap-object -Whsa -Wignored-attributes -Wignored-qualifiers
-Wimplicit -Wimplicit-function-declaration -Wimplicit-int
-Wincompatible-pointer-types -Winit-self -Wint-conversion
-Wint-in-bool-context -Wint-to-pointer-cast -Winvalid-memory-model
-Winvalid-pch -Wjump-misses-init -Wlogical-not-parentheses -Wlogical-op
-Wmain -Wmaybe-uninitialized -Wmemset-elt-size -Wmemset-transposed-args
-Wmisleading-indentation -Wmissing-braces -Wmissing-declarations
-Wmissing-include-dirs -Wmissing-parameter-type -Wmissing-prototypes
-Wmultichar -Wnarrowing -Wnested-externs -Wnonnull -Wnonnull-compare
-Wnull-dereference -Wodr -Wold-style-declaration -Wold-style-definition
-Wopenmp-simd -Woverflow -Wpacked -Wpacked-bitfield-compat -Wparentheses
-Wpointer-arith -Wpointer-compare -Wpointer-sign -Wpointer-to-int-cast
-Wpragmas -Wpsabi -Wrestrict -Wreturn-local-addr -Wreturn-type
-Wscalar-storage-order -Wsequence-point -Wshift-count-negative
-Wshift-count-overflow -Wshift-negative-value -Wsizeof-array-argument
-Wsizeof-pointer-memaccess -Wstrict-aliasing -Wstrict-prototypes
-Wsuggest-attribute=format -Wsuggest-attribute=noreturn
-Wsuggest-final-methods -Wsuggest-final-types -Wswitch-bool
-Wswitch-unreachable -Wtautological-compare -Wtrampolines -Wtrigraphs
-Wuninitialized -Wunknown-pragmas -Wunused -Wunused-but-set-parameter
-Wunused-but-set-variable -Wunused-function -Wunused-label
-Wunused-local-typedefs -Wunused-macros -Wunused-result -Wunused-value
-Wunused-variable -Wvarargs -Wvariadic-macros
-Wvector-operation-performance -Wvolatile-register-var -Wwrite-strings
-Walloc-size-larger-than=9223372036854775807 -Warray-bounds=2
-Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wnormalized=nfc
-Wshift-overflow=2 -Wstringop-overflow=2 -Wvla-larger-than=4031
-Wredundant-decls -Wno-missing-field-initializers -Wno-override-init
-Wno-sign-compare -Wno-type-limits -Wno-unused-parameter
-Wno-format-nonliteral -g3 -O2  -Wl,-znocombreloc  -no-pie  \
  -o temacs   dispnew.o frame.o scroll.o xdisp.o menu.o xmenu.o window.o
charset.o coding.o category.o ccl.o character.o chartab.o bidi.o cm.o
term.o terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o xsmfns.o
xsettings.o gtkutil.o emacsgtkfixed.o dbusbind.o emacs.o keyboard.o
macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o
fileio.o dired.o cmds.o casetab.o casefiddle.o indent.o search.o regex.o
undo.o alloc.o data.o doc.o editfns.o callint.o eval.o floatfns.o fns.o
font.o print.o lread.o dynlib.o emacs-module.o syntax.o unexelf.o
bytecode.o process.o gnutls.o callproc.o region-cache.o sound.o atimer.o
doprnt.o intervals.o textprop.o composite.o xml.o lcms.o inotify.o
xwidget.o profiler.o decompress.o thread.o systhread.o sheap.o     xfont.o
ftfont.o xftfont.o ftxfont.o  fontset.o fringe.o image.o xgselect.o json.o
terminfo.o lastfile.o gmalloc.o     ../lib/libegnu.a       -ltiff -ljpeg
-lgif -lXpm -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0
-lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
-lXcomposite -lSM -lICE -lX11 -lX11-xcb -lxcb -lXrender -lXft -lasound
-lrsvg-2 -lm -lgio-2.0 -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0 -lcairo
-lacl  -lwebkit2gtk-4.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0
-latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lsoup-2.4 -lgio-2.0
-lgobject-2.0 -ljavascriptcoregtk-4.0 -lglib-2.0   -lrt -ldbus-1  -lXrandr
-lXinerama -lXfixes -lXext -lxml2 -lgpm   -ltinfo  -lgio-2.0 -lgobject-2.0
-lglib-2.0 -lgobject-2.0 -lglib-2.0  -lfreetype -lfontconfig -lfreetype
-lfreetype -lotf -lfreetype -lm17n-core -lm17n-flt -lm17n-core -lgnutls
-lpthread -lanl -llcms2  -lm -lz -ldl -lsystemd -ljansson
/bin/ld: image.o: undefined reference to symbol 'png_longjmp@@PNG16_0'
/usr/lib/libpng16.so.16: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:606: temacs] Error 1
make[1]: Leaving directory '/home/emartenson/src/emacs/src'
make: *** [Makefile:418: src] Error 2


On 12 February 2018 at 15:49, Paul Eggert <eggert@cs.ucla.edu> wrote:

> Elias Mårtenson wrote:
>
>>    CCLD     temacs
>> /bin/ld: image.o: undefined reference to symbol 'png_longjmp@@PNG16_0'
>> /usr/lib/libpng16.so.16: error adding symbols: DSO missing from command
>> line
>>
>
> Thanks for the heads-up. What is the last command to fail when you run
> 'make V=1'?
>
> Also, in src/Makefile, what are the values of PNG_CFLAGS, and of LIBIMAGE?
>
> Also, what is the output of the following shell commands? (The session
> below shows the output on Fedora 27.) Is the output correct for Arch Linux?
>
> $ pkg-config --cflags libpng
> -I/usr/include/libpng16
> $ pkg-config --libs libpng
> -lpng16 -lz
> $ libpng-config --cflags
> -I/usr/include/libpng16
> $ libpng-config --ldflags
> -L/usr/lib64 -lpng16
>

[-- Attachment #2: Type: text/html, Size: 11468 bytes --]

Re: libpng issues

[jpff]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2184 bytes --]

I have the same problem on OpenSuSRE 42.3

/usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld: 
image.o: undefined reference to symbol 'png_set_sig_bytes@@PNG16_0'
/usr/lib64/libpng16.so.16: error adding symbols: DSO missing from command 
line
collect2: error: ld returned 1 exit status
Makefile:606: recipe for target 'temacs' failed
make[1]: *** [temacs] Error 1


On Mon, 12 Feb 2018, Elias Mårtenson wrote:

> Hello Paul,
> Your fix for this (e9ca57cfcbaf1a8dfc6bde5a2afd5f3c7b357cb1) causes the build
> to fail on Arch Linux.
> Rolling back that change makes the build work again.
> 
> Here's the error:
> 
> make[2]: Leaving directory '/home/emartenson/src/emacs/admin/charsets'
> make -C ../admin/unidata charscript.el
> make[2]: Entering directory '/home/emartenson/src/emacs/admin/unidata'
> make[2]: Nothing to be done for 'charscript.el'.
> make[2]: Leaving directory '/home/emartenson/src/emacs/admin/unidata'
>   CCLD     temacs
> /bin/ld: image.o: undefined reference to symbol 'png_longjmp@@PNG16_0'
> /usr/lib/libpng16.so.16: error adding symbols: DSO missing from command line
> collect2: error: ld returned 1 exit status
> make[1]: *** [Makefile:606: temacs] Error 1
> make[1]: Leaving directory '/home/emartenson/src/emacs/src'
> make: *** [Makefile:418: src] Error 2
> 
> Regards,
> Elias
> 
> 
> On 12 February 2018 at 10:45, Paul Eggert <eggert@cs.ucla.edu> wrote:
>       Werner LEMBERG wrote:
>
>             I've just been bitten by
>
>                https://github.com/glennrp/libpng/issues/206
>
>             For this reason I suggest two improvements for the
>             configure script of
>             emacs.
>
>             (1) Use `pkg-config' before `libpng-config' to detect
>             libpng.
>
>             (2) If `libpng-config' is used, filter out
>             `-L/usr/lib' and
>                  `-L/usr/lib64' (as suggested in issue #206).
> 
>
>       Thanks, I installed the attached into master. It does (1), and as
>       I understand it when (1) works then (2) is unnecessary. I'm hoping
>       we don't have to do (2) as I worry that it might break things on
>       some platforms.
> 
> 
> 
>

Re: libpng issues

[Paul Eggert]

Thanks for the heads-up. Clearly my attempt at supporting a hand-built system is 
more trouble than it's worth, since it breaks the build so often elsewhere, so 
I've reverted the patch. I'm not sure how to proceed, other than suggesting 
special flags for the hand-built approach.

Re: libpng issues

[Werner LEMBERG]

> Thanks for the heads-up.  Clearly my attempt at supporting a
> hand-built system is more trouble than it's worth, since it breaks
> the build so often elsewhere, so I've reverted the patch.  I'm not
> sure how to proceed, other than suggesting special flags for the
> hand-built approach.

Troubles with `hand-built systems' is just secondary.  As mentioned
before, Debian is going to drop support for `xxx-config' scripts soon.
Instead, it will fully rely on pkg-config.  Consequently, Emacs has
eventually switch to pkg-config for finding libpng, too.

Please don't stop investigating why the code fails.


    Werner