From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#50470: 27.1; 'company-mode' 'eshell' Date: Tue, 28 Mar 2023 03:41:51 +0300 Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10053"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley To: Jim Porter , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 28 02:42:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgxPt-0002VC-5c for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Mar 2023 02:42:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgxPZ-00059U-Bq; Mon, 27 Mar 2023 20:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgxPX-000595-Br for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 20:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgxPX-0005jJ-47 for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 20:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgxPW-0000ED-E4 for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 20:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2023 00:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50470 X-GNU-PR-Package: emacs Original-Received: via spool by 50470-submit@debbugs.gnu.org id=B50470.1679964121873 (code B ref 50470); Tue, 28 Mar 2023 00:42:02 +0000 Original-Received: (at 50470) by debbugs.gnu.org; 28 Mar 2023 00:42:01 +0000 Original-Received: from localhost ([127.0.0.1]:48600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgxPV-0000Dy-Fd for submit@debbugs.gnu.org; Mon, 27 Mar 2023 20:42:01 -0400 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:42525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgxPT-0000Dl-LH for 50470@debbugs.gnu.org; Mon, 27 Mar 2023 20:42:00 -0400 Original-Received: by mail-wm1-f52.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so6361581wms.1 for <50470@debbugs.gnu.org>; Mon, 27 Mar 2023 17:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679964114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=WlET1RecoDW2EdDAs/X4h5DZA/RU8J60paJGyKfCpuc=; b=SbeUWinySiZ9GIvnoWhR7qVzFKw4QaWninibIKr6EysIql/FY0At3cpwBiW86yCVpM f6cwH9BMqHirrSc6sCX+8ull/oJDZsYbpi4w7M/ZENqz19ixVoX1LV5v5Ke+VHpMpFZl wc4DYdA2FbdvlSoFZ0sX59RFEaAXzgH40U7pJqY9FrCvAihmSi44GNo68kciRzGvk7OS SxC61mMTzbwztbD1hLsXvO0QNGs9IU49DutK/YKYqGIonKRTJsJhVPfjeFbL82Ufnd3z Eqt4+fV+yj80mBBeO+Lw4k3V+67dIduhWFqiwHFoXz5a44byABDHeB+YlRwSwvl/+mvw 55Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679964114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WlET1RecoDW2EdDAs/X4h5DZA/RU8J60paJGyKfCpuc=; b=SsyMXNSWo7iWTIcaQoQ11uldDtcXJxA1UtuZSEwo5ESGhqU9HjC+UH6Dshmaijn3kH Y4s4HmFGgq24c0cPoHiPfaQw6uObBGlFFqpxk+eMxyD/p81O08z1p8HCMSX3/RLdcJHh czlXk01gd+of8Nw4jsKJocSH1ON94L7NdeMVDi7SUaMVVqoGvGT7kmJKFqG6Qr9LIMCE IuuNG4NI787OsTRTgHSPNcMcUQOrONhyWmJPQbqiHt+VH8B8Q+v8DV9BywmbXGDo32RC ZO5sLRbdUJ2NMeu4F7v/r+HJj/dY4+tJqBgn35NPFH23eyHawPObiRpS+I4bRPyIM4f4 byzA== X-Gm-Message-State: AO0yUKVnuo3OTW+eIIKTbRdzWmE+14REP6qOHoQeEt9zpE5p9XmWqr3x DwxWLXJY44i7hzJ09AwSapM= X-Google-Smtp-Source: AK7set8d8v0z/Sjisp9qqSOc679CXFp9HAW6yDFtQsOSFRaJroLLQz0sPGiyRdUnBOV5/7rhHAksUw== X-Received: by 2002:a05:600c:ac3:b0:3ed:af6b:7faa with SMTP id c3-20020a05600c0ac300b003edaf6b7faamr10386869wmr.17.1679964113431; Mon, 27 Mar 2023 17:41:53 -0700 (PDT) Original-Received: from [192.168.1.2] ([31.216.80.60]) by smtp.googlemail.com with ESMTPSA id s17-20020a7bc391000000b003ed2987690dsm15178355wmj.26.2023.03.27.17.41.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 17:41:52 -0700 (PDT) Content-Language: en-US In-Reply-To: <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258776 Archived-At: On 21/03/2023 04:30, Jim Porter wrote: > On 3/19/2023 6:34 PM, Stefan Monnier via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >> I definitely don't want to force preloading that module. >> But maybe that var could have a meaning that's independent >> from completion, thus justifying to move it out of the completion >> extension module? > > Well, luckily(?) it turns out my patch wasn't quite right anyway, so I > completely rewrote it. (In particular, it didn't correctly generate a > top-level stub if there was a subcommand nested somewhere *inside* an > argument.) > > With this change, we now have a more-general way of preventing commands > that can cause side effects: 'eshell-allow-commands'. We can let-bind > that to nil, and then any commands within an argument will signal an error. > > Then we just need to disable globbing via a different method (using the > patch I originally posted), and all is well for this bug. > > I also added a couple preliminary patches to fix some semi-related > issues I discovered while working on this. These could probably go in a > separate bug, but I'm lazy. 😉 The real meat of this change is patch 0003. Again, no proper review from me, but I've tried the patches. Completion looks good, just like with the previous one. But here's an error I encountered when trying to call a command with asterisks without expanding them with completion: $ ls ~/Documents/Sp* Wrong type argument: stringp, ("~/Documents/Spain/") This issue is present in master (without the patches applied), but not in emacs-29. The patch(es) fix a similar error in company-mode completion -- hopefully the straight evaluation could be fixed as easily.