From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#34781: 27.0.50; integer in pcase sometimes compared by eq Date: Thu, 28 Mar 2019 11:25:55 -0700 Organization: UCLA Computer Science Department Message-ID: References: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="33293"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 Cc: 34781@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 28 19:27:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9Zk8-0008WF-EE for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Mar 2019 19:27:12 +0100 Original-Received: from localhost ([127.0.0.1]:40329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9Zk7-0005zZ-D1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Mar 2019 14:27:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9Zk0-0005zF-Li for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 14:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h9Zjy-0004Q8-U3 for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 14:27:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49394) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h9Zjy-0004Np-6t for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 14:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h9Zjy-0007YE-0C for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2019 14:27:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <0def6336a8d4cc8a769e9320f0a37962ba64d1de.camel@acm.org> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Mar 2019 18:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34781-submit@debbugs.gnu.org id=B34781.155379756528953 (code B ref 34781); Thu, 28 Mar 2019 18:27:01 +0000 Original-Received: (at 34781) by debbugs.gnu.org; 28 Mar 2019 18:26:05 +0000 Original-Received: from localhost ([127.0.0.1]:34705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9Zj3-0007Wu-1I for submit@debbugs.gnu.org; Thu, 28 Mar 2019 14:26:05 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h9Zj0-0007WQ-Ka for 34781@debbugs.gnu.org; Thu, 28 Mar 2019 14:26:03 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 70092160A6F; Thu, 28 Mar 2019 11:25:56 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id gWLZY-8fHJTy; Thu, 28 Mar 2019 11:25:55 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B117D160F0B; Thu, 28 Mar 2019 11:25:55 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id I998OaF07hYd; Thu, 28 Mar 2019 11:25:55 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 95BE51608B8; Thu, 28 Mar 2019 11:25:55 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156890 Archived-At: > I can't find any similar problem elsewhere in the pcase code; singular bignum comparison was taken care of long ago. > Is the patch acceptable? Thanks, it looks good to me; please install into the master branch What happens if a source file that uses pcase is compiled on a 64-bit machine that has wide fixnums, and is then loaded and run on a 32-bit machine that has narrow fixnums? Will this pcase code still work? And if not, are there similar bugs elsewhere in the pcase code?