From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#24091: Problem caused by the fix for this bug Date: Fri, 27 Oct 2017 10:11:19 -0400 Message-ID: References: <24533f31-9fc2-b38e-aaeb-561616cdf77f@gmail.com> <136e1c0c-a33f-3edb-505b-c74a1ea0c6d0@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------053F9B585F4B5A2217AC5E92" X-Trace: blaine.gmane.org 1509113551 20641 195.159.176.226 (27 Oct 2017 14:12:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Oct 2017 14:12:31 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 Cc: 24091@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 27 16:12:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e85Mq-0003mL-1q for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Oct 2017 16:12:12 +0200 Original-Received: from localhost ([::1]:57492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e85Mu-0005Sc-9k for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Oct 2017 10:12:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e85Mk-0005RY-JT for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2017 10:12:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e85Mg-0007mo-BO for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2017 10:12:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e85Mg-0007mi-6S for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2017 10:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e85Mg-0001zK-21 for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2017 10:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Oct 2017 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24091 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed fixed Original-Received: via spool by 24091-submit@debbugs.gnu.org id=B24091.15091134927602 (code B ref 24091); Fri, 27 Oct 2017 14:12:01 +0000 Original-Received: (at 24091) by debbugs.gnu.org; 27 Oct 2017 14:11:32 +0000 Original-Received: from localhost ([127.0.0.1]:37469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e85MC-0001yX-4u for submit@debbugs.gnu.org; Fri, 27 Oct 2017 10:11:32 -0400 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:56638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e85M9-0001yJ-H0 for 24091@debbugs.gnu.org; Fri, 27 Oct 2017 10:11:30 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v9REBMSu029047; Fri, 27 Oct 2017 10:11:23 -0400 Original-Received: from [10.13.22.3] (65-112-130-194.dia.static.qwest.net [65.112.130.194]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v9REBKHg015584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 27 Oct 2017 10:11:21 -0400 In-Reply-To: Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139078 Archived-At: This is a multi-part message in MIME format. --------------053F9B585F4B5A2217AC5E92 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/26/2017 4:40 PM, Noam Postavsky wrote: > On Thu, Oct 26, 2017 at 2:12 PM, Ken Brown wrote: > >> The commit I cited was the first bad one (as determined by git bisect). The >> problem still exists in the current HEAD of the emacs-26 branch. > > Okay. I removed the code because my understanding of the comment was > that it was needed to prevent a hang during the busy wait for > visibility. Therefore, when I removed that busy wait, I thought that > poll_for_input_1 was no longer needed either. > > However, from what you say, it sounds like it's rather needed after > creating a frame, unrelated to the waiting per se. I don't really > understand what the code does, but I guess you could try putting the > poll_for_input_1 stuff back in either before, inside, or after the > x_wait_for_event at the end of x_make_frame_visible and see what > helps? Putting it before the x_wait_for_event fixes the problem. Patch attached. Eli, is it OK to push this to the release branch? Ken --------------053F9B585F4B5A2217AC5E92 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-startup-display-on-Cygwin.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-startup-display-on-Cygwin.patch" RnJvbSA5MTYwY2U5ZDU2MjIyZGViMTdhNWMzOTIyYjY2YTBlOGIyMTRmNzUxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGticm93bkBjb3JuZWxsLmVkdT4K RGF0ZTogRnJpLCAyNyBPY3QgMjAxNyAxMDowNDozMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hd IEZpeCBzdGFydHVwIGRpc3BsYXkgb24gQ3lnd2luCgoqIHNyYy94dGVybS5jICh4X21ha2Vf ZnJhbWVfdmlzaWJsZSk6IFJlc3RvcmUgY29kZSB0aGF0IGZvcmNlcwppbnB1dCB0byBiZSBy ZWFkIGlmIGlucHV0IHBvbGxpbmcgaXMgdXNlZC4gIFRoaXMgaXMgbmVlZGVkIG9uCkN5Z3dp bi4gIChCdWcjMjQwOTEpCi0tLQogc3JjL3h0ZXJtLmMgfCAxNyArKysrKysrKysrKysrKysr KwogMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMv eHRlcm0uYyBiL3NyYy94dGVybS5jCmluZGV4IGQ5MDY1NGIxMDEuLjkyMDY2ZTkyMjkgMTAw NjQ0Ci0tLSBhL3NyYy94dGVybS5jCisrKyBiL3NyYy94dGVybS5jCkBAIC0xMTUwNCw2ICsx MTUwNCwyMyBAQCB4X21ha2VfZnJhbWVfdmlzaWJsZSAoc3RydWN0IGZyYW1lICpmKQogCiAg ICAgLyogVHJ5IHRvIHdhaXQgZm9yIGEgTWFwTm90aWZ5IGV2ZW50ICh0aGF0IGlzIHdoYXQg dGVsbHMgdXMgd2hlbiBhCiAgICAgICAgZnJhbWUgYmVjb21lcyB2aXNpYmxlKS4gICovCisK KyAgICAvKiBUaGlzIGhhY2sgaXMgc3RpbGwgaW4gdXNlIGF0IGxlYXN0IGZvciBDeWd3aW4u ICBTZWUKKyAgICAgICBodHRwOi8vbGlzdHMuZ251Lm9yZy9hcmNoaXZlL2h0bWwvZW1hY3Mt ZGV2ZWwvMjAxMy0xMi9tc2cwMDM1MS5odG1sCisgICAgICAgYW5kIGh0dHBzOi8vZGViYnVn cy5nbnUub3JnL2NnaS9idWdyZXBvcnQuY2dpP2J1Zz0yNDA5MSMxMzEuCisgICAgICAgRmFr ZSBhbiBhbGFybSBzaWduYWwgdG8gbGV0IHRoZSBoYW5kbGVyIGtub3cgdGhhdCB0aGVyZSdz CisgICAgICAgc29tZXRoaW5nIHRvIGJlIHJlYWQuICAqLworICAgIGlmIChpbnB1dF9wb2xs aW5nX3VzZWQgKCkpCisgICAgICB7CisJLyogSXQgY291bGQgYmUgY29uZnVzaW5nIGlmIGEg cmVhbCBhbGFybSBhcnJpdmVzIHdoaWxlCisJICAgcHJvY2Vzc2luZyB0aGUgZmFrZSBvbmUu ICBUdXJuIGl0IG9mZiBhbmQgbGV0IHRoZQorCSAgIGhhbmRsZXIgcmVzZXQgaXQuICAqLwor CWludCBvbGRfcG9sbF9zdXBwcmVzc19jb3VudCA9IHBvbGxfc3VwcHJlc3NfY291bnQ7CisJ cG9sbF9zdXBwcmVzc19jb3VudCA9IDE7CisJcG9sbF9mb3JfaW5wdXRfMSAoKTsKKwlwb2xs X3N1cHByZXNzX2NvdW50ID0gb2xkX3BvbGxfc3VwcHJlc3NfY291bnQ7CisgICAgICB9CisK ICAgICB4X3dhaXRfZm9yX2V2ZW50IChmLCBNYXBOb3RpZnkpOwogICB9CiB9Ci0tIAoyLjE0 LjIKCg== --------------053F9B585F4B5A2217AC5E92--