From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master 3665735: Sort the items in 'mode-line-mode-menu' before displaying the menu Date: Thu, 24 Jun 2021 10:13:24 -0700 Message-ID: References: <83zgvfs04c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23522"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 24 19:14:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwSvh-0005uq-Ir for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 19:14:17 +0200 Original-Received: from localhost ([::1]:53392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwSvg-0000oD-6d for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 13:14:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwSuw-00007X-7j for emacs-devel@gnu.org; Thu, 24 Jun 2021 13:13:30 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:36564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lwSus-00034k-Lj; Thu, 24 Jun 2021 13:13:29 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id u2so3306287plf.3; Thu, 24 Jun 2021 10:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=AhF+w5I6auKRH4g2zbiE57IJ7o2oBFvhRidnfQ2lp2c=; b=JP62c2zMOa48NQ5Isjbtq0gyNHdS0FQMs4QHi7hZXeeuYfixM/rs0S74qrqemsAd+Z qQp2SnVgDK0/kKR7SnPPXqdaMq4NjpZr3sV/HJg7QEiSiK51Zb02avtTBlItZOjTbQ2A okIgZpoOvgBubtyMGNarTxIYUQWw6lR2Trrx7Nx+lskFnwMesNYY8Lzk/sKy1tTyxXN7 ON70fnvuM0K4ymNeSPKqFb8hUf61NBsxHyXckZJFja+rBwyw24zDKPEigi0AR+AjYaGC 84r1qOkjE1e//h6egv4TTTd5UTfR1JEB52/S0qOLnQk6NXBSCA3aACJK2ba/cP5mnrh8 zRNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AhF+w5I6auKRH4g2zbiE57IJ7o2oBFvhRidnfQ2lp2c=; b=MTAATyyX7CSwjGLVTZppIbKohii/2GTMiM/zhAMuFV7hjxfrGw0TK6PDX++52qxOQm nju3ceRYipWj0pOHNoge74SWHbeoQ9d1NjpshkOxkcRDBEWqM8y7uDlGIulTBq+CErCf GVhcSnlXnLNdw2YMos6/hd21MBRRR4aBnUESrQQdnPi9dOJC73O7Va+l9fLi36JBkGQO kR0DBo90xdgtaAIixwLRmViBw+xINZPZ5NZZwkwwZW0EcxEHgeB3yolv55zD3gfh4Y/9 haW5ZsutxDM+VtlL+F9XgeWfkPTyUnuzGEck/7mGF4dDCCFZ3pLU6Y0mMaITt7tsaEmF w70A== X-Gm-Message-State: AOAM533O400n6dEdUbW/jb59tx4J8ZxnZkSpc/G4aaIMGPzr5OQMfCwv 1ZGcb0W4RBvsECAmHjUScMy5TbTFNaI= X-Google-Smtp-Source: ABdhPJwS86SqSbGP/iyOjslc5abrkNZmUxpdEw94u2rbaZKzHZw3+iQ7CQPxRaqyo8cfuPK7BORMRA== X-Received: by 2002:a17:902:c611:b029:122:847c:66e9 with SMTP id r17-20020a170902c611b0290122847c66e9mr5208554plr.82.1624554803610; Thu, 24 Jun 2021 10:13:23 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id gg5sm8464177pjb.0.2021.06.24.10.13.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 10:13:23 -0700 (PDT) In-Reply-To: <83zgvfs04c.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271007 Archived-At: On 6/24/2021 9:22 AM, Eli Zaretskii wrote: >> (defvar mode-line-major-mode-keymap >> (let ((map (make-sparse-keymap))) >> (bindings--define-key map [mode-line down-mouse-1] >> `(menu-item "Menu Bar" ignore >> :filter ,(lambda (_) (mouse-menu-major-mode-map)))) >> (define-key map [mode-line mouse-2] 'describe-mode) >> - (define-key map [mode-line down-mouse-3] mode-line-mode-menu) >> + (bindings--define-key map [mode-line down-mouse-3] >> + `(menu-item "Menu Bar" ,mode-line-mode-menu >> + :filter bindings--sort-keymap)) >> map) "\ >> Keymap to display on major mode.") >> >> (defvar mode-line-minor-mode-keymap >> - (let ((map (make-sparse-keymap))) >> + (let ((map (make-sparse-keymap)) >> + (mode-menu-binding >> + `(menu-item "Menu Bar" ,mode-line-mode-menu >> + :filter bindings--sort-keymap))) >> (define-key map [mode-line down-mouse-1] 'mouse-minor-mode-menu) > > Why does this use "Menu Bar" as the first arg of menu-item? Just a paste-o, I'm afraid. They could probably be renamed to "Minor Modes", assuming I'm understanding how that string is used. - Jim