From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Excessive use of `eassert` Date: Mon, 22 Jan 2024 23:51:50 -0800 Organization: UCLA Computer Science Department Message-ID: References: <83jzo5x0q8.fsf@gnu.org> <83sf2tv029.fsf@gnu.org> <811d5f03-fad4-47e1-b3fd-2f45229a5ee1@cs.ucla.edu> <11f4f47c-2873-4268-9bfb-c844545f27a6@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28797"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 23 08:52:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSBaY-0007Gr-RE for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Jan 2024 08:52:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSBZe-0004qK-S3; Tue, 23 Jan 2024 02:51:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSBZc-0004qB-Gc for emacs-devel@gnu.org; Tue, 23 Jan 2024 02:51:56 -0500 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSBZa-0003hi-He; Tue, 23 Jan 2024 02:51:56 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A76A53C011BD4; Mon, 22 Jan 2024 23:51:51 -0800 (PST) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id G5qfT6a3V0Z6; Mon, 22 Jan 2024 23:51:51 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 42FEA3C011BD7; Mon, 22 Jan 2024 23:51:51 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 42FEA3C011BD7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1705996311; bh=jEm14MxSy196q7uaOFaEAP1N/23qnXomcT7VxKZXFyY=; h=Message-ID:Date:MIME-Version:To:From; b=OIDUk3TT9LTclBMemuBE/pol62l7qT3gmSG78mz6u8y5q9d3+s+6FM85Fa+0bveGO zYHknG6oaua36uhEXVSt6tb723PzUyTnwe0RuAoarO9G5cwRlxex3q00u9T3OCJKW0 yVaGVWXYWaXKMyyZHvolwKYXabSdvmjoK7gv7+fCghjq8rRhA6CQywFAYPej7fm38G 4Hv343jfZeKKWYu94ZFRDi/Dj4hcON7ohnd8K3p2OqjEcB4POYEhw5fMmBl86U8y+z WFPWLHU3JhYaUqN811JBag8rMPlGmkrcro4VYbY7BwwLwsHSzxYPNZA1w+VvrV+2sA 0d/psh3ZALOXg== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id OU0wMVt_aLzK; Mon, 22 Jan 2024 23:51:51 -0800 (PST) Original-Received: from [192.168.254.12] (unknown [47.148.192.211]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 1BA853C011BD4; Mon, 22 Jan 2024 23:51:51 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=131.179.128.66; envelope-from=eggert@cs.ucla.edu; helo=mail.cs.ucla.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315243 Archived-At: On 2024-01-22 06:37, Alan Mackenzie wrote: > In a regular build, symbols with > position are handled differently depending on the value of > symbols_with_pos_enabled. Or at least they were and they must be. Thus > in XBARE_SYMBOL, one MUST test s_w_p_e, regardless of whether the build > is a regular one or a debugging one. None of my recent patches changed XBARE_SYMBOL. If XBARE_SYMBOL should test something it isn't currently testing, then that is a bug that has been present for some time. However, I don't see a bug there. XBARE_SYMBOL should be used only on bare symbols, regardless of whether symbols_with_pos_enabled is set. Perhaps you meant to write XSYMBOL instead of XBARE_SYMBOL? If so, I'm still not following, and more explanation would be helpful. What call to XSYMBOL formerly would have an eassert failure when debugging, but now won't have that failure?