From: Paul Eggert <eggert@cs.ucla.edu>
To: Alan Mackenzie <acm@muc.de>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: Excessive use of `eassert`
Date: Mon, 22 Jan 2024 23:51:50 -0800 [thread overview]
Message-ID: <e0987379-dbcc-4fcd-bb9b-d01f3213f4de@cs.ucla.edu> (raw)
In-Reply-To: <Za59kFWdQDbLs2MU@ACM>
On 2024-01-22 06:37, Alan Mackenzie wrote:
> In a regular build, symbols with
> position are handled differently depending on the value of
> symbols_with_pos_enabled. Or at least they were and they must be. Thus
> in XBARE_SYMBOL, one MUST test s_w_p_e, regardless of whether the build
> is a regular one or a debugging one.
None of my recent patches changed XBARE_SYMBOL. If XBARE_SYMBOL should
test something it isn't currently testing, then that is a bug that has
been present for some time.
However, I don't see a bug there. XBARE_SYMBOL should be used only on
bare symbols, regardless of whether symbols_with_pos_enabled is set.
Perhaps you meant to write XSYMBOL instead of XBARE_SYMBOL? If so, I'm
still not following, and more explanation would be helpful. What call to
XSYMBOL formerly would have an eassert failure when debugging, but now
won't have that failure?
next prev parent reply other threads:[~2024-01-23 7:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 22:35 Excessive use of `eassert` Stefan Monnier
2024-01-19 7:04 ` Eli Zaretskii
2024-01-19 13:01 ` Stefan Monnier
2024-01-19 15:02 ` Eli Zaretskii
2024-01-19 15:50 ` Stefan Monnier
2024-01-19 16:23 ` Eli Zaretskii
2024-01-19 17:44 ` Stefan Monnier
2024-01-19 19:42 ` Alan Mackenzie
2024-01-19 19:56 ` Eli Zaretskii
2024-01-21 1:41 ` Paul Eggert
2024-01-21 9:57 ` Eli Zaretskii
2024-01-21 20:35 ` Paul Eggert
2024-01-21 10:59 ` Alan Mackenzie
2024-01-22 5:19 ` Paul Eggert
2024-01-22 13:07 ` Stefan Monnier
2024-01-22 14:37 ` Alan Mackenzie
2024-01-23 7:51 ` Paul Eggert [this message]
2024-01-23 11:42 ` Alan Mackenzie
2024-01-24 1:04 ` Paul Eggert
2024-01-24 15:09 ` Alan Mackenzie
2024-01-26 8:06 ` Paul Eggert
2024-01-21 15:54 ` Stefan Monnier
2024-01-22 4:12 ` Paul Eggert
2024-01-22 13:20 ` Stefan Monnier
2024-01-23 8:15 ` Paul Eggert
2024-01-23 17:11 ` Stefan Monnier
2024-01-24 7:45 ` Paul Eggert
2024-01-23 18:16 ` Eli Zaretskii
2024-01-23 19:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0987379-dbcc-4fcd-bb9b-d01f3213f4de@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.