From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19423: 25.0.50; incompatible change to `make-obsolete' - added 3rd arg should be optional Date: Sun, 21 Dec 2014 10:58:40 -0800 (PST) Message-ID: References: <867fxkdecx.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1419188374 25527 80.91.229.3 (21 Dec 2014 18:59:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Dec 2014 18:59:34 +0000 (UTC) Cc: 19423-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 21 19:59:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y2lit-0005T8-6Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Dec 2014 19:59:23 +0100 Original-Received: from localhost ([::1]:38085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2lis-0006k9-HI for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Dec 2014 13:59:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2lih-0006iu-Co for bug-gnu-emacs@gnu.org; Sun, 21 Dec 2014 13:59:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y2liY-0000XP-Lm for bug-gnu-emacs@gnu.org; Sun, 21 Dec 2014 13:59:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2liY-0000XK-IR for bug-gnu-emacs@gnu.org; Sun, 21 Dec 2014 13:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y2liY-0004p0-Ct for bug-gnu-emacs@gnu.org; Sun, 21 Dec 2014 13:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Dec 2014 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19423 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19423-done@debbugs.gnu.org id=D19423.141918832518507 (code D ref 19423); Sun, 21 Dec 2014 18:59:02 +0000 Original-Received: (at 19423-done) by debbugs.gnu.org; 21 Dec 2014 18:58:45 +0000 Original-Received: from localhost ([127.0.0.1]:54028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y2liH-0004oR-2e for submit@debbugs.gnu.org; Sun, 21 Dec 2014 13:58:45 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:19474) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y2liE-0004oG-GY for 19423-done@debbugs.gnu.org; Sun, 21 Dec 2014 13:58:43 -0500 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id sBLIwehv027405 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 21 Dec 2014 18:58:41 GMT Original-Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sBLIwcnm010811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sun, 21 Dec 2014 18:58:39 GMT Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id sBLIwcNd019078; Sun, 21 Dec 2014 18:58:38 GMT In-Reply-To: <867fxkdecx.fsf@yandex.ru> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97650 Archived-At: > > In Emacs 23 someone unwisely changed it to mandatory, an > > incompatible change that gratuitously breaks code that could > > be used with older Emacs releases. Pain for no real gain. >=20 > You should look at the code sometimes. You should look at the byte-compiler warning that the user sees. It tells her that only 2 args are present but 3 are *required*. > The change is very much compatible: `make-obsolete' can still be > called with only two arguments without error. The third one is only > mandatory in the advertised calling convention. See above. The byte-compiler tells you that it is mandatory. > Even if it wasn't, it would be too late to fix the "problem": it > wouldn't work in 23 and 24 anyway. No, but it would work for Emacs 25, and releases prior to 23. There is no good reason *not* to fix it, is there?