From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: Unwanted undo-boundary Date: Sun, 14 Feb 2010 01:30:21 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1266107453 8974 80.91.229.12 (14 Feb 2010 00:30:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Feb 2010 00:30:53 +0000 (UTC) Cc: Johan Andersson , Emacs-Devel devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 14 01:30:51 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NgSNu-0002nQ-CQ for ged-emacs-devel@m.gmane.org; Sun, 14 Feb 2010 01:30:50 +0100 Original-Received: from localhost ([127.0.0.1]:57589 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NgSNt-0004QI-Op for ged-emacs-devel@m.gmane.org; Sat, 13 Feb 2010 19:30:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NgSNo-0004Ok-Bm for emacs-devel@gnu.org; Sat, 13 Feb 2010 19:30:44 -0500 Original-Received: from [140.186.70.92] (port=59590 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NgSNn-0004Nr-2n for emacs-devel@gnu.org; Sat, 13 Feb 2010 19:30:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NgSNm-0005zb-Ev for emacs-devel@gnu.org; Sat, 13 Feb 2010 19:30:43 -0500 Original-Received: from fg-out-1718.google.com ([72.14.220.156]:61653) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NgSNm-0005zX-8m for emacs-devel@gnu.org; Sat, 13 Feb 2010 19:30:42 -0500 Original-Received: by fg-out-1718.google.com with SMTP id e21so187893fga.12 for ; Sat, 13 Feb 2010 16:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=nrA+CH5JeCmZaE7UlJa/PQ/G1DpWXtG3mZCAv7nCZB8=; b=D/+Glnwm9Lbw9pWO5vCrPs3VhXQPtBW2Y5CSwcEQQRnhhuIojU9xHgvU3qU1NEzoOZ YgBfNthhhdzVjTYBYCGWsyoHU759KRbJ+ykxHqWFpQoulTl3YHqYILHXzXvtNVDixhTw +Gj8pf+G4CSFa2hhFV9ni2Ep/or1ghpkxFlbk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=Li0AhqbTWibMXmtTAFdZ0yZgLAFkwATtduLQjbSFUaKRxS5cJPWc+XdkTzkKON2x9p 2o+ZU1UDibYjm3XIpk5zMGn0TGsZj8Qs3Qz5Lwa0AP9dC5GrDEMIPFUZ9r5mWMF0MaZa R64KZWQrgWVtqh+Em/mhlJLqU3EX8ezcbqRaM= Original-Received: by 10.239.162.129 with SMTP id l1mr344313hbd.151.1266107441092; Sat, 13 Feb 2010 16:30:41 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121107 Archived-At: On Sat, Feb 13, 2010 at 7:54 PM, Stefan Monnier wrote: >> I just got a bug report saying that a single indent-region in mumamo >> can't be undone with a single undo command. (This is with the latest >> nXhtml beta and I can confirm it with an Emacs from 2010-02-03.) > >> I assume this means that something is calling undo-boundary, but I >> can't find out what. There is nothing in nXhtml that does it. (Yes, >> one function does, but it is not involved here.) I tried to trace >> undo-boundary, but I get no hit. > >> Does anyone have a good idea for how to find out what is happening? Am >> I wrong assuming that undo-boundary have been called (implicitly or >> explicitly)? > > It's hard to tell without more info, but yes if more than a single undo > is needed, it's probably because of a call to undo-boundary, tho it > might come from the C code (which you wouldn't be able to trace from > Elisp, you'd need to put a breakpoint on Fundo_boundary from gdb). I have not done that (yet), but looking at the where Fundo_boundary is called I see that there is a check like this if (current_buffer !=3D last_undo_buffer) Fundo_boundary (); last_undo_buffer =3D current_buffer; in some places. In my case changes in two buffers are involved. (One is just to figure out the indentation.) I just did a fresh checkout and tried "gdb emacs" but got: .gdbinit:23: Error in sourced command file: No symbol table is loaded. Use the "file" command. Is this expected? For configure I have used (on w32): cmd /c configure --with-gcc --no-opt --cflags -Ic:/g/include --cflags -fno-crossjumping > Maybe if you look at the place where the undo stops, you'll get some > hint at the culprit, > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0Stefan >