From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#5354: Please replace font-lock-fontify-buffer with font-lock-fontify-region in js-mode Date: Mon, 11 Jan 2010 22:32:47 +0100 Message-ID: References: Reply-To: Lennart Borgman , 5354@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1263246568 14420 80.91.229.12 (11 Jan 2010 21:49:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Jan 2010 21:49:28 +0000 (UTC) Cc: 5354@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 11 22:49:20 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NUS8U-0000Zl-02 for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jan 2010 22:49:18 +0100 Original-Received: from localhost ([127.0.0.1]:52085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUS8U-0007X6-Hd for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jan 2010 16:49:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUS8P-0007Tc-9L for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 16:49:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUS8J-0007LJ-Ug for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 16:49:12 -0500 Original-Received: from [199.232.76.173] (port=53759 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUS8J-0007LB-P5 for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 16:49:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56349) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NUS8J-0005Qo-0y for bug-gnu-emacs@gnu.org; Mon, 11 Jan 2010 16:49:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NURti-0004ha-54; Mon, 11 Jan 2010 16:34:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: Lennart Borgman , 5354@debbugs.gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jan 2010 21:34:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5354 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5354-submit@debbugs.gnu.org id=B5354.126324559418048 (code B ref 5354); Mon, 11 Jan 2010 21:34:02 +0000 Original-Received: (at 5354) by debbugs.gnu.org; 11 Jan 2010 21:33:14 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NURsv-0004h3-PY for submit@debbugs.gnu.org; Mon, 11 Jan 2010 16:33:14 -0500 Original-Received: from mail-fx0-f226.google.com ([209.85.220.226]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NURsu-0004gx-9W for 5354@debbugs.gnu.org; Mon, 11 Jan 2010 16:33:13 -0500 Original-Received: by fxm26 with SMTP id 26so19578290fxm.39 for <5354@debbugs.gnu.org>; Mon, 11 Jan 2010 13:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=BqJbF6B3GmPYkLH2P+V4de29v1W7/Bqts8AfNMcawts=; b=GahmR32VfbYiXB/AgSkmZiXJsrCWdJv3Apidwnfq0ZDW4+waKC4kjkLIjxbRst0nyn 1HboINXeqWNcrnCGXmCz0zrRvhBNeSdEkNn4qCyyROIvekrf0Yy9YenHI+g7PAnBsk/T WjdlFxGrJyjlUsc7POrGSBvW6odL3sNV8H0ns= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=MakyPOYDVa/X+VVkg2XWUj5PehyFNonG75/eXaaSUcik76gKNls10E1Hy7YAPO2kew KwgKqe3uSRdeI/O8Xa8WSjz55psBApb12WEZSaVExoI/4kjTgZ+E0GmPLZXFNkxlunD2 DGryOAdGoKGPrd28YWAmaC26ffqrfNtBhrPQA= Original-Received: by 10.239.192.79 with SMTP id d15mr957759hbi.52.1263245587533; Mon, 11 Jan 2010 13:33:07 -0800 (PST) In-Reply-To: X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.7 (--) Resent-Date: Mon, 11 Jan 2010 16:34:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34205 Archived-At: On Mon, Jan 11, 2010 at 6:37 PM, Stefan Monnier wrote: >> In `js-mode' there is a call to `font-lock-fontify-buffer' at the end. >> This creates problem for mumamo since it fontifies outside the region >> where js-mode should be applied: > >> =C2=A0 (let (font-lock-keywords) ; leaves syntactic keywords intact >> =C2=A0 =C2=A0 (font-lock-fontify-buffer)) > >> Could this please be replaced by > >> =C2=A0 (let (font-lock-keywords ; leaves syntactic keywords intact >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 font-lock-extend-region-functions) ;; accept= narrowing >> =C2=A0 =C2=A0 (font-lock-fontify-region (point-min) (point-max))) > > This looks majorly odd (aka difficult to explain/justify from js-mode's > point of view). =C2=A0I suggest you instead submit a proposal for a new > font-lock function that does what js-mode needs. Thanks, you are right. Looking at it again I realize I can of course instead change font-lock-fontify-buffer-function in mumamo. So I did that. Please close this bug. Sorry for the trouble and thanks for the help.