all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 5354@debbugs.gnu.org
Subject: bug#5354: Please replace font-lock-fontify-buffer with font-lock-fontify-region in js-mode
Date: Mon, 11 Jan 2010 22:32:47 +0100	[thread overview]
Message-ID: <e01d8a51001111332y40203f00hee9a4840d3cb56a0@mail.gmail.com> (raw)
In-Reply-To: <jwveilwh7e7.fsf-monnier+emacs@gnu.org>

On Mon, Jan 11, 2010 at 6:37 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> In `js-mode' there is a call to `font-lock-fontify-buffer' at the end.
>> This creates problem for mumamo since it fontifies outside the region
>> where js-mode should be applied:
>
>>   (let (font-lock-keywords) ; leaves syntactic keywords intact
>>     (font-lock-fontify-buffer))
>
>> Could this please be replaced by
>
>>   (let (font-lock-keywords ; leaves syntactic keywords intact
>>         font-lock-extend-region-functions) ;; accept narrowing
>>     (font-lock-fontify-region (point-min) (point-max)))
>
> This looks majorly odd (aka difficult to explain/justify from js-mode's
> point of view).  I suggest you instead submit a proposal for a new
> font-lock function that does what js-mode needs.

Thanks, you are right. Looking at it again I realize I can of course
instead change font-lock-fontify-buffer-function in mumamo. So I did
that.

Please close this bug. Sorry for the trouble and thanks for the help.






      reply	other threads:[~2010-01-11 21:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11 16:42 bug#5354: Please replace font-lock-fontify-buffer with font-lock-fontify-region in js-mode Lennart Borgman
2010-01-11 17:37 ` Stefan Monnier
2010-01-11 21:32   ` Lennart Borgman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e01d8a51001111332y40203f00hee9a4840d3cb56a0@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=5354@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.