From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#5119: ruby-mode binds TAB Date: Fri, 4 Dec 2009 04:36:13 +0100 Message-ID: Reply-To: Lennart Borgman , 5119@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1259898467 20993 80.91.229.12 (4 Dec 2009 03:47:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Dec 2009 03:47:47 +0000 (UTC) To: Emacs Bugs Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 04 04:47:40 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NGP8t-0004yL-P3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Dec 2009 04:47:40 +0100 Original-Received: from localhost ([127.0.0.1]:43389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGP8t-00045G-Eo for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Dec 2009 22:47:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGP8n-00043d-Kw for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2009 22:47:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGP8i-00041t-KR for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2009 22:47:32 -0500 Original-Received: from [199.232.76.173] (port=52596 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGP8i-00041q-Eb for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2009 22:47:28 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41783) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NGP8h-0001mT-Rb for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2009 22:47:28 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB43lO3W026174; Thu, 3 Dec 2009 19:47:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nB43j4mB025891; Thu, 3 Dec 2009 19:45:04 -0800 Resent-Date: Thu, 3 Dec 2009 19:45:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Lennart Borgman Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 04 Dec 2009 03:45:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 5119 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125989780125421 (code B ref -1); Fri, 04 Dec 2009 03:45:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 4 Dec 2009 03:36:41 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nB43aeXx025418 for ; Thu, 3 Dec 2009 19:36:41 -0800 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGOyF-0002mV-5L for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2009 22:36:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGOyA-0002dx-HR for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2009 22:36:38 -0500 Original-Received: from [199.232.76.173] (port=54046 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGOyA-0002dn-El for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2009 22:36:34 -0500 Original-Received: from mail-yw0-f172.google.com ([209.85.211.172]:59443) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NGOy9-00017I-W9 for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2009 22:36:34 -0500 Original-Received: by ywh2 with SMTP id 2so2062589ywh.27 for ; Thu, 03 Dec 2009 19:36:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=nNUaaONXv4DqvSeigRdc2W0pIMWh87lTQ7s0De/Ey8A=; b=p+KWpAWu2kq7RIAnHsj0fzmUlCuqRZfscS47+cakDfS1Fk1+WUJzhS6s6HwGvpfviR FLef/D/gVAEGpMQOTk8ZeBsKuX1J+eUDVVvlC6cQIxAUsl78ZS96qzWiQrNXPpGnNhyY SXFwCpM2mkCz7dNswyjsty9hJRee0z8Q6cQOY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=xh1O/gtDsKoBKfcX6KrN4kgHFNje7TLe5wWUr0jOFbgQ23hM3IWt+gdguWjIdhTnXe sleI2ug+iTt6Whq4gZH4ix07xjOwZulzNKeLunT+4P+p1ZvIgSxfqwCta2FDuHE2jIZg e9cwhutGU7GftFkdxyWOfOf1jevk7z/GYls2A= Original-Received: by 10.101.128.36 with SMTP id f36mr3259896ann.86.1259897793255; Thu, 03 Dec 2009 19:36:33 -0800 (PST) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 03 Dec 2009 22:47:32 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33193 Archived-At: It binds TAB to ruby-indent-line. That is against the rules. ;-) It should instead leave this unbound and do (set (make-local-variable 'indent-line-function) 'ruby-indent-line) Index: ruby-mode.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/ruby-mode.el,v retrieving revision 1.11 diff -c -r1.11 ruby-mode.el *** ruby-mode.el 26 Oct 2009 06:43:41 -0000 1.11 --- ruby-mode.el 4 Dec 2009 03:35:16 -0000 *************** *** 166,172 **** (define-key map (kbd "M-C-n") 'ruby-end-of-block) (define-key map (kbd "M-C-h") 'ruby-mark-defun) (define-key map (kbd "M-C-q") 'ruby-indent-exp) - (define-key map (kbd "TAB") 'ruby-indent-line) (define-key map (kbd "C-M-h") 'backward-kill-word) (define-key map (kbd "C-j") 'reindent-then-newline-and-indent) (define-key map (kbd "C-m") 'newline) --- 166,171 ---- *************** *** 1390,1395 **** --- 1389,1396 ---- (setq major-mode 'ruby-mode) (ruby-mode-variables) + (set (make-local-variable 'indent-line-function) + 'ruby-indent-line) (set (make-local-variable 'imenu-create-index-function) 'ruby-imenu-create-index) (set (make-local-variable 'add-log-current-defun-function)