all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: Emacs Bugs <bug-gnu-emacs@gnu.org>
Subject: bug#5119: ruby-mode binds TAB
Date: Fri, 4 Dec 2009 04:36:13 +0100	[thread overview]
Message-ID: <e01d8a50912031936m4ab248fflbe3b85d1d18aa3e0@mail.gmail.com> (raw)

It binds TAB to ruby-indent-line. That is against the rules. ;-)

It should instead leave this unbound and do

  (set (make-local-variable 'indent-line-function)
       'ruby-indent-line)

Index: ruby-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/ruby-mode.el,v
retrieving revision 1.11
diff -c -r1.11 ruby-mode.el
*** ruby-mode.el	26 Oct 2009 06:43:41 -0000	1.11
--- ruby-mode.el	4 Dec 2009 03:35:16 -0000
***************
*** 166,172 ****
      (define-key map (kbd "M-C-n") 'ruby-end-of-block)
      (define-key map (kbd "M-C-h") 'ruby-mark-defun)
      (define-key map (kbd "M-C-q") 'ruby-indent-exp)
-     (define-key map (kbd "TAB")   'ruby-indent-line)
      (define-key map (kbd "C-M-h") 'backward-kill-word)
      (define-key map (kbd "C-j")   'reindent-then-newline-and-indent)
      (define-key map (kbd "C-m")   'newline)
--- 166,171 ----
***************
*** 1390,1395 ****
--- 1389,1396 ----
    (setq major-mode 'ruby-mode)
    (ruby-mode-variables)

+   (set (make-local-variable 'indent-line-function)
+        'ruby-indent-line)
    (set (make-local-variable 'imenu-create-index-function)
         'ruby-imenu-create-index)
    (set (make-local-variable 'add-log-current-defun-function)






             reply	other threads:[~2009-12-04  3:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04  3:36 Lennart Borgman [this message]
2009-12-07 18:32 ` bug#5119: ruby-mode binds TAB Stefan Monnier
2010-06-27 12:38 ` bug#5119: Deniz Dogan
2010-06-27 13:56   ` bug#5119: Drew Adams
2010-06-27 14:06     ` bug#5119: Deniz Dogan
2010-06-27 18:19 ` bug#5119: ruby-mode binds TAB Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e01d8a50912031936m4ab248fflbe3b85d1d18aa3e0@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=5119@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.