Re: Cygwin patches

[Lennart Borgman <lennart.borgman@gmail.com>]

On Fri, Nov 20, 2009 at 10:50 PM, Chong Yidong <cyd@stupidchicken.com> wrote:
> Ken Brown <kbrown@cornell.edu> writes:
>
>> Now that you're preparing for emacs 23.2, could you please apply the
>> cygwin patches that I submitted last June?
>
> Thanks, I've checked in your changes, except for the following:
>
>> --- origsrc/lisp/net/browse-url.el    2009-11-20 11:34:25.000000000 -0500
>> +++ src/lisp/net/browse-url.el        2009-11-20 11:35:28.000000000 -0500
>> @@ -693,7 +693,9 @@
>>         (cond ((not (buffer-modified-p)))
>>               (browse-url-save-file (save-buffer))
>>               (t (message "%s modified since last save" file))))))
>> -  (browse-url (browse-url-file-url file))
>> +  (if (eq system-type 'cygwin)
>> +      (shell-command (concat "cygstart " (shell-quote-argument file)))
>> +    (browse-url (browse-url-file-url file)))
>>    (run-hooks 'browse-url-of-file-hook))
>
> I still don't understand why cygwin needs special handling when, e.g.,
> the other Windows ports don't.  Could you explain?


Move the special part into browse-url. It calls the function in
browse-url-browser-function. That is where the OS specific things
should go.