all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: bug#4951: 23.1.50; browse-url-default-windows-browser bug + patch
Date: Wed, 18 Nov 2009 02:46:31 +0100	[thread overview]
Message-ID: <e01d8a50911171746t1657e6b9hb7781353ba463306@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

browse-url-default-windows-browser does not work any longer. I am unsure
when it stopped working, but on at least Windows XP the attached patch
seems necessary. Could we please apply this as soon as possible so it
will get tested?



In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
 of 2009-10-15
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'

[-- Attachment #2: browse-url.patch --]
[-- Type: text/x-diff, Size: 1752 bytes --]

Index: browse-url.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/net/browse-url.el,v
retrieving revision 1.85
diff -c -r1.85 browse-url.el
*** browse-url.el	6 Nov 2009 05:16:29 -0000	1.85
--- browse-url.el	18 Nov 2009 01:27:21 -0000
***************
*** 444,450 ****
      ;; applies.
      ("^/\\([^:@]+@\\)?\\([^:]+\\):/*" . "ftp://\\1\\2/")
      ,@(if (memq system-type '(windows-nt ms-dos cygwin))
!           '(("^\\([a-zA-Z]:\\)[\\/]" . "file:\\1/")
              ("^[\\/][\\/]+" . "file://")))
      ("^/+" . "file:///"))
    "An alist of (REGEXP . STRING) pairs used by `browse-url-of-file'.
--- 444,450 ----
      ;; applies.
      ("^/\\([^:@]+@\\)?\\([^:]+\\):/*" . "ftp://\\1\\2/")
      ,@(if (memq system-type '(windows-nt ms-dos cygwin))
!           '(("^\\([a-zA-Z]:\\)[\\/]" . "file:///\\1/")
              ("^[\\/][\\/]+" . "file://")))
      ("^/+" . "file:///"))
    "An alist of (REGEXP . STRING) pairs used by `browse-url-of-file'.
***************
*** 834,840 ****
        (if dos-windows-version
  	  (shell-command (concat "start " (shell-quote-argument url)))
  	(error "Browsing URLs is not supported on this system"))
!     (w32-shell-execute "open" url)))
  
  (defun browse-url-default-macosx-browser (url &optional new-window)
    (interactive (browse-url-interactive-arg "URL: "))
--- 834,840 ----
        (if dos-windows-version
  	  (shell-command (concat "start " (shell-quote-argument url)))
  	(error "Browsing URLs is not supported on this system"))
!     (w32-shell-execute nil url)))
  
  (defun browse-url-default-macosx-browser (url &optional new-window)
    (interactive (browse-url-interactive-arg "URL: "))

             reply	other threads:[~2009-11-18  1:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-18  1:46 Lennart Borgman [this message]
2009-11-18  3:35 ` bug#4951: 23.1.50; browse-url-default-windows-browser bug + patch Stefan Monnier
2009-11-18  3:41   ` Lennart Borgman
2009-11-18  5:54     ` Jason Rumney
2009-11-18 13:00       ` Lennart Borgman
2009-11-19  4:37         ` Lennart Borgman
2009-11-23  1:34           ` Lennart Borgman
  -- strict thread matches above, loose matches on Subject: below --
2010-01-02 20:31 Chong Yidong
2011-09-11  5:18 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e01d8a50911171746t1657e6b9hb7781353ba463306@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=4951@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.