all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: bug#3898: 23.1.50; nxml-extend-after-change-region should not return t
Date: Tue, 21 Jul 2009 20:13:23 +0200	[thread overview]
Message-ID: <e01d8a50907211113j6647d3b9naa6faf08c83536e3@mail.gmail.com> (raw)

When an error occurs in nxml-extend-after-change-region it returns t
which makes font-lock-extend-jit-lock-region-after-change to fail
since it expects a cons with two numbers or nil.

The patch below make the return value nil instead.

Index: nxml-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/nxml/nxml-mode.el,v
retrieving revision 1.18
diff -u -b -r1.18 nxml-mode.el
--- nxml-mode.el	5 Jan 2009 03:22:51 -0000	1.18
+++ nxml-mode.el	21 Jul 2009 18:07:03 -0000
@@ -883,7 +883,8 @@
   (unless nxml-degraded
     (setq nxml-last-fontify-end nil)

-    (nxml-with-degradation-on-error 'nxml-extend-after-change-region
+    (let ((ret (nxml-with-degradation-on-error
+                'nxml-extend-after-change-region
 	(save-excursion
 	  (save-restriction
 	    (widen)
@@ -892,6 +893,7 @@
 		(nxml-with-unmodifying-text-property-changes
                   (nxml-extend-after-change-region1
                    start end pre-change-length)))))))))
+      (when (listp ret) ret))))

 (defun nxml-extend-after-change-region1 (start end pre-change-length)
   (let* ((region (nxml-after-change1 start end pre-change-length))



In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
 of 2009-06-30
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'





             reply	other threads:[~2009-07-21 18:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 18:13 Lennart Borgman [this message]
2010-01-16 22:24 ` bug#3898: 23.1.50; nxml-extend-after-change-region should not return t Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e01d8a50907211113j6647d3b9naa6faf08c83536e3@mail.gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=3898@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.