From: Lennart Borgman <lennart.borgman@gmail.com>
To: Jason Rumney <jasonr@gnu.org>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: Small patch for rng-valid.el
Date: Wed, 13 May 2009 22:55:48 +0200 [thread overview]
Message-ID: <e01d8a50905131355w9c837d6l9297a59ed6590075@mail.gmail.com> (raw)
In-Reply-To: <4A0ADA5D.4050308@gnu.org>
On Wed, May 13, 2009 at 4:34 PM, Jason Rumney <jasonr@gnu.org> wrote:
> Lennart Borgman wrote:
>>
>> It seems like I just sent the wrong patch for rng-valid.el on 2 May.
>> Here is the patch I thought I sent. It contains only some error
>> checking and is very simple (the errors actually happens sometimes).
>
> Under what circumstances does the error happen? There is no bug report as
> far as I can see that mentions this problem, and a quick look at the code
> suggests that if rng-validate-up-to-date-end were ever to become nil, there
> would be errors happening throughout the code, so fixing this one place
> would not be sufficient.
There were two different situations that I tried to catch in this
patch. One was were the buffer is gone when a timer is about to run. I
guess there is no problem with that part of the patch.
The other situation is when rng-validate-upto-date-end is nil. And
yes, that is more problematic. I have seen it happen in
rng-after-change-function, but nowhere else. I believe it only has
happened to me when nxml-mode (or rather nxhtml-mode) is used together
with mumamo.el (but I am not sure of that). This might of course
depend on the way I handle this in mumamo. It takes me some time to
investigate this and I would prefer not to do it now since the
handling of parsing functions within a multi mode framework like
mumamo probably require some more general thoughts. (I believe that it
can has something to do with that I do not restart the parser
correctly when creating new chunks. The rng-after-change-function
seems to be set up to early, but fixing this can perhaps be
complicated.)
However the check for a non-nil rng-validate-up-to-date-end in
rng-after-change-function is very cheap so I see no good reason not to
add it there now. I have not looked at the other places where this
variable is used though.
next prev parent reply other threads:[~2009-05-13 20:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 23:14 Small patch for rng-valid.el Lennart Borgman
2009-05-02 1:37 ` Stefan Monnier
2009-05-02 1:41 ` Lennart Borgman
2009-05-02 11:46 ` Davi Leal
2009-05-02 11:50 ` Lennart Borgman
2009-05-10 2:02 ` Lennart Borgman
2009-05-13 9:33 ` Lennart Borgman
2009-05-13 14:34 ` Jason Rumney
2009-05-13 20:55 ` Lennart Borgman [this message]
2009-05-13 22:53 ` Jason Rumney
2009-05-13 22:59 ` Lennart Borgman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e01d8a50905131355w9c837d6l9297a59ed6590075@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.