From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: The source linke in the help buffer Date: Wed, 24 Sep 2008 14:53:37 +0200 Message-ID: References: <48DA138D.9050300@gmail.com> <48DA3004.4030505@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1222260904 18971 80.91.229.12 (24 Sep 2008 12:55:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Sep 2008 12:55:04 +0000 (UTC) Cc: Emacs Devel To: "martin rudalics" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 24 14:55:58 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KiTtn-0005aJ-RW for ged-emacs-devel@m.gmane.org; Wed, 24 Sep 2008 14:55:20 +0200 Original-Received: from localhost ([127.0.0.1]:39737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KiTsl-0003e2-VC for ged-emacs-devel@m.gmane.org; Wed, 24 Sep 2008 08:54:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KiTsD-0003TL-1r for emacs-devel@gnu.org; Wed, 24 Sep 2008 08:53:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KiTsC-0003Su-AW for emacs-devel@gnu.org; Wed, 24 Sep 2008 08:53:40 -0400 Original-Received: from [199.232.76.173] (port=50657 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KiTsC-0003Sq-47 for emacs-devel@gnu.org; Wed, 24 Sep 2008 08:53:40 -0400 Original-Received: from fg-out-1718.google.com ([72.14.220.154]:63349) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KiTsB-0004Bq-4O for emacs-devel@gnu.org; Wed, 24 Sep 2008 08:53:39 -0400 Original-Received: by fg-out-1718.google.com with SMTP id l26so2278341fgb.30 for ; Wed, 24 Sep 2008 05:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=c+db+k9qa1iukp6tRQwK9uO1f79PBXTkrZd9oFKVaks=; b=mYUpog/pjLQ+OdaFSIFpqaytFzu4+FH92QmHOsYY3JOm/3wtshKHjyfNNq+/0eOicj lDRfN8lO3qkq5UpGFYWJRO/oU3SebbnllUARPtZV6XrlOwa0jA7P+/PpycLObwUV83v0 0zWvCd0xIfrzRTAmhI9dF2kxCNEyl+Tc+Z2oA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=Vbq5IcsjiWZAM4G4NPM2HQLdCmkzb8LKGPa7vMPXQbwQqtHluzLP2X3zPFwrUWGyyZ Lz3gELh73QJiuqXwI6G7iIC8pQ9pC5KTG26iLDBTGWgtI+6S2E6AjtUMoaju+uoacTAc zFaUhp5g/EdX/MO6KEsxUKsLgzUbKuomtzJCI= Original-Received: by 10.86.95.8 with SMTP id s8mr7358357fgb.6.1222260817203; Wed, 24 Sep 2008 05:53:37 -0700 (PDT) Original-Received: by 10.86.65.3 with HTTP; Wed, 24 Sep 2008 05:53:37 -0700 (PDT) In-Reply-To: <48DA3004.4030505@gmx.at> Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104092 Archived-At: On 9/24/08, martin rudalics wrote: > > The source link in the help buffer now includes th whole path. Is this > > the intention now? > > It was _my_ intention in reaction to bug#587 you filed. Hi Martin, thanks for fixing it. I did not follow the discussion that closely. I remembered that someone said that the directory was stripped to early, but maybe the full path is not needed if the file belongs to Emacs? > > What happened with the possibility to go to a checked out source file > > instead of the file in the installed elisp tree? > > How would Emacs reliably know where the "checked out" file is? Where > would you want to go after an update from the repository but before you > remade or recompiled? And where would you want to go when you redefine > a function from a checked-out file and evaluated that definition? I was more thinking about a way to go to the checked out elisp source file from the elisp file you are visiting. That is pretty useful for me at least. This is what I use now: (defun find-emacs-source-file () "Find checked out Emacs source corresponding to buffer file. Display it in other window." (interactive) (let* ((install-directory (file-name-as-directory (expand-file-name ".." exec-directory))) (relative-install (file-relative-name (buffer-file-name) install-directory)) source-file) (when (string= ".." (substring relative-install 0 2)) (error "This file is not in Emacs lisp tree")) (setq source-file (expand-file-name relative-install source-directory)) (find-file-other-window source-file))) Maybe it could go to the same line etc. > If people think that's useful we can introduce variables like > `emacs-lisp-source-directory' and `emacs-C-source-directory' and have > help go find them there if these are non-nil. We can also make an > optional, second link for this in the help-buffer, let `find-function' > use the same approach (obsoleting > `find-function-C-source-directory'), > and many more. > > martin >