From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman" Newsgroups: gmane.emacs.devel Subject: Re: nxml-mode uses wrong method to run 'nxml-mode-hook Date: Mon, 16 Jun 2008 13:10:11 +0200 Message-ID: References: <18516.44650.776858.871951@priss.frightenedpiglet.com> <4856331F.6040500@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_20683_22815351.1213614611715" X-Trace: ger.gmane.org 1213614632 20587 80.91.229.12 (16 Jun 2008 11:10:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Jun 2008 11:10:32 +0000 (UTC) Cc: sand@blarg.net, emacs-devel@gnu.org To: "Jason Rumney" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 16 13:11:16 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K8Cc9-00076A-BF for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2008 13:11:09 +0200 Original-Received: from localhost ([127.0.0.1]:50655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8CbL-00026Z-2D for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2008 07:10:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8CbG-00026E-R5 for emacs-devel@gnu.org; Mon, 16 Jun 2008 07:10:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8CbF-000261-Oa for emacs-devel@gnu.org; Mon, 16 Jun 2008 07:10:13 -0400 Original-Received: from [199.232.76.173] (port=40847 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8CbF-00025y-Im for emacs-devel@gnu.org; Mon, 16 Jun 2008 07:10:13 -0400 Original-Received: from fg-out-1718.google.com ([72.14.220.157]:1444) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K8CbF-0007yd-3m for emacs-devel@gnu.org; Mon, 16 Jun 2008 07:10:13 -0400 Original-Received: by fg-out-1718.google.com with SMTP id l26so3813338fgb.30 for ; Mon, 16 Jun 2008 04:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=JOch91Jb9c+KsJ31pOdEEYp/FZ1LrDC2l1z3Wn6Xg20=; b=iOcbLVYEcyNoemMbET9Wf0N06+vxMOu9EaH0IqzdCEbc4sAGGzEhEXE87PFTpsWLHQ +p1TVPj9m/jfbZCiABPCHCTy8a+LxZ+9+FHQ+jnCeiJgQ2x4OJh92/WOZ8Tcmc+Gl1zC 0loJw9hZ95Z8zpITY91JbJGN9rlwtS5lSSel4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=nArnXNNE5LKwZHQz+9vjT9k3iuknxc4GUqYzJOw+b+RGNdvYrdar/ICjzWTM0DFvVm hA9epibryszfCwKV4BNAgXppe806hSHP+midfEs70KXLKZAsCOduX+d4pr1t2Rp0R3b7 X3B9xYKR2pWT10M4Vn69thSHCZCnEzZr8UMzc= Original-Received: by 10.86.66.11 with SMTP id o11mr7750047fga.43.1213614611732; Mon, 16 Jun 2008 04:10:11 -0700 (PDT) Original-Received: by 10.86.66.2 with HTTP; Mon, 16 Jun 2008 04:10:11 -0700 (PDT) In-Reply-To: <4856331F.6040500@gnu.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99298 Archived-At: ------=_Part_20683_22815351.1213614611715 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Maybe it would be good to mention run-mode-hooks or perhaps better link to (info "(elisp) Mode Hooks") from (info "(elisp) Running Hooks")? On 6/16/08, Jason Rumney wrote: > > sand@blarg.net wrote: > >> The bottom of the function 'nxml-mode' ("nxml/nxml-mode.el", line 554; >> your mileage may vary) has >> >> (run-hooks 'nxml-mode-hook) >> >> It should use 'run-mode-hooks', because this is a major mode >> definition. Can someone fix that? >> >> It looks like there are some other major modes with the same problem. >> For example: terminal-mode, view-mode, remember-mode, erc, rmail, >> rcirc. Most of the matches below are minor modes, though. >> >> > > The other major modes don't seem to be editing modes, and most of them have > been in Emacs for a long time, so I am not sure if they should be changed, > or if they have been left deliberately. But I have changed nxml-mode. > > > > ------=_Part_20683_22815351.1213614611715 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Maybe it would be good to mention run-mode-hooks or perhaps better link to (info "(elisp) Mode Hooks") from (info "(elisp) Running Hooks")?

On 6/16/08, Jason Rumney <jasonr@gnu.org> wrote:
sand@blarg.net wrote:
The bottom of the function 'nxml-mode' ("nxml/nxml-mode.el", line 554;
your mileage may vary) has

 (run-hooks 'nxml-mode-hook)

It should use 'run-mode-hooks', because this is a major mode
definition.  Can someone fix that?

It looks like there are some other major modes with the same problem.
For example: terminal-mode, view-mode, remember-mode, erc, rmail,
rcirc.  Most of the matches below are minor modes, though.
 

The other major modes don't seem to be editing modes, and most of them have been in Emacs for a long time, so I am not sure if they should be changed, or if they have been left deliberately. But I have changed nxml-mode.




------=_Part_20683_22815351.1213614611715--