From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Martin Pool Newsgroups: gmane.emacs.devel Subject: Re: support for bzr shelve/unshelve in vc-dir Date: Fri, 11 Dec 2009 15:02:51 +1100 Message-ID: References: <200912011947.nB1JlaAp027561@godzilla.ics.uci.edu> <200912032257.nB3Mv97m029382@godzilla.ics.uci.edu> <87d42vvabf.fsf@uwakimon.sk.tsukuba.ac.jp> <200912040147.nB41ldTH000836@godzilla.ics.uci.edu> <87hbs7zbs2.fsf@telefonica.net> <200912042118.nB4LIS4j009931@godzilla.ics.uci.edu> <878wdiz9hz.fsf@telefonica.net> <200912101402.nBAE2wnW011990@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1260519794 29975 80.91.229.12 (11 Dec 2009 08:23:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Dec 2009 08:23:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 11 09:23:07 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NJ0mI-0006E6-FU for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2009 09:23:06 +0100 Original-Received: from localhost ([127.0.0.1]:51015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJ0mH-00064F-TA for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2009 03:23:05 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIwia-0005nj-4G for emacs-devel@gnu.org; Thu, 10 Dec 2009 23:03:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIwiU-0005iB-8D for emacs-devel@gnu.org; Thu, 10 Dec 2009 23:02:58 -0500 Original-Received: from [199.232.76.173] (port=36710 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIwiU-0005i7-2h for emacs-devel@gnu.org; Thu, 10 Dec 2009 23:02:54 -0500 Original-Received: from mail-pw0-f47.google.com ([209.85.160.47]:56896) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NIwiT-0002NI-IO for emacs-devel@gnu.org; Thu, 10 Dec 2009 23:02:53 -0500 Original-Received: by pwi1 with SMTP id 1so384339pwi.26 for ; Thu, 10 Dec 2009 20:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=DVFryeQESGdwMwkLX3F5UmjwZTQTX+dxbugYl2n5b7U=; b=vV0N11ZN/SzWgAw3pXxBGlRE8zrmQHhD619ADoxWaY1E/3m6GLxK6z4pQWCoMcDE/w uGL5zH6lYYQhotuRqllyXJHaBOY04yxzz6pjo0xOJPstWYg3+eKzaX0PsORhAt8AfqfE qYDjsxTafm4PyKtI49b4BXMu0vYhX7/iSW1DE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=cUD4Yn8zejA8d5GRx570xxq+tcbstmUrD6vIm7GMwgqGu1HbzNqXyV8zcU0xwPDgtr dB/o4igWEyQqqd4/CXv+UR88zFXbfUMj4WUj5TN2ZxVY9gL8+B6W/0TJBP4ZWswxntHQ uhUPAtua7ApFReOvbyzkFCrbty1/Au0hXqyx8= Original-Received: by 10.140.179.25 with SMTP id b25mr495713rvf.294.1260504171954; Thu, 10 Dec 2009 20:02:51 -0800 (PST) In-Reply-To: <200912101402.nBAE2wnW011990@godzilla.ics.uci.edu> X-Google-Sender-Auth: 22bf1746fc40f6fa X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Fri, 11 Dec 2009 03:22:58 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118539 Archived-At: 2009/12/11 Dan Nicolaescu : > This discussion started in part because of the perceived difficulty of > getting a patch integrated to implement "bzr unshelve --keep" > (https://bugs.launchpad.net/bzr/+bug/492091) I would be the first to agree that we have made it too hard to get changes in in the past, and that while we are doing better now we can still do more. However, I can't find any history with this particular request, just a recently-filed bug? > bzr shelves are not very usable without this option, you can't go back > and forth between shelved versions. > The patch would change bzrlib/shelf_ui.py:Unshelver.from_args to set > delete_shelf to False when "--keep" is passed. =A0So about 3 lines total. > > Would such a patch need copyright assignment? > Even if it does, given the above description, a bzr developer can > reproduce the change needed in a few seconds... > Can you please help get this solved? Yes, it would need copyright assignment. We do this on every patch because our legal opinion said that there is no globally-recognized concept of "too small to copyright", and because we want to have clear copyright. Many developers, both at Canonical and otherwise, have given feedback that they think the FSF approach of saying "about a paragraph" (or whatever it precisely is) is a reasonable commonsense tradeoff.. I'll have a look at doing this. Thanks for looking into it. --=20 Martin