From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#13500: 24.2.92; tetris score grows after ending the game Date: Sat, 19 Jan 2013 15:11:28 -0500 Message-ID: References: <87mww5cac3.fsf@turtle.gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1358626334 28955 80.91.229.3 (19 Jan 2013 20:12:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Jan 2013 20:12:14 +0000 (UTC) Cc: 13500@debbugs.gnu.org To: Sven Joachim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 19 21:12:33 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TwemD-0005P8-SM for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2013 21:12:29 +0100 Original-Received: from localhost ([::1]:40063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twelw-0003If-QS for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2013 15:12:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twelt-0003Ia-Us for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2013 15:12:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Twels-0007vb-Oi for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2013 15:12:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Twels-0007vX-LT for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2013 15:12:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Twemk-00076N-82 for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2013 15:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Jan 2013 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13500 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13500-submit@debbugs.gnu.org id=B13500.135862634627250 (code B ref 13500); Sat, 19 Jan 2013 20:13:02 +0000 Original-Received: (at 13500) by debbugs.gnu.org; 19 Jan 2013 20:12:26 +0000 Original-Received: from localhost ([127.0.0.1]:40559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TwemA-00075T-FQ for submit@debbugs.gnu.org; Sat, 19 Jan 2013 15:12:26 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:41759) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Twem8-00075M-Jn for 13500@debbugs.gnu.org; Sat, 19 Jan 2013 15:12:25 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TwelE-0002cb-M2; Sat, 19 Jan 2013 15:11:28 -0500 X-Spook: Uzbekistan Rumsfeld White Water tempest csim offensive X-Ran: 6x;`((1#5P=>p8|Kw?G}?h3,JtVOwD')42H+69^o!px~(f4.9#NI!.(gd_wP#/(]Z"mn.L X-Hue: black X-Attribution: GM In-Reply-To: <87mww5cac3.fsf@turtle.gmx.de> (Sven Joachim's message of "Sat, 19 Jan 2013 19:10:52 +0100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70049 Archived-At: Sven Joachim wrote: > Start tetris with M-x tetris and keep pressing SPC until the playing > area is filled. Now Emacs writes the score to > ~/.emacs.d/games/tetris-scores, but not only once but several times per > second, increasing the score each time as if the game is still going on > (press C-g to stop that). I can't reproduce this, though I did find an (old) bug in gamegrid-add-score-with-update-game-score. The fact that your scores get written to ~/.emacs.d/games means that /usr/local/libexec/emacs/24.2.92/arch/update-game-score is not setuid. If I set it non-setuid, and do rm- rf ~/.emacs.d/games/ then Emacs fails to write score files due to a gamegrid-add-score-with-update-game-score bug. If I fix that bug (see below), or mkdir ~/.emacs.d/games first, then it works fine. What happens if you rm ~/.emacs.d/games/tetris-scores? *** lisp/play/gamegrid.el 2013-01-01 09:11:05 +0000 --- lisp/play/gamegrid.el 2013-01-19 20:02:52 +0000 *************** *** 507,513 **** gamegrid-user-score-file-directory)) (t (let ((f (expand-file-name gamegrid-user-score-file-directory))) ! (when (file-writable-p f) (unless (eq (car-safe (file-attributes f)) t) (make-directory f)) --- 507,513 ---- gamegrid-user-score-file-directory)) (t (let ((f (expand-file-name gamegrid-user-score-file-directory))) ! (when (file-writable-p (directory-file-name f)) (unless (eq (car-safe (file-attributes f)) t) (make-directory f))