From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#22847: #17062: 24.3 current-fill-column breaks fill-match-adaptive-prefix Date: Sat, 10 Dec 2016 21:18:57 -0500 Message-ID: References: <56D3F443.9000706@easy-emacs.de> <83si0b8q7t.fsf@gnu.org> <7dvauuyruh.fsf@fencepost.gnu.org> <831sxhikxu.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481422813 19448 195.159.176.226 (11 Dec 2016 02:20:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Dec 2016 02:20:13 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 22847@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 11 03:20:08 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFtkF-0003x5-TC for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Dec 2016 03:20:08 +0100 Original-Received: from localhost ([::1]:53801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFtkJ-0004wx-UT for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Dec 2016 21:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFtkA-0004we-WC for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2016 21:20:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFtkA-0005Ad-2W for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2016 21:20:02 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50208) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cFtk9-0005AZ-Vt for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2016 21:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cFtk9-0002XM-SJ for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2016 21:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2016 02:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22847-submit@debbugs.gnu.org id=B22847.14814227459669 (code B ref 22847); Sun, 11 Dec 2016 02:20:01 +0000 Original-Received: (at 22847) by debbugs.gnu.org; 11 Dec 2016 02:19:05 +0000 Original-Received: from localhost ([127.0.0.1]:37374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFtjF-0002Vt-5v for submit@debbugs.gnu.org; Sat, 10 Dec 2016 21:19:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFtjE-0002VP-I5 for 22847@debbugs.gnu.org; Sat, 10 Dec 2016 21:19:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFtj8-0004ux-Ln for 22847@debbugs.gnu.org; Sat, 10 Dec 2016 21:18:59 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFtj8-0004us-IK for 22847@debbugs.gnu.org; Sat, 10 Dec 2016 21:18:58 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cFtj8-0003dl-3m; Sat, 10 Dec 2016 21:18:58 -0500 X-Spook: argus Merlin Al Qaida Chemical spill Wave MILSATCOM X-Ran: HW@GG:pIi@Y5nv@C#-oKYJHs16'=3hjYtyZD{HEN,~5G,1J`JTad%tpixo][5E6zU0*M"m X-Hue: magenta X-Attribution: GM In-Reply-To: <831sxhikxu.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 09 Dec 2016 10:08:29 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126834 Archived-At: Eli Zaretskii wrote: >> TLDR: >> Let's remove the test for nil fill-column in current-fill-column. > > I don't understand what you propose to do instead. > current-fill-column does arithmetics on fill-column when it's non-nil, > so we cannot just remove the test, because the function will then > signal an error. Yes, I'm fine with the error. > I see 3 possible ways to fix these bugs: > > . Fix the code which is not prepared for fill-column being nil to be > prepared. This leaves everyone happy, except, perhaps, the person > who would need to fix all those places in Emacs. I think this would be a waste of time for the Emacs, and third party, maintainers. > . Change current-fill-column to return most-positive-fixnum when > fill-column is nil. I suppose this would be ok, so long as it comes with something like a once-per session display-warning about this being an obsolete usage that will be removed soon. > . Disallow fill-column being nil and remove the test from > current-fill-column without changing anything else, i.e. let it > signal an error, perhaps with some text that tells this value is > no longer supported. This will break setups of those who use that > value to disable auto-fill, something that was available since > forever, so I don't think we can do that. That's what I would do. I don't have a problem breaking an undocumented feature that already fails in several places, and has a trivial workaround (don't want auto-fill - don't turn it on). Other times I can recall similar breakage happening: byte-compile of nil, setq with odd number of arguments. People gripe for a bit, then get on with life.