From: Glenn Morris <rgm@gnu.org>
To: jpff <jpff@codemist.co.uk>
Cc: 2196@emacsbugs.donarmstrong.com, rms@gnu.org
Subject: bug#2196: 23.0.90; rmail not reading email
Date: Mon, 09 Feb 2009 22:35:44 -0500 [thread overview]
Message-ID: <dfskmnhskv.fsf@fencepost.gnu.org> (raw)
In-Reply-To: 9489-Thu05Feb2009083017+0000-jpff@codemist.co.uk
retitle 2196 movemail.c, pop, and mbox
severity 2196 minor
stop
jpff wrote:
> I think the culprit is movemail in lib-src
Indeed. The specific bit you cited is not a problem (I think), but the
functions mbx_delimit_begin and mbx_delimit_end are Babyl-specific,
and so movemail was totally broken for the retrieval of mail via pop.
That's rather bad.
I've installed a fix that just prints
From movemail
at the start of each message. I think this is enough to make it work.
It would be nice to add the time:
From movemail Mon Feb 9 14:51:58 2009
A further patch for this is attached. I don't know how
correct/portable the code is though (?).
*** movemail.c 10 Feb 2009 03:30:41 -0000 1.98
--- movemail.c 10 Feb 2009 03:31:20 -0000
***************
*** 60,65 ****
--- 60,67 ----
#include <sys/file.h>
#include <stdio.h>
#include <errno.h>
+ #include <string.h>
+ #include <time.h>
#include <getopt.h>
#ifdef HAVE_UNISTD_H
***************
*** 923,929 ****
mbx_delimit_begin (mbf)
FILE *mbf;
{
! if (fputs ("From movemail\n", mbf) == EOF)
return (NOTOK);
return (OK);
}
--- 925,940 ----
mbx_delimit_begin (mbf)
FILE *mbf;
{
! time_t now;
! struct tm *ltime;
! char fromline[40] = "From movemail ";
!
! now = time (NULL);
! ltime = localtime (&now);
!
! strcat (fromline, asctime (ltime));
!
! if (fputs (fromline, mbf) == EOF)
return (NOTOK);
return (OK);
}
next prev parent reply other threads:[~2009-02-10 3:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 8:30 bug#2196: 23.0.90; rmail not reading email jpff
2009-02-10 3:35 ` Glenn Morris [this message]
2009-02-10 3:45 ` Processed: " Emacs bug Tracking System
2009-02-10 9:32 ` Eli Zaretskii
[not found] ` <bmyctzkst.fsf@fencepost.gnu.org>
2009-02-04 14:24 ` jpff
2009-02-05 5:40 ` Richard M Stallman
2009-02-11 4:10 ` bug#2196: marked as done (movemail.c, pop, and mbox) Emacs bug Tracking System
2009-02-11 7:57 ` bug#2196: 23.0.90; rmail not reading email Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfskmnhskv.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=2196@emacsbugs.donarmstrong.com \
--cc=jpff@codemist.co.uk \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.