From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance Date: Thu, 5 Jan 2023 14:55:06 +0200 Message-ID: References: <875yfyebi0.fsf@posteo.net> <87a6331xts.fsf@posteo.net> <1119f0ff-aacf-b41e-e7f7-b0a00132b35f@yandex.ru> <255D9E93-422C-4A43-9876-751FDB8E61DB@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15690"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: Philip Kaludercic , 58950@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 13:56:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDPmz-0003v0-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 13:56:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDPmt-0006rW-JV; Thu, 05 Jan 2023 07:56:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDPms-0006rH-CG for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 07:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDPms-0004gH-4E for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 07:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDPmr-0006Am-TG for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 07:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2023 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58950 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58950-submit@debbugs.gnu.org id=B58950.167292331723675 (code B ref 58950); Thu, 05 Jan 2023 12:56:01 +0000 Original-Received: (at 58950) by debbugs.gnu.org; 5 Jan 2023 12:55:17 +0000 Original-Received: from localhost ([127.0.0.1]:50491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDPm8-00069n-TO for submit@debbugs.gnu.org; Thu, 05 Jan 2023 07:55:17 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:54786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDPm6-00069W-Pi for 58950@debbugs.gnu.org; Thu, 05 Jan 2023 07:55:15 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id o15so27927975wmr.4 for <58950@debbugs.gnu.org>; Thu, 05 Jan 2023 04:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=vBymoo6R9oTo0QffjxtlEaju7+LXEeYU7/QlxTz+p30=; b=oQZhi/Z9d9LdL5Z0gILNNu6SXDLJLxpdXa1SjxzepTat9hW2TYB7aP95eo/71v1XT7 z1eSawUX7kj6EINGeOax38Ou3ehleyDZJ1P4uF8Q3Qo23bcfWvC4yNEh0uGVLwLjYy7d fsLFrMFlFHoeTOTi2wbNHkH06fqwHCYZ+uP0vJXpKigxUf18Bxl2RqjH6Nna9wCAwydm I4qX4ezPXpeZjvZM8QW3bT74sEWzh/lI3eEjZ9tZzIEWUOhXPmrdKX+7xohMf7cCR/sd f2MHHsDx1b5CluLOy0NL/q6ODwbslwqWgULV0X8+hKrb/MgII+V+IXBST7jfxNxFO4Xb wPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vBymoo6R9oTo0QffjxtlEaju7+LXEeYU7/QlxTz+p30=; b=yFT1qu6RpSDlJHi5nLxLnCKu7DtgUvqTWnCti4R7F4xBroMIHYvEfd8W/fHYoHZpN3 /8FEz26LWIBrufj2hAHMooOwvBYpyqP2Hk6XmzUdm7tIeIwKdrAENle8OxUbOg3Ktdyo DaPjjcYYJYlr4CqFwCcdCnR1O/O1sTMgezKgsNbRDEkTZD7X4BNh0coRsFDwLZrDNPul rnIRDf3Nza9kiozMDLaiVAcEd0tt04dCGx6FX7rTceCTQITfgtaXOLYRw4nly8gHePTN REFxNqGaawq17URktzNAZMvsrU2lNVDnhIufWuzlf5eWwiJqdJrySdmMXH+AP5O5fAsW /ejg== X-Gm-Message-State: AFqh2kqHBRHtvQzSvpCrdolVVgCgGGaqjnOKdbwcE/Sexf0pbZtuiQbl eEpes94CZn17Msv2L5/UOBo= X-Google-Smtp-Source: AMrXdXumezOVgMhT726DX9k5qg6JvoRYc5wZ4elmjJbz/wwNnxRZOuOVcGFqb+ALQzrEPu8xat/5KQ== X-Received: by 2002:a7b:c3c9:0:b0:3d2:e28:647f with SMTP id t9-20020a7bc3c9000000b003d20e28647fmr43848359wmj.15.1672923308856; Thu, 05 Jan 2023 04:55:08 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u18-20020a05600c4d1200b003c21ba7d7d6sm2153905wmp.44.2023.01.05.04.55.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 04:55:08 -0800 (PST) Content-Language: en-US In-Reply-To: <255D9E93-422C-4A43-9876-751FDB8E61DB@acm.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252595 Archived-At: On 05/01/2023 12:31, Mattias Engdegård wrote: > 5 jan. 2023 kl. 05.31 skrev Stefan Monnier: > >> I don't much like the kind of mini-language we invented for >> `buffer-match-p`. I'd prefer we just used plain old ELisp for that. > Yes, I sort of wondered whether we were going full Greenspun here. We haven't added many embedded languages into our embedded language lately. > > The usual DSL worthiness criteria: > > - more expressive than plain code for the domain > - potential for significantly better performance > - better error-checking, statically or dynamically > - structured editing > > etc, don't really seem to be met here but I'm not deeply familiar with the problem and perhaps the author could make a better case for it. Note that we already had ah-hoc and informally-specified pieces of such DSL before, in font-lock-global-modes and display-buffer-alist. The new use in show-paren-predicate seems fitting too. I'm not sure how we'd reach the same goals with plain old Elisp (structured editing in particular -- in Customize).