From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Benjamin Orthen Newsgroups: gmane.emacs.bugs Subject: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel Date: Wed, 27 Sep 2023 12:53:59 +0200 Message-ID: References: <4b1ff1660351348f3d5f1bc848965d59@orthen.net> <874jnf3d0c.fsf@posteo.net> <87wn0a2sp8.fsf@posteo.net> <87fs6y6jkq.fsf@posteo.net> <647c4e7a08e8a4b048b3fe386ac67604d79198c2.camel@orthen.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="=-2BVGFyMQFwRSXY+UZH2A" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32524"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , 63916@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 27 12:54:58 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qlSC2-0008Ep-2M for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Sep 2023 12:54:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qlSBv-00066a-Oe; Wed, 27 Sep 2023 06:54:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlSBs-00061w-De for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2023 06:54:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qlSBs-0007E0-4k for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2023 06:54:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qlSC5-0000Uo-KP for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2023 06:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Benjamin Orthen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Sep 2023 10:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63916 X-GNU-PR-Package: emacs Original-Received: via spool by 63916-submit@debbugs.gnu.org id=B63916.16958120581820 (code B ref 63916); Wed, 27 Sep 2023 10:55:01 +0000 Original-Received: (at 63916) by debbugs.gnu.org; 27 Sep 2023 10:54:18 +0000 Original-Received: from localhost ([127.0.0.1]:50621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlSBN-0000TH-NH for submit@debbugs.gnu.org; Wed, 27 Sep 2023 06:54:18 -0400 Original-Received: from mailproxy05.manitu.net ([217.11.48.69]:51802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlSBK-0000T8-U2 for 63916@debbugs.gnu.org; Wed, 27 Sep 2023 06:54:16 -0400 In-Reply-To: <647c4e7a08e8a4b048b3fe386ac67604d79198c2.camel@orthen.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271415 Archived-At: --=-2BVGFyMQFwRSXY+UZH2A Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, the assignment/disclaimer process has been completed, so this is not blocking the patch anymore. Best, Benjamin On Mon, 2023-09-11 at 11:58 +0200, Benjamin Orthen wrote: > Hi, >=20 > I've sent the mail to assign@gnu.org=C2=A0and request the assignment form= . >=20 > I modified the changes according to your and Philip's remarks. >=20 > On Fri, 2023-09-08 at 15:35 -0400, Stefan Monnier wrote: > > Hi, > >=20 > > > Instead of looking only at the git log of the main package file, > > > we > > > look instead at the git log of all files of the core package. > > > This way, a new devel version is created when any other package > > > file is > > > changed, not just the main file. > >=20 > > It has a minor downside which is that it slows down the > > overwhelming > > cases (where there are no changes), but it's probably lost in the > > noise, > > so it sounds like a very good idea, thank you. > >=20 > > > Is this the right mailing list to send the patch? > >=20 > > Yes. > >=20 > > [ BTW, Philip's `list-ensure` is called `ensure-list` :-) > > =C2=A0 And yes, I think it's OK to use functionality from Emacs-28.=C2= =A0 ] > >=20 > > > +=C2=A0 (when-let > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ((core (elpaa--spec-get pkg-spec :cor= e))) > >=20 > > AFAICT this code is only used when `:core` is non-nil, so better > > either > > not test for it redundantly, or do it via `cl-assert`. >=20 > Done > >=20 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unless (member item exclu= des) > >=20 > > The code looks generally good, but I'm not sure about the one line > > above: > > - I know it won't do the right thing for ERC's > > "lisp/erc/ChangeLog.*" > > =C2=A0 but it's probably harmless (those files basically never change > > =C2=A0 anyway). > > - I have the impression that it won't do the right thing for > > =C2=A0 `use-package`'s "bind-key.el" >=20 > I changed the code to ignore files using the wildcards in :excludes. > This still does not work for "bind-key.el", but IMO this can and > should be solved by changing it to "lisp/use-package/bind-key.el",=C2=A0 > similar to how erc is doing it ("lisp/erc/erc-loaddefs.el" ). >=20 > (The commentary says: ";; Exclude matches must be against the full > file-name, substring matches don't > ;; work unless wildcards are used (e.g. use "etc/*" instead of > "etc/").") >=20 > >=20 > > Also, I see you do (concat item file) but you only know that `item` > > is > > a directory, not that it ends with a `/`.=C2=A0 Better use `file-name- > > concat`. >=20 > With `directory-files-recursively` this has resolved itself. > >=20 > > Last but not least: I think this doesn't quite qualify as "trivial" > > so > > we'd need you to sign the copyright paperwork (well, maybe with > > some of > > the suggested simplifications, it could qualify as "trivial", but > > it's > > easier if you sign the paperwork so we don't have to worry about > > it, > > especially if you ever submit more code, which I hope you will). > > To that end, please fill the form below and email it to the FSF as > > instructed so they can send you the appropriate paperwork to sign. > >=20 > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Stefan > >=20 > >=20 > > Please email the following information to assign@gnu.org, and we > > will send you the assignment form for your past and future changes. > >=20 > > Please use your full legal name (in ASCII characters) as the > > subject > > line of the message. > > ------------------------------------------------------------------- > > --- > > REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES > >=20 > > [What is the name of the program or package you're contributing > > to?] > > Emacs > >=20 > > [Did you copy any files or text written by someone else in these > > changes? > > Even if that material is free software, we need to know about it.] > >=20 > >=20 > > [Do you have an employer who might have a basis to claim to own > > your changes?=C2=A0 Do you attend a school which might make such a > > claim?] > >=20 > >=20 > > [For the copyright registration, what country are you a citizen > > of?] > >=20 > >=20 > > [What year were you born?] > >=20 > >=20 > > [Please write your email address here.] > >=20 > >=20 > > [Please write your postal address here.] > >=20 > >=20 > >=20 > >=20 > >=20 > > [Which files have you changed so far, and which new files have you > > written > > so far?] > >=20 >=20 --=-2BVGFyMQFwRSXY+UZH2A Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Hi,

the assignment/discl= aimer process has been completed, so this is not blocking the patch anymore= .


Best,
Benjamin


On Mon, 2023-09-11 at 11:58 +0200, Benjamin= Orthen wrote:
Hi,

I've sent the mail to assign@gnu.or= g and request the assignment form.

I modi= fied the changes according to your and Philip's remarks.

On Fri, 2023-09-08 at 15:35 -0400, Stefan Monnier wrote:
Hi,

Instead of looking only at the git log of the main package file,= we
look instead at the git log of all files of the core pack= age.
This way, a new devel version is created when any other = package file is
changed, not just the main file.

It has a minor downside which is that it slow= s down the overwhelming
cases (where there are no changes), b= ut it's probably lost in the noise,
so it sounds like a very = good idea, thank you.

Is this the right mailing list to send the patch?
=

Yes.

[ BTW, Philip's `list= -ensure` is called `ensure-list` :-)
  And yes, I think = it's OK to use functionality from Emacs-28.  ]

+  (when-let
+ &nb= sp;    ((core (elpaa--spec-get pkg-spec :core)))

AFAICT this code is only used when `:core` i= s non-nil, so better either
not test for it redundantly, or d= o it via `cl-assert`.

Done
<= blockquote type=3D"cite" style=3D"margin:0 0 0 .8ex; border-left:2px #729fc= f solid;padding-left:1ex">

+&= nbsp;           &nbs= p;       (unless (member item excludes)

The code looks generally good, but I'm= not sure about the one line
above:
- I know it= won't do the right thing for ERC's "lisp/erc/ChangeLog.*"
&n= bsp; but it's probably harmless (those files basically never change
  anyway).
- I have the impression that it won't = do the right thing for
  `use-package`'s "bind-key.el"

I changed the code to ignore files= using the wildcards in :excludes.
This still does not work for "= bind-key.el", but IMO this can and should be solved by changing it to "lisp= /use-package/bind-key.el", 
similar to how erc is doing it (= "lisp/erc/erc-loaddefs.el" ).

(The commentary says= : ";; Exclude matches must be against the full file-name, substring matches= don't
;; work unless wildcards are used (e.g. use "etc/*" instea= d of "etc/").")


Also, I see you do (concat item file) but you only know that `item`= is
a directory, not that it ends with a `/`.  Better us= e `file-name-concat`.

With `direc= tory-files-recursively` this has resolved itself.

Last but not least: I think this doesn't quite q= ualify as "trivial" so
we'd need you to sign the copyright pa= perwork (well, maybe with some of
the suggested simplificatio= ns, it could qualify as "trivial", but it's
easier if you sig= n the paperwork so we don't have to worry about it,
especiall= y if you ever submit more code, which I hope you will).
To th= at end, please fill the form below and email it to the FSF as
instructed so they can send you the appropriate paperwork to sign.


      &n= bsp; Stefan


Please email the fo= llowing information to assign@gnu.org= , and we
will send you the assignment form for your past and = future changes.

Please use your full legal nam= e (in ASCII characters) as the subject
line of the message.
--------------------------------------------------------------= --------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're = contributing to?]
Emacs

[Did you= copy any files or text written by someone else in these changes?
=
Even if that material is free software, we need to know about it.]
=


[Do you have an employer who might= have a basis to claim to own
your changes?  Do you atte= nd a school which might make such a claim?]

[For the copyright registration, what country are you a citize= n of?]


[What year were you born= ?]


[Please write your email add= ress here.]


[Please write your = postal address here.]





[Which files have you changed so far, a= nd which new files have you written
so far?]


--=-2BVGFyMQFwRSXY+UZH2A--