From: Daniel Mendler <mail@daniel-mendler.de>
To: Dmitry Gutov <dgutov@yandex.ru>, Juri Linkov <juri@linkov.net>
Cc: Gregory Heytings <gregory@heytings.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH)
Date: Thu, 29 Apr 2021 19:16:07 +0200 [thread overview]
Message-ID: <dfc5f677-d88a-0c7e-6143-35b79b6363e1@daniel-mendler.de> (raw)
In-Reply-To: <9de0a112-9e68-d645-451e-084a3c7c6725@yandex.ru>
On 4/29/21 7:09 PM, Dmitry Gutov wrote:
> If affixation-function didn't return a three-element list (and instead
> only returned some focused information pertaining to a single value),
> you wouldn't have this problem.
I don't understand the argument here. From my perspective the
`affixation-function` is good as is. It is a generalization of the
`annotation-function` which allows transformation of all candidates at
once and it additionally allows prefixes. However one could discuss if
the affixation function should be allowed to transform the actual
candidate string, as has been mentioned in the discussion before. I
think one can set text properties but one is not allowed to change the
candidate string - this will break `choose-completion`.
Daniel
next prev parent reply other threads:[~2021-04-29 17:16 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 13:32 [PATCH] `completing-read`: Add `group-function` support to completion metadata Daniel Mendler
2021-04-25 19:35 ` Dmitry Gutov
2021-04-25 19:47 ` Daniel Mendler
2021-04-25 21:50 ` Dmitry Gutov
2021-04-25 22:10 ` Daniel Mendler
2021-04-25 22:40 ` Dmitry Gutov
2021-04-25 22:58 ` Daniel Mendler
2021-04-26 4:51 ` Protesilaos Stavrou
2021-04-27 16:53 ` Juri Linkov
2021-04-28 6:18 ` Protesilaos Stavrou
2021-04-25 23:33 ` Stefan Monnier
2021-04-26 10:01 ` Daniel Mendler
2021-04-26 13:50 ` Stefan Monnier
2021-04-27 1:46 ` Dmitry Gutov
2021-04-27 1:59 ` tumashu
2021-04-27 2:45 ` Daniel Mendler
2021-04-27 15:47 ` Dmitry Gutov
2021-04-27 3:41 ` Stefan Monnier
2021-04-28 0:08 ` Dmitry Gutov
2021-04-28 3:21 ` Stefan Monnier
2021-04-25 19:38 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH) Daniel Mendler
2021-04-25 20:45 ` Juri Linkov
2021-04-25 21:26 ` Daniel Mendler
2021-04-29 16:20 ` Juri Linkov
2021-04-29 16:52 ` Daniel Mendler
2021-04-29 17:07 ` Stefan Monnier
2021-04-29 17:13 ` Daniel Mendler
2021-04-29 22:54 ` Juri Linkov
2021-04-29 23:55 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Daniel Mendler
2021-04-30 9:00 ` Daniel Mendler
2021-04-30 17:01 ` Juri Linkov
2021-04-30 18:11 ` Daniel Mendler
2021-04-30 18:30 ` Daniel Mendler
2021-05-01 19:57 ` Juri Linkov
2021-05-02 0:43 ` Daniel Mendler
2021-05-02 7:07 ` Eli Zaretskii
2021-05-02 11:01 ` Daniel Mendler
2021-04-30 16:51 ` Juri Linkov
2021-04-30 18:13 ` Daniel Mendler
2021-05-01 19:54 ` Juri Linkov
2021-05-02 0:32 ` Daniel Mendler
2021-05-02 21:38 ` Juri Linkov
2021-05-07 17:03 ` Juri Linkov
2021-05-07 17:55 ` Daniel Mendler
2021-05-08 6:24 ` Daniel Mendler
2021-05-08 8:45 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 4) Daniel Mendler
2021-05-08 9:10 ` Daniel Mendler
2021-05-09 17:59 ` Juri Linkov
2021-05-09 18:50 ` Daniel Mendler
2021-05-09 18:56 ` Stefan Monnier
2021-05-09 19:11 ` Daniel Mendler
2021-05-10 20:47 ` Juri Linkov
2021-05-11 7:51 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 5) Daniel Mendler
2021-05-11 17:59 ` Juri Linkov
2021-05-08 13:15 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Stefan Monnier
2021-05-09 18:05 ` Juri Linkov
2021-05-09 18:37 ` Eli Zaretskii
2021-05-11 18:06 ` Juri Linkov
2021-05-11 18:44 ` Eli Zaretskii
2021-05-11 18:58 ` Daniel Mendler
2021-05-11 19:22 ` Eli Zaretskii
2021-05-11 19:46 ` Daniel Mendler
2021-05-11 19:59 ` Eli Zaretskii
2021-05-11 20:30 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 6) Daniel Mendler
2021-05-13 10:32 ` Eli Zaretskii
2021-05-13 11:45 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 7) Daniel Mendler
2021-05-20 9:39 ` Daniel Mendler
2021-05-20 17:53 ` Juri Linkov
2021-05-20 18:51 ` Daniel Mendler
2021-04-29 17:09 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH) Dmitry Gutov
2021-04-29 17:16 ` Daniel Mendler [this message]
2021-04-29 17:55 ` Dmitry Gutov
2021-04-29 18:31 ` [External] : " Drew Adams
2021-04-29 20:25 ` Dmitry Gutov
2021-04-29 22:15 ` Drew Adams
2021-04-29 22:28 ` Dmitry Gutov
2021-04-29 23:31 ` Drew Adams
2021-04-29 19:21 ` Daniel Mendler
2021-05-02 14:29 ` [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 3) Daniel Mendler
2021-05-02 21:49 ` Juri Linkov
2021-05-03 14:40 ` Daniel Mendler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfc5f677-d88a-0c7e-6143-35b79b6363e1@daniel-mendler.de \
--to=mail@daniel-mendler.de \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.