From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30285: dired-do-chmod vs. top line of dired Date: Wed, 31 Jan 2018 11:04:46 -0800 (PST) Message-ID: References: <87mv0wg80c.fsf@jidanni.org> <87efm8snnr.fsf@gmail.com> <83efm8irac.fsf@gnu.org> <87d11sl08v.fsf@gmail.com> <1dd0ec16-7f13-4753-beef-0daeaf84ed8d@default> <91a8c271-5d11-4ec9-ac95-ed8de1badc4b@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1517425419 14490 195.159.176.226 (31 Jan 2018 19:03:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 31 Jan 2018 19:03:39 +0000 (UTC) Cc: 30285@debbugs.gnu.org, jidanni@jidanni.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 31 20:03:35 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egxf6-0002Cj-49 for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jan 2018 20:03:12 +0100 Original-Received: from localhost ([::1]:52082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egxh7-0007PO-3B for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jan 2018 14:05:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egxgy-0007NT-BD for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 14:05:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egxgs-00075I-9W for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 14:05:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43615) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egxgs-000758-4b for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 14:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egxgr-0003Ld-SF for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 14:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Jan 2018 19:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30285-submit@debbugs.gnu.org id=B30285.151742550012859 (code B ref 30285); Wed, 31 Jan 2018 19:05:01 +0000 Original-Received: (at 30285) by debbugs.gnu.org; 31 Jan 2018 19:05:00 +0000 Original-Received: from localhost ([127.0.0.1]:51512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egxgq-0003LL-Dz for submit@debbugs.gnu.org; Wed, 31 Jan 2018 14:05:00 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:43616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egxgn-0003L4-HP for 30285@debbugs.gnu.org; Wed, 31 Jan 2018 14:04:57 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w0VJ2Gcc129926; Wed, 31 Jan 2018 19:04:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=oEJIftcbkGOjv7WRHCaX7vkL/IkX9I8F6oWXxZu5AAI=; b=dUdDiXkT2wWnh+IDMsa8F3hvVcp8aB6c8DXzB8otejjsNj5gLQNqR3FCGnkvqmv7/dK2 bBi9ZW4/MN9L5afvgh7ke56u2arNXjieGB/YugugdITnecyFb4in5zOTQ7uIacEbmWZl ljECpGEhkmIhbuzRDaat/n3BokSVRFM4nBrLxIipQ1E4rZBs51zdwB7+zMyvyESy6L0X uTMQ5vacgAG8a4FJPDkaAL8bAQaRC5SlWZsE+RAIQtn+L3L7A2gQL3Tb+PkigTtxyhM8 UT0n23bBfnKqj953bBH614gdJkATdAOkCcjqOi2zNyvcRzuR2e9U7IR2uNFFciFbNTMZ vg== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2fuc8kjhu8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Jan 2018 19:04:50 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w0VJ4n85015229 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 31 Jan 2018 19:04:49 GMT Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w0VJ4ldV028916; Wed, 31 Jan 2018 19:04:47 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4639.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8791 signatures=668659 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=876 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801310241 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142750 Archived-At: > > Obviously, for `dired-do-*' commands we still need to > > handle the case where files or dirs are marked. And > > in that case the command should DTRT even if called from > > a non-file line, i.e., one of the problematic places > > we've been discussing - it should not raise an error > > in that context. > > IIRC, my latest patch handle those situations pretty well. > Could you tested it and provide feedback about how to > improve it? >=20 > > For `dired-do-*' commands that already call > > `dired-get-marked-files' the clear solution, I think, > > is to just test that return value and raise an error > > if it is nil. > > > > If there are `dired-do-*' commands that do not call > > `dired-get-marked-files' then we have a choice how to > > solve the problem. But it might well be that even then > > the best solution is to use `dired-get-marked-files'. > > Since you are reluctant to the addition of the new predicate. > That's fine. > > May I ask you to provide an alternative patch to compare > with mine? Then, people here might do further feedback based > on those 2 alternatives. Sorry; I don't have time to work on this. I've already provided my suggestions - hope they help. Whatever you decide is fine by me. Thx.