From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode Date: Sat, 9 Dec 2023 20:18:22 +0200 Message-ID: References: <8734xdni6y.fsf@yandex.ru> <831qcwycbj.fsf@gnu.org> <83v8a3qh6m.fsf@gnu.org> <834jhadvkt.fsf@gnu.org> <7aee7e42-c07d-9131-18a9-4806f07d4267@gutov.dev> <83a5qw7izt.fsf@gnu.org> <172531702081590@mail.yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11587"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: "casouri@gmail.com" , "67061@debbugs.gnu.org" <67061@debbugs.gnu.org> To: Denis Zubarev , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 09 19:19:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rC1uu-0002qL-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Dec 2023 19:19:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rC1ub-0000p7-Rw; Sat, 09 Dec 2023 13:18:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rC1ua-0000ov-Ti for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 13:18:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rC1ua-00079w-KF for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 13:18:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rC1uo-0001yP-8l for bug-gnu-emacs@gnu.org; Sat, 09 Dec 2023 13:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Dec 2023 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67061 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67061-submit@debbugs.gnu.org id=B67061.17021459277560 (code B ref 67061); Sat, 09 Dec 2023 18:19:02 +0000 Original-Received: (at 67061) by debbugs.gnu.org; 9 Dec 2023 18:18:47 +0000 Original-Received: from localhost ([127.0.0.1]:48897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC1uZ-0001xs-BV for submit@debbugs.gnu.org; Sat, 09 Dec 2023 13:18:47 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rC1uX-0001xe-Ql for 67061@debbugs.gnu.org; Sat, 09 Dec 2023 13:18:46 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id B54E35C011B; Sat, 9 Dec 2023 13:18:26 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sat, 09 Dec 2023 13:18:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1702145906; x=1702232306; bh=3RChE8JvGJoxuurDnjgtT7ON99YKB9CAgSS gkFRJlcI=; b=xGhQgu3ezNH215LVYgeJMJWh4m6FSVZk8WaiUK4Cpxnb1L7yDxp LmR+Qakvk/tXQKWcc/uN8t/gH63HfN9/TZgU/saMyFNv5J0V+iJLZbIDbBwS/NcG Rt2rBny9V9n3t9mVhmgb8fII1ZTLaNCrJRJjp22vCtTOz/IqrvJllKpJXiTHxPbi ZlH/fRlBLHUkCPDFGhq9d7i/Hgx2TkvQW0qBxlgsNtUiVId8+q9fe5xKW/UbyHCe jA3JX5ti8xSd9WH1j4+c9O+AutkrcgY7DT62nl8T3lreWOPXVKzcYmR1yp2nfpsX yxuAMC6S7opEYIhj5LeA0Q1jszMuruhFTZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1702145906; x=1702232306; bh=3RChE8JvGJoxuurDnjgtT7ON99YKB9CAgSS gkFRJlcI=; b=cTVUMBzXkQanhj/SwjQ8PGBuSf+X5IgbVSYC3nSYYrPBnLZXE/4 SEgv5AiP/IaKx7/S+u/p+RLKFsYhp4AH0QP/GVZOf9PfiVI0mb6y2GqDpKzgF49F Q+XJrduaSUi0SkWAdRoLZXgPjTz0A3+l/XHkl1XXB5RXIMgwULS25Vx/nAMznujz +tW5O4I4tZCf0u1jd96B211YWO+nY+srxyw+/G5R/Tusiq9OHhyxM2T76sNsDmMi 2oU103rHkUJsatz16YVIZVJWWqKHXm5spkPmLH+1DAuU+AJz7MEt/fGwk4KL9vxi azgrIwAE+IbRESEo3d2gDvLYD1v0+JyXWFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudekkedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Dec 2023 13:18:25 -0500 (EST) Content-Language: en-US In-Reply-To: <172531702081590@mail.yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275874 Archived-At: On 09/12/2023 02:39, Denis Zubarev wrote: > assignment feature: > For all examples, > `for var in range(3)` > `var1[ii] = 1; t.var2[jj] = 2` > `var := 3` > `var *= 3` > highlight var as font-lock-variable-name-face Arguably, the last 2 lines are "variable references" rather than definitions (so font-lock-variable-use-face might make more sense), since such operators imply that a variable has already been defined previously. And python--treesit-fontify-variable (in the 'variable' feature) already applies that face. The first example, however, should indeed use font-lock-variable-name-face.