From: Paul Eggert <eggert@cs.ucla.edu>
To: rms@gnu.org
Cc: Stromeko@nexgo.de, emacs-devel@gnu.org
Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken.
Date: Mon, 22 Apr 2019 20:48:54 -0700 [thread overview]
Message-ID: <dea001b8-0dc4-1f01-54a1-982f8517dd7b@cs.ucla.edu> (raw)
In-Reply-To: <E1hIkQm-000179-IM@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 397 bytes --]
Richard Stallman wrote:
> The code only has to be written once; then people will copy it into
> other programs that use the same general approach with GNU Make.
After writing a patch along these lines, I somewhat doubt whether it will be
worth the trouble. But if it causes trouble I suppose we can always go back to
what Emacs 25 and 26 do. So I installed the patch into master; see attached.
[-- Attachment #2: 0001-Let-plain-make-work-even-not-GNU-Make.txt --]
[-- Type: text/plain, Size: 1438 bytes --]
From 6fa8d3c894062e7d3bde2d1ed35b40f2272e59f5 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 22 Apr 2019 20:44:11 -0700
Subject: [PATCH] =?UTF-8?q?Let=20plain=20=E2=80=98make=E2=80=99=20work=20e?=
=?UTF-8?q?ven=20not=20GNU=20Make?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* Makefile.in (top_distclean): Clean makefile as well as Makefile.
* configure.ac: If not using plain ‘make’, create a makefile
so that plain ‘make’ simply calls $(MAKE).
---
Makefile.in | 2 +-
configure.ac | 10 +++++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/Makefile.in b/Makefile.in
index 53703638c4..6b99d24da4 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -869,7 +869,7 @@ top_bootclean=
top_distclean=\
${top_bootclean}; \
rm -f config.status config.log~ \
- Makefile lib/gnulib.mk ${SUBDIR_MAKEFILES}
+ Makefile makefile lib/gnulib.mk ${SUBDIR_MAKEFILES}
distclean_dirs = $(clean_dirs) leim lisp
diff --git a/configure.ac b/configure.ac
index 0ecb8c40e6..8b363c7fca 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5814,4 +5814,12 @@ m4_define
esac
fi
-test "$MAKE" = make || AC_MSG_NOTICE([Now you can run '$MAKE'.])
+# Let plain 'make' work.
+test "$MAKE" = make || test -f makefile || cat >makefile <<EOF
+.POSIX:
+MAKE = $MAKE
+all:
+ \$(MAKE) -f Makefile \$?
+.DEFAULT:
+ \$(MAKE) -f Makefile \$<
+EOF
--
2.17.1
next prev parent reply other threads:[~2019-04-23 3:48 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 20:21 CHECK_STRUCTS/dmpstruct.h mechanism is broken Alan Mackenzie
2019-02-28 20:55 ` Eli Zaretskii
2019-02-28 20:59 ` Alan Mackenzie
2019-03-01 7:31 ` Eli Zaretskii
2019-03-01 13:09 ` Alan Mackenzie
2019-03-05 2:17 ` Paul Eggert
2019-04-09 22:47 ` Paul Eggert
2019-04-10 13:12 ` Andy Moreton
2019-04-10 14:59 ` Andy Moreton
2019-04-10 17:36 ` Paul Eggert
2019-04-10 19:26 ` Andy Moreton
2019-04-10 19:43 ` Daniel Colascione
2019-04-10 16:22 ` Alan Mackenzie
2019-04-10 18:05 ` Paul Eggert
2019-04-10 19:45 ` Alan Mackenzie
2019-04-10 20:11 ` Daniel Colascione
2019-04-11 4:11 ` Paul Eggert
2019-04-15 12:36 ` Andy Moreton
2019-04-15 15:32 ` Andy Moreton
2019-04-15 15:53 ` Paul Eggert
2019-04-11 13:13 ` Stefan Monnier
2019-04-11 4:17 ` Paul Eggert
2019-04-10 18:47 ` Daniel Colascione
2019-04-10 18:58 ` Paul Eggert
2019-04-10 19:02 ` Daniel Colascione
2019-04-10 19:22 ` Eli Zaretskii
2019-04-11 9:35 ` Robert Pluim
2019-04-11 18:31 ` Paul Eggert
2019-04-11 19:15 ` Eli Zaretskii
2019-04-11 22:13 ` Daniel Colascione
2019-04-12 6:44 ` Eli Zaretskii
2019-04-11 22:23 ` Paul Eggert
2019-04-11 22:26 ` Daniel Colascione
2019-04-11 22:38 ` Paul Eggert
2019-04-12 6:39 ` Eli Zaretskii
2019-04-12 19:40 ` Paul Eggert
2019-04-13 9:36 ` Eli Zaretskii
2019-04-14 2:52 ` Paul Eggert
2019-04-12 12:21 ` Andy Moreton
2019-04-12 13:37 ` Alan Mackenzie
2019-04-12 13:55 ` Eli Zaretskii
2019-04-12 13:58 ` Noam Postavsky
2019-04-13 14:06 ` Alan Mackenzie
2019-04-13 14:46 ` About ./configure --cache-file (WAS: CHECK_STRUCTS/dmpstruct.h mechanism is broken.) Noam Postavsky
2019-04-14 2:44 ` Paul Eggert
2019-04-14 3:26 ` Daniel Colascione
2019-04-14 3:49 ` Noam Postavsky
2019-04-14 9:45 ` Alan Mackenzie
2019-04-14 14:08 ` Eli Zaretskii
2019-04-14 14:44 ` Noam Postavsky
2019-04-14 14:53 ` Eli Zaretskii
2019-04-13 8:11 ` CHECK_STRUCTS/dmpstruct.h mechanism is broken Achim Gratz
2019-04-14 2:52 ` Paul Eggert
2019-04-14 3:28 ` Daniel Colascione
2019-04-14 7:22 ` Achim Gratz
2019-04-14 23:29 ` Paul Eggert
2019-04-15 11:31 ` Alan Mackenzie
2019-04-15 14:14 ` Paul Eggert
2019-04-15 18:11 ` Richard Stallman
2019-04-16 18:10 ` Paul Eggert
2019-04-22 2:18 ` Richard Stallman
2019-04-22 4:07 ` Paul Eggert
2019-04-23 1:41 ` Richard Stallman
2019-04-23 3:48 ` Paul Eggert [this message]
2019-04-23 6:25 ` Eli Zaretskii
2019-04-23 16:28 ` Paul Eggert
2019-04-23 17:08 ` Eli Zaretskii
2019-04-23 17:19 ` Stefan Monnier
2019-04-24 2:26 ` Richard Stallman
2019-04-15 3:36 ` Richard Stallman
2019-04-15 5:30 ` Paul Eggert
2019-04-11 19:55 ` Achim Gratz
2019-04-11 22:10 ` Daniel Colascione
2019-04-11 22:47 ` Paul Eggert
2019-04-11 22:44 ` Paul Eggert
2019-04-12 17:02 ` Daniele Nicolodi
2019-04-13 8:26 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dea001b8-0dc4-1f01-54a1-982f8517dd7b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=Stromeko@nexgo.de \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.