From: Daniel Colascione <dancol@dancol.org>
To: emacs-devel@gnu.org
Subject: [PATCH 8/9] Generalize fork+exec logic, add DAEMON_MUST_EXEC
Date: Tue, 07 Aug 2012 01:19:27 -0700 [thread overview]
Message-ID: <de42ff3ea4e662fffbd0082157aa2b3bc8832dbe.1344326992.git.dancol@dancol.org> (raw)
In-Reply-To: <cover.1344326992.git.dancol@dancol.org>
---
src/emacs.c | 38 ++++++++++++++++++++++++--------------
1 files changed, 24 insertions(+), 14 deletions(-)
diff --git a/src/emacs.c b/src/emacs.c
index a4fab12..022d46d 100644
--- a/src/emacs.c
+++ b/src/emacs.c
@@ -161,6 +161,22 @@ static void *my_heap_start;
static uprintmax_t heap_bss_diff;
#endif
+/* To run as a daemon under Cocoa or Windows, we must do a fork+exec,
+ not a simple fork.
+
+ On Cocoa, CoreFoundation lib fails in forked process:
+ http://developer.apple.com/ReleaseNotes/
+ CoreFoundation/CoreFoundation.html)
+
+ On Windows, a Cygwin fork child cannot access the USER subsystem.
+
+ We mark being in the exec'd process by a daemon name argument of
+ form "--daemon=\nFD0,FD1\nNAME" where FD are the pipe file descriptors,
+ NAME is the original daemon name, if any. */
+#if defined (NS_IMPL_COCOA) || defined (HAVE_NTGUI)
+# define DAEMON_MUST_EXEC
+#endif
+
/* Nonzero means running Emacs without interactive terminal. */
int noninteractive;
@@ -706,9 +722,9 @@ main (int argc, char **argv)
int no_loadup = 0;
char *junk = 0;
char *dname_arg = 0;
-#ifdef NS_IMPL_COCOA
+#ifdef DAEMON_MUST_EXEC
char dname_arg2[80];
-#endif
+#endif /* DAEMON_MUST_EXEC */
char *ch_to_dir;
#if GC_MARK_STACK
@@ -1010,25 +1026,19 @@ main (int argc, char **argv)
exit (1);
}
-#ifndef NS_IMPL_COCOA
+#ifndef DAEMON_MUST_EXEC
#ifdef USE_GTK
fprintf (stderr, "\nWarning: due to a long standing Gtk+ bug\nhttp://bugzilla.gnome.org/show_bug.cgi?id=85715\n\
Emacs might crash when run in daemon mode and the X11 connection is unexpectedly lost.\n\
Using an Emacs configured with --with-x-toolkit=lucid does not have this problem.\n");
-#endif
+#endif /* USE_GTK */
f = fork ();
-#else /* NS_IMPL_COCOA */
- /* Under Cocoa we must do fork+exec as CoreFoundation lib fails in
- forked process: http://developer.apple.com/ReleaseNotes/
- CoreFoundation/CoreFoundation.html)
- We mark being in the exec'd process by a daemon name argument of
- form "--daemon=\nFD0,FD1\nNAME" where FD are the pipe file descriptors,
- NAME is the original daemon name, if any. */
+#else /* DAEMON_MUST_EXEC */
if (!dname_arg || !strchr (dname_arg, '\n'))
f = fork (); /* in orig */
else
f = 0; /* in exec'd */
-#endif /* NS_IMPL_COCOA */
+#endif /* !DAEMON_MUST_EXEC */
if (f > 0)
{
int retval;
@@ -1064,7 +1074,7 @@ Using an Emacs configured with --with-x-toolkit=lucid does not have this problem
exit (1);
}
-#ifdef NS_IMPL_COCOA
+#ifdef DAEMON_MUST_EXEC
{
/* In orig process, forked as child, OR in exec'd. */
if (!dname_arg || !strchr (dname_arg, '\n'))
@@ -1100,7 +1110,7 @@ Using an Emacs configured with --with-x-toolkit=lucid does not have this problem
dname_arg2);
dname_arg = *dname_arg2 ? dname_arg2 : NULL;
}
-#endif /* NS_IMPL_COCOA */
+#endif /* DAEMON_MUST_EXEC */
if (dname_arg)
daemon_name = xstrdup (dname_arg);
--
1.7.2.5
next prev parent reply other threads:[~2012-08-07 8:19 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 8:19 [PATCH 0/9] Support Win32 GUI in Cygwin Emacs Daniel Colascione
2012-08-07 8:19 ` [PATCH 2/9] Refactor window-system configuration Daniel Colascione
2012-08-07 17:20 ` Eli Zaretskii
2012-08-07 17:31 ` Daniel Colascione
2012-08-07 20:47 ` Stefan Monnier
2012-08-07 8:19 ` [PATCH 6/9] Rename `w32' local to `nt' for clarity Daniel Colascione
2012-08-07 10:49 ` Lennart Borgman
2012-08-07 15:45 ` Stefan Monnier
2012-08-07 16:31 ` Eli Zaretskii
2012-08-07 16:40 ` Drew Adams
2012-08-07 17:07 ` Daniel Colascione
2012-08-07 20:00 ` Stefan Monnier
2012-08-08 2:50 ` Eli Zaretskii
2012-08-07 8:19 ` [PATCH 7/9] Add alt_display to emacsclient for w32, ns Daniel Colascione
2012-08-07 15:22 ` Stefan Monnier
2012-08-07 8:19 ` [PATCH 9/9] Detect window-system from display name Daniel Colascione
2012-08-07 15:50 ` Stefan Monnier
2012-08-07 17:09 ` Daniel Colascione
2012-08-07 20:01 ` Stefan Monnier
2012-08-07 20:19 ` Daniel Colascione
2012-08-07 22:52 ` Lennart Borgman
2012-08-07 22:54 ` Daniel Colascione
2012-08-07 23:02 ` Lennart Borgman
2012-08-07 18:18 ` Eli Zaretskii
2012-08-07 20:28 ` Daniel Colascione
2012-08-08 16:50 ` Eli Zaretskii
2012-08-07 8:19 ` [PATCH 5/9] Prevent crash if w32 used before it's initialized Daniel Colascione
2012-08-07 17:23 ` Eli Zaretskii
2012-08-07 17:28 ` Daniel Colascione
2012-08-07 18:11 ` Eli Zaretskii
2012-08-07 8:19 ` Daniel Colascione [this message]
2012-08-07 8:19 ` [PATCH 4/9] Fix emacsclient to work with cygw32 Daniel Colascione
2012-08-07 18:14 ` Eli Zaretskii
2012-08-07 20:16 ` Daniel Colascione
2012-08-08 2:55 ` Eli Zaretskii
2012-08-07 8:19 ` [PATCH 1/9] Under Remote Desktop, NUMCOLORS is unreliable; workaround Daniel Colascione
2012-08-07 17:07 ` Eli Zaretskii
2012-08-07 8:19 ` [PATCH 3/9] Implement cygw32 Daniel Colascione
2012-08-07 15:40 ` Stefan Monnier
2012-08-07 18:02 ` Eli Zaretskii
2012-08-07 20:11 ` Daniel Colascione
2012-08-08 17:15 ` Eli Zaretskii
2012-08-07 17:22 ` [PATCH 0/9] Support Win32 GUI in Cygwin Emacs Eli Zaretskii
2012-08-07 17:29 ` Daniel Colascione
2012-08-07 18:10 ` Eli Zaretskii
2012-08-07 19:18 ` Eli Zaretskii
2012-08-07 20:15 ` Daniel Colascione
2012-08-07 20:24 ` Juanma Barranquero
2012-08-08 2:53 ` Eli Zaretskii
2012-08-08 2:33 ` Daniel Colascione
2012-08-08 3:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de42ff3ea4e662fffbd0082157aa2b3bc8832dbe.1344326992.git.dancol@dancol.org \
--to=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.