bug#67018: [PATCH] Add autoload cookie to vc-git-grep

bug#67018: [PATCH] Add autoload cookie to vc-git-grep

[Alyssa Ross]

---
 lisp/vc/vc-git.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 707fc7cfc07..fe48d5fbd3d 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1930,6 +1930,7 @@ vc-git-prepare-patch
 (defvar compilation-environment)
 
 ;; Derived from `lgrep'.
+;;;###autoload
 (defun vc-git-grep (regexp &optional files dir)
   "Run git grep, searching for REGEXP in FILES in directory DIR.
 The search is limited to file names matching shell pattern FILES.

base-commit: 5d171d26c00aefaef1496dede69337946a1edb14
-- 
2.42.0

bug#67018: [PATCH] Add autoload cookie to vc-git-grep

[Eli Zaretskii]

> From: Alyssa Ross <hi@alyssa.is>
> Date: Thu,  9 Nov 2023 15:46:30 +0100
> 
> ---
>  lisp/vc/vc-git.el | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
> index 707fc7cfc07..fe48d5fbd3d 100644
> --- a/lisp/vc/vc-git.el
> +++ b/lisp/vc/vc-git.el
> @@ -1930,6 +1930,7 @@ vc-git-prepare-patch
>  (defvar compilation-environment)
>  
>  ;; Derived from `lgrep'.
> +;;;###autoload
>  (defun vc-git-grep (regexp &optional files dir)
>    "Run git grep, searching for REGEXP in FILES in directory DIR.
>  The search is limited to file names matching shell pattern FILES.

Thanks, but please explain the motivation.  Which package needs to
autoload this function and why?

bug#67018: [PATCH] Add autoload cookie to vc-git-grep

[Alyssa Ross]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Alyssa Ross <hi@alyssa.is>
>> Date: Thu,  9 Nov 2023 15:46:30 +0100
>> 
>> ---
>>  lisp/vc/vc-git.el | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
>> index 707fc7cfc07..fe48d5fbd3d 100644
>> --- a/lisp/vc/vc-git.el
>> +++ b/lisp/vc/vc-git.el
>> @@ -1930,6 +1930,7 @@ vc-git-prepare-patch
>>  (defvar compilation-environment)
>>  
>>  ;; Derived from `lgrep'.
>> +;;;###autoload
>>  (defun vc-git-grep (regexp &optional files dir)
>>    "Run git grep, searching for REGEXP in FILES in directory DIR.
>>  The search is limited to file names matching shell pattern FILES.
>
> Thanks, but please explain the motivation.  Which package needs to
> autoload this function and why?

Often running M-x vc-git-grep is the first thing I do after starting
Emacs.  I think it would be good if it was autoloaded, so I didn't have
to M-x load-library vc-git first, or try to set up autoloading just for
myself in my Emacs configuration.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#67018: [PATCH] Add autoload cookie to vc-git-grep

[Eli Zaretskii]

> From: Alyssa Ross <hi@alyssa.is>
> Cc: 67018@debbugs.gnu.org
> Date: Thu, 09 Nov 2023 16:05:32 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> +;;;###autoload
> >>  (defun vc-git-grep (regexp &optional files dir)
> >>    "Run git grep, searching for REGEXP in FILES in directory DIR.
> >>  The search is limited to file names matching shell pattern FILES.
> >
> > Thanks, but please explain the motivation.  Which package needs to
> > autoload this function and why?
> 
> Often running M-x vc-git-grep is the first thing I do after starting
> Emacs.  I think it would be good if it was autoloaded, so I didn't have
> to M-x load-library vc-git first, or try to set up autoloading just for
> myself in my Emacs configuration.

By the same token we should autoload every command in every Lisp
package we have?  Because there are a lot of commands that are not
autoloaded, and you need to load their package to have them available.
I wonder what Dmitry and Stefan (both of them) think about this.

bug#67018: [PATCH] Add autoload cookie to vc-git-grep

[Dmitry Gutov]

On 09/11/2023 17:13, Eli Zaretskii wrote:
>> From: Alyssa Ross<hi@alyssa.is>
>> Cc:67018@debbugs.gnu.org
>> Date: Thu, 09 Nov 2023 16:05:32 +0100
>>
>> Eli Zaretskii<eliz@gnu.org>  writes:
>>
>>>> +;;;###autoload
>>>>   (defun vc-git-grep (regexp &optional files dir)
>>>>     "Run git grep, searching for REGEXP in FILES in directory DIR.
>>>>   The search is limited to file names matching shell pattern FILES.
>>> Thanks, but please explain the motivation.  Which package needs to
>>> autoload this function and why?
>> Often running M-x vc-git-grep is the first thing I do after starting
>> Emacs.  I think it would be good if it was autoloaded, so I didn't have
>> to M-x load-library vc-git first, or try to set up autoloading just for
>> myself in my Emacs configuration.
> By the same token we should autoload every command in every Lisp
> package we have?  Because there are a lot of commands that are not
> autoloaded, and you need to load their package to have them available.
> I wonder what Dmitry and Stefan (both of them) think about this.

A lot of commands don't make sense outside of major or minor mode, so we 
only have to autoload the modes in those cases.

If 'vc-git-grep' is an independent entry point, it should make sense to 
autoload it. I suppose vc-git is not loaded at the beginning of the 
session because no [Git-controlled] file has been visited yet.

I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x 
p g'). Just in case Alyssa was not aware of it.

bug#67018: [PATCH] Add autoload cookie to vc-git-grep

[Stefan Kangas]

Dmitry Gutov <dmitry@gutov.dev> writes:

> If 'vc-git-grep' is an independent entry point, it should make sense to
> autoload it. I suppose vc-git is not loaded at the beginning of the
> session because no [Git-controlled] file has been visited yet.
>
> I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x
> p g'). Just in case Alyssa was not aware of it.

Makes sense to me.  So should we install this change?

bug#67018: [PATCH] Add autoload cookie to vc-git-grep

[Dmitry Gutov]

On 24/12/2023 16:47, Stefan Kangas wrote:
> Dmitry Gutov<dmitry@gutov.dev>  writes:
> 
>> If 'vc-git-grep' is an independent entry point, it should make sense to
>> autoload it. I suppose vc-git is not loaded at the beginning of the
>> session because no [Git-controlled] file has been visited yet.
>>
>> I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x
>> p g'). Just in case Alyssa was not aware of it.
> Makes sense to me.  So should we install this change?

My opinion is yes, in case that wasn't clear from the previous message.

bug#67018: [PATCH] Add autoload cookie to vc-git-grep

[Stefan Kangas]

Dmitry Gutov <dmitry@gutov.dev> writes:

> On 24/12/2023 16:47, Stefan Kangas wrote:
>> Dmitry Gutov<dmitry@gutov.dev>  writes:
>>
>>> If 'vc-git-grep' is an independent entry point, it should make sense to
>>> autoload it. I suppose vc-git is not loaded at the beginning of the
>>> session because no [Git-controlled] file has been visited yet.
>>>
>>> I think I'd also like to advertise 'project-find-regexp' (bound to 'C-x
>>> p g'). Just in case Alyssa was not aware of it.
>> Makes sense to me.  So should we install this change?
>
> My opinion is yes, in case that wasn't clear from the previous message.

Now done (commit e4e89e2cb66).  Thanks for the patch, Alyssa.