all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: 41684@debbugs.gnu.org
Subject: bug#41684: [PATCH] Highlight typed variables in python
Date: Sat, 13 Jun 2020 23:40:27 +0300	[thread overview]
Message-ID: <dde9304a7f920a6711ecbb1915352e70ea6d2288.camel@yandex.ru> (raw)
In-Reply-To: <m2v9juivkd.fsf@gmail.com>

On Sat, 2020-06-13 at 23:01 +0300, Andrii Kolomoiets wrote:
> Hi Konstantin,
> 
> > * progmodes/python.el (python-font-lock-keywords-maximum-decoration):
> > recognize typed variables like "foo: int = 1" as well.
> 
> Good work!
> 
> Any plans to recognize typed variables like "foo: List[int] = [1]" as
> well? ;-)

Thank you for the follow up! This is a good example to improve upon, I haven't
thought about it. I don't currently have plans, so if you wanted that, sure go
for it :) I'm mostly sending improvements as I work with Python at may dayjob, I
wasn't stumbling upon such construction there, so I'm not too worried just yet.

FTR: if anybody is interested why this font-lock-variable-face matters, the
color-identifiers-mode uses it to highlight identifiers in code with different
colors. Immensely helps in reading the code.






      reply	other threads:[~2020-06-13 20:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 11:51 bug#41684: [PATCH] Highlight typed variables in python Konstantin Kharlamov
2020-06-09 23:12 ` Konstantin Kharlamov
2020-06-13  7:35 ` Eli Zaretskii
2020-06-13  8:57   ` Konstantin Kharlamov
2020-06-13  9:15     ` Eli Zaretskii
2020-06-13  9:21       ` Konstantin Kharlamov
2020-06-13 10:44     ` Basil L. Contovounesios
2020-06-13 20:01 ` Andrii Kolomoiets
2020-06-13 20:40   ` Konstantin Kharlamov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dde9304a7f920a6711ecbb1915352e70ea6d2288.camel@yandex.ru \
    --to=hi-angel@yandex.ru \
    --cc=41684@debbugs.gnu.org \
    --cc=andreyk.mad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.