From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20241: 25.0.50; `setq' with only one argument Date: Wed, 25 Nov 2015 07:18:17 -0800 (PST) Message-ID: References: <20151123143112.83911.qmail@mail.muc.de> <62twoc5zdo.fsf@fencepost.gnu.org> <20151123193138.GG2004@acm.fritz.box> <20151124180452.GB1840@acm.fritz.box> <20151124210956.GC1840@acm.fritz.box> <20151125094155.GB2007@acm.fritz.box> <20151125110755.GC2007@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1448464770 16473 80.91.229.3 (25 Nov 2015 15:19:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Nov 2015 15:19:30 +0000 (UTC) Cc: John Wiegley , 20241@debbugs.gnu.org To: Alan Mackenzie , Artur Malabarba Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 25 16:19:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1bqf-0000kr-Gl for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2015 16:19:09 +0100 Original-Received: from localhost ([::1]:45886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1bqh-0006FI-5z for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Nov 2015 10:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1bqd-0006FC-Dp for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 10:19:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1bqZ-0006N0-8p for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 10:19:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1bqZ-0006Mw-5S for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 10:19:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a1bqY-0008V3-Hg for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2015 10:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2015 15:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20241-submit@debbugs.gnu.org id=B20241.144846472232640 (code B ref 20241); Wed, 25 Nov 2015 15:19:02 +0000 Original-Received: (at 20241) by debbugs.gnu.org; 25 Nov 2015 15:18:42 +0000 Original-Received: from localhost ([127.0.0.1]:52913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1bqE-0008UN-4N for submit@debbugs.gnu.org; Wed, 25 Nov 2015 10:18:42 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:40207) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a1bpt-0008Ti-0Y for 20241@debbugs.gnu.org; Wed, 25 Nov 2015 10:18:39 -0500 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tAPFIIas007707 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Nov 2015 15:18:19 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id tAPFIIUQ023903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 25 Nov 2015 15:18:18 GMT Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id tAPFIIun008212; Wed, 25 Nov 2015 15:18:18 GMT In-Reply-To: <20151125110755.GC2007@acm.fritz.box> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109233 Archived-At: > If you found four occurrences merely by grepping, there could well be > quite a few more. In the last one, for example, can we be sure that nil > is intended, not that the real argument has just been missed out? If you cannot now analyze the code properly to determine TRT, or contact the author to make that determination, then do the obvious (IMO): Assign a `nil' value explicitly where it is now assigned implicitly. AND flag that amended code with a comment saying what you've done, and that you don't currently know whether (a) there is a bug here or (b) `nil' is really what is needed. IOW: (1) At least just ensure that the code does the same thing that it does now, but respects the intended meaning of `setq'. (2) If you have to punt the careful analysis for later or for someone else, then add a comment to that effect. > Maybe having the byte compiler error out in this situation isn't such a > brilliant idea after all. IMO, the bug should be fixed to raise an _error at runtime_, for both interpreted and byte-compiled code. Whatever else the byte-compiler might do is less important, as long as it produces code that is comparable - e.g., code that will also raise an _error at runtime_. It's OK for a byte-compiler to be smart, but not smarter than the actual source code ;-). It should pretty much try to produce code that does the same thing, but hopefully usually does it quicker.