From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18421: 24.4.50; Allow Dired to use unrelated dir trees? Date: Sun, 7 Sep 2014 10:19:13 -0700 (PDT) Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1410110439 7520 80.91.229.3 (7 Sep 2014 17:20:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Sep 2014 17:20:39 +0000 (UTC) To: 18421@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 07 19:20:31 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XQg8Z-0000A7-3T for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Sep 2014 19:20:27 +0200 Original-Received: from localhost ([::1]:39005 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQg8Y-0005gc-L8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Sep 2014 13:20:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQg8M-0005Yk-9S for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 13:20:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQg8A-0004i0-P1 for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 13:20:14 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQg8A-0004hs-MT for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 13:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XQg8A-0003tv-0H for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Sep 2014 17:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18421 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18421-submit@debbugs.gnu.org id=B18421.141011036314934 (code B ref 18421); Sun, 07 Sep 2014 17:20:01 +0000 Original-Received: (at 18421) by debbugs.gnu.org; 7 Sep 2014 17:19:23 +0000 Original-Received: from localhost ([127.0.0.1]:32958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQg7W-0003sn-Lh for submit@debbugs.gnu.org; Sun, 07 Sep 2014 13:19:23 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:30652) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQg7U-0003sZ-Ds for 18421@debbugs.gnu.org; Sun, 07 Sep 2014 13:19:20 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s87HJDAt014518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <18421@debbugs.gnu.org>; Sun, 7 Sep 2014 17:19:13 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s87HJBCt017787 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <18421@debbugs.gnu.org>; Sun, 7 Sep 2014 17:19:12 GMT Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s87HJB2X000462 for <18421@debbugs.gnu.org>; Sun, 7 Sep 2014 17:19:11 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93107 Archived-At: > And we get rid of this `if' condition in `dired-insert-subdir- > newpos'? >=20 > (if (dired-tree-lessp dir new-dir) > ;; Insert NEW-DIR after DIR > (setq new-pos (dired-get-subdir-max elt) > alist nil)) >=20 > So the code does this unconditionally: >=20 > (setq new-pos (dired-get-subdir-max elt) > alist ()) No, that loses the normal insertion order. This seems to DTRT, however: (defun dired-insert-subdir-newpos (new-dir) ;; Find pos for new subdir, according to tree order. ;;(goto-char (point-max)) (let ((alist dired-subdir-alist) elt dir new-pos) (while alist (setq elt (car alist) alist (cdr alist) dir (car elt)) (if (dired-tree-lessp dir new-dir) ;; Insert NEW-DIR after DIR (setq new-pos (dired-get-subdir-max elt) alist ()) (setq new-pos (point-max)))) (goto-char new-pos)) ;; want a separating newline between subdirs (unless (eobp) (forward-line -1)) (insert "\n") (point))